Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submenu items not clickable when option "expand the menu in full width below the menu hamburger icon." is checked #780

Closed
ghost opened this issue Jan 25, 2021 · 0 comments
Labels
bug Something isn't working fixed [Priority : high]

Comments

@ghost
Copy link

ghost commented Jan 25, 2021

Reported : https://wordpress.org/support/topic/mobile-menu-doesnt-work-when-nimble-builder-is-activated/#post-13954336

Reason : this is because NB sets attributes data-sek-is-mobile-menu only when the option "expand the menu in full width below the menu hamburger icon." is checked.
And the click is prevented based on the check on isMobileMenu which is based on this not reliable attribute.

Solution : improve reliability of the data-sek-is-mobile-menu attribute => set the value based on actual width of the device, compared to the current breakpoint. In the future the mobile menu breakpoint will be customizable ( #779 )

@ghost ghost added bug Something isn't working [Priority : high] labels Jan 25, 2021
@ghost ghost closed this as completed in 176db20 Jan 25, 2021
@ghost ghost added the fixed label Jan 25, 2021
ghost pushed a commit that referenced this issue Jan 25, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed [Priority : high]
Projects
None yet
Development

No branches or pull requests

0 participants