Merge pull request #48 from prestodb/cran_fixes

Cran fixes - this is the latest state that appears on CRAN as v1.2.0.

Author: onurfiliz

.Rbuildignore

@@ -1,3 +1,4 @@
 ^CONTRIBUTING\.md$
 ^PATENTS$
 ^RPresto\.Rproj$
+^cran-comments\.md$

DESCRIPTION

@@ -1,12 +1,16 @@
 Package: RPresto
-Title: DBI connector to Presto
-Version: 1.1.1
+Title: DBI Connector to Presto
+Version: 1.2.0
 Authors@R: c(
     person('Onur Ismail', 'Filiz', , '[email protected]', role=c('aut', 'cre')),
     person('Sergey', 'Goder', , '[email protected]', role='aut'),
     person('John Myles', 'White', , '[email protected]', role='ctb')
     )
-Description: A DBI-compliant interface to Presto.
+Copyright: Facebook, Inc. 2015-present.
+Description: Implements a DBI compliant interface to Presto. Presto is
+    an open source distributed SQL query engine for running interactive
+    analytic queries against data sources of all sizes ranging from
+    gigabytes to petabytes: <https://prestodb.io/>.
 Depends:
     R (>= 3.1.0),
     methods
@@ -15,13 +19,15 @@ Imports:
     httr (>= 0.6),
     RCurl,
     jsonlite,
-    stringi
+    stringi,
+    stats
 Suggests:
     testthat,
-    dplyr (>= 0.4.1)
+    dplyr (>= 0.4.3)
 License: BSD_3_clause + file LICENSE
 URL: https://github.com/prestodb/RPresto
 BugReports: https://github.com/prestodb/RPresto/issues
+Encoding: UTF-8
 LazyData: true
 Collate:
     'PrestoDriver.R'
@@ -58,3 +64,4 @@ Collate:
     'src.presto.R'
     'src.translate.env.src.presto.R'
     'tbl.src.presto.R'
+RoxygenNote: 5.0.1

LICENSE

@@ -1,30 +1,3 @@
-BSD License
-
-For RPresto software
-
-Copyright (c) 2015-present, Facebook, Inc. All rights reserved.
-
-Redistribution and use in source and binary forms, with or without modification,
-are permitted provided that the following conditions are met:
-
- * Redistributions of source code must retain the above copyright notice, this
-   list of conditions and the following disclaimer.
-
- * Redistributions in binary form must reproduce the above copyright notice,
-   this list of conditions and the following disclaimer in the documentation
-   and/or other materials provided with the distribution.
-
- * Neither the name Facebook nor the names of its contributors may be used to
-   endorse or promote products derived from this software without specific
-   prior written permission.
-
-THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND
-ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
-WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
-DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR
-ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
-(INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
-LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
-ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
-(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
-SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+YEAR: 2015-present
+COPYRIGHT HOLDER: Facebook, Inc. All rights reserved.
+ORGANIZATION: Facebook

NAMESPACE

@@ -1,4 +1,4 @@
-# Generated by roxygen2 (4.1.1): do not edit by hand
+# Generated by roxygen2: do not edit by hand
 
 export(Presto)
 export(copy_to.src_presto)
@@ -31,7 +31,10 @@ exportMethods(dbUnloadDriver)
 exportMethods(fetch)
 exportMethods(show)
 import(DBI)
+importFrom(methods,getPackageName)
+importFrom(methods,new)
 importFrom(methods,setClass)
 importFrom(methods,setGeneric)
 importFrom(methods,setMethod)
 importFrom(methods,setRefClass)
+importFrom(methods,show)

NEWS.md

@@ -0,0 +1,26 @@
+# RPresto 1.2.0
+
+- Add a `session.timezone` parameter to `dbConnect` and `src_presto` which
+  defaults to UTC.  This affects the timestamps returned for Presto data types
+  "TIMESTAMP".  We handle the ambiguity by assigning a time zone to _every_
+  POSIXct column returned. Note that if you are doing `as.character()` directly
+  on these columns, the values you obtain will be different from what happened
+  before.
+- Fix the way we handle zero row multiple column query results. This will
+  affect `LIMIT 0` queries specifically.
+
+# RPresto 1.1.1
+
+- Minor dplyr related fixes
+- Drop the R version requirement from 3.1.1 to 3.1.0
+- Speed-up in binding chunks if dplyr is available.
+- Handle special values like Infinity, NaN.
+
+# RPresto 1.1.0
+
+- Add optional dplyr support. One can initiate a connection via `src_presto`.
+- Minor documentation fixes.
+
+# RPresto 1.0.0
+
+- Initial release to github

R/PrestoDriver.R

@@ -10,6 +10,9 @@
 #'
 #' @keywords internal
 #' @export
+#' @importFrom methods setClass setGeneric setMethod setRefClass
+#' @importFrom methods show getPackageName new
+#' @import DBI
 setClass('PrestoDriver',
   contains='DBIDriver'
 )

R/PrestoResult.R

@@ -11,6 +11,7 @@ NULL
 #' An S4 class to represent a Presto Result
 #' @slot post.response The initial response from the HTTP API
 #' @slot statement The SQL statement sent to the database
+#' @slot session.timezone Session time zone used for the connection
 #' @slot cursor An internal implementation detail for keeping track of
 #'  what stage a request is in
 #' @keywords internal

R/copy.to.src.presto.R

@@ -5,6 +5,10 @@
 # LICENSE file in the root directory of this source tree. An additional grant
 # of patent rights can be found in the PATENTS file in the same directory.
 
+#' S3 implementation of \code{\link[dplyr]{copy_to}} for Presto.
+#'
+#' @rdname dplyr_function_implementations
+#' @keywords internal
 #' @export
 copy_to.src_presto <- function(dest, df) {
   stop("Not implemented.")

R/db.data.type.PrestoConnection.R

@@ -5,6 +5,10 @@
 # LICENSE file in the root directory of this source tree. An additional grant
 # of patent rights can be found in the PATENTS file in the same directory.
 
+#' S3 implementation of \code{\link[dplyr]{db_data_type}} for Presto.
+#'
+#' @rdname dplyr_function_implementations
+#' @keywords internal
 #' @export
 db_data_type.PrestoConnection <- function(con, fields, ...) {
   return(sapply(fields, function(field) dbDataType(Presto(), field)))

R/db.explain.PrestoConnection.R

@@ -5,6 +5,10 @@
 # LICENSE file in the root directory of this source tree. An additional grant
 # of patent rights can be found in the PATENTS file in the same directory.
 
+#' S3 implementation of \code{\link[dplyr]{db_explain}} for Presto.
+#'
+#' @rdname dplyr_function_implementations
+#' @keywords internal
 #' @export
 db_explain.PrestoConnection <- function(con, sql, ...) {
   explain.sql <- dplyr::build_sql("EXPLAIN ", sql)