Skip to content

Commit 2a53277

Browse files
RFC for Open Telemetry Implementation for Presto.
1 parent 8c51e68 commit 2a53277

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

RFC-0009-open-telemetry.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ The OSS Presto had a basic implementation of Open Telemetry.
2626

2727
## Proposed Implementation
2828

29-
The Presto can be manually instrumented and will have the following advantages.
29+
Presto can be manually instrumented and will have the following advantages.
3030
- More flexibility and control over instrumentation
3131
- Easier to customize what operations can be monitored
3232
- Ability to pass additional information as span attributes and events
@@ -39,7 +39,7 @@ The Presto can be manually instrumented and will have the following advantages.
3939
- While performing any operations, Presto adds the required attributes and events to the respective span.
4040
- In case of sub operations (child span), Presto creates child span, extract the parent context and attach to the child span as parent context so that all parent and child spans get connected.
4141
- After the operation spans will get ended in the order of creation and update the span state.
42-
- SDK keeps on checking the flush trigger and if it reaches the batch, all those spans got batched and send to backend.
42+
- The SDK continuously checks the flush trigger, and when it reaches the batch size, all spans are batched and sent to the backend.
4343
- Backend is a system to store, analyse and visualize this telemetry data. Common backends include systems like Jaeger, Instana, Grafana stack, etc.
4444

4545
![Context propagation](/RFC-0009-open-telemetry/context-propagation-coordinator-to-worker.png)
@@ -69,7 +69,7 @@ Based on the discussion, this may need to be updated with feedback from reviewer
6969
Presto Open Telemetry can be configured by modifying the values in presto-main/etc/telemetry.properties
7070

7171
```properties
72-
otel-factory.name=otel
72+
tracing-factory.name=otel
7373
tracing-enabled=false
7474
tracing-backend-url=<backend endpoint>
7575
max-exporter-batch-size=256
@@ -79,7 +79,7 @@ exporter-timeout=1024
7979
span-sampling=true
8080
```
8181

82-
***otel-factory.name***: unique identifier for OpenTelemetry factory implementation to be registered
82+
***tracing-factory.name***: unique identifier for factory implementation to be registered
8383

8484
***tracing-enabled***: boolean value controlling if tracing is on or off
8585

0 commit comments

Comments
 (0)