Skip to content

Commit

Permalink
RFC for Open Telemetry Implementation for Presto.
Browse files Browse the repository at this point in the history
  • Loading branch information
sureshbabu-areekara committed Nov 13, 2024
1 parent 8c51e68 commit 2a53277
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions RFC-0009-open-telemetry.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ The OSS Presto had a basic implementation of Open Telemetry.

## Proposed Implementation

The Presto can be manually instrumented and will have the following advantages.
Presto can be manually instrumented and will have the following advantages.
- More flexibility and control over instrumentation
- Easier to customize what operations can be monitored
- Ability to pass additional information as span attributes and events
Expand All @@ -39,7 +39,7 @@ The Presto can be manually instrumented and will have the following advantages.
- While performing any operations, Presto adds the required attributes and events to the respective span.
- In case of sub operations (child span), Presto creates child span, extract the parent context and attach to the child span as parent context so that all parent and child spans get connected.
- After the operation spans will get ended in the order of creation and update the span state.
- SDK keeps on checking the flush trigger and if it reaches the batch, all those spans got batched and send to backend.
- The SDK continuously checks the flush trigger, and when it reaches the batch size, all spans are batched and sent to the backend.
- Backend is a system to store, analyse and visualize this telemetry data. Common backends include systems like Jaeger, Instana, Grafana stack, etc.

![Context propagation](/RFC-0009-open-telemetry/context-propagation-coordinator-to-worker.png)
Expand Down Expand Up @@ -69,7 +69,7 @@ Based on the discussion, this may need to be updated with feedback from reviewer
Presto Open Telemetry can be configured by modifying the values in presto-main/etc/telemetry.properties

```properties
otel-factory.name=otel
tracing-factory.name=otel
tracing-enabled=false
tracing-backend-url=<backend endpoint>
max-exporter-batch-size=256
Expand All @@ -79,7 +79,7 @@ exporter-timeout=1024
span-sampling=true
```

***otel-factory.name***: unique identifier for OpenTelemetry factory implementation to be registered
***tracing-factory.name***: unique identifier for factory implementation to be registered

***tracing-enabled***: boolean value controlling if tracing is on or off

Expand Down

0 comments on commit 2a53277

Please sign in to comment.