🐛 Fix bugs introduced by drupal/coder 8.3.24 (#82)

Author: dpi

PreviousNextDrupal/ruleset.xml

@@ -62,6 +62,14 @@
     <!-- Drupal -->
     <rule ref="Drupal" />
 
+    <!-- Undo the DeclareStrictTypesMissing ignore introduced by
+         https://www.drupal.org/project/coder/issues/3407995
+         This must be placed after the above ref="Drupal"
+         -->
+    <rule ref="SlevomatCodingStandard.TypeHints.DeclareStrictTypes.DeclareStrictTypesMissing">
+        <severity>5</severity>
+    </rule>
+
     <!-- Drupal.Arrays -->
     <rule ref="Drupal.Arrays.Array.LongLineDeclaration"><severity>0</severity></rule>
 
@@ -77,4 +85,8 @@
     <rule ref="Drupal.Commenting.TodoComment.TodoFormat"><severity>0</severity></rule>
     <!-- Do not require @var for properties since PHP has property typing -->
     <rule ref="Drupal.Commenting.VariableComment.Missing"><severity>0</severity></rule>
+
+    <!-- Drupal.Functions -->
+    <!-- This duplicates SlevomatCodingStandard.Functions.RequireTrailingCommaInDeclaration -->
+    <rule ref="Drupal.Functions.MultiLineFunctionDeclaration.MissingTrailingComma"><severity>0</severity></rule>
 </ruleset>

composer.json

@@ -6,7 +6,7 @@
     "require": {
         "php": "^8.0",
         "dealerdirect/phpcodesniffer-composer-installer": "^1.0.0",
-        "drupal/coder": "^8.3.21",
+        "drupal/coder": "^8.3.24",
         "slevomat/coding-standard": "^8.13.2",
         "squizlabs/php_codesniffer": "^3.7.1"
     },

phpstan.neon

@@ -7,4 +7,6 @@ parameters:
 		- %currentWorkingDirectory%/vendor/squizlabs/php_codesniffer/autoload.php
 	excludePaths:
 		- %currentWorkingDirectory%/tests/*/fixtures/*
-	checkGenericClassInNonGenericObjectType: false
+	ignoreErrors:
+		-
+			identifier: missingType.generics