✨ Add SlevomatCodingStandard.ControlStructures.RequireNullSafeObjectOperator (#84)

Fixes #76

Author: dpi

PreviousNextDrupal/ruleset.xml

@@ -36,6 +36,9 @@
     <!-- SlevomatCodingStandard.Commenting -->
     <rule ref="SlevomatCodingStandard.Commenting.UselessInheritDocComment" />
 
+    <!-- SlevomatCodingStandard.ControlStructures -->
+    <rule ref="SlevomatCodingStandard.ControlStructures.RequireNullSafeObjectOperator" />
+
     <!-- SlevomatCodingStandard.Functions -->
     <rule ref="SlevomatCodingStandard.Functions.RequireTrailingCommaInCall" />
     <rule ref="SlevomatCodingStandard.Functions.RequireTrailingCommaInDeclaration" />

README.md

@@ -132,6 +132,7 @@ function doesAThing(array $data): int {
 #### SlevomatCodingStandard.Classes.ClassStructure
 #### SlevomatCodingStandard.Classes.RequireMultiLineMethodSignature
 #### SlevomatCodingStandard.Commenting.UselessInheritDocComment
+#### SlevomatCodingStandard.ControlStructures.RequireNullSafeObjectOperator
 #### SlevomatCodingStandard.Functions.RequireTrailingCommaInCall
 #### SlevomatCodingStandard.Functions.RequireTrailingCommaInDeclaration
 #### SlevomatCodingStandard.Functions.StaticClosure

tests/Sniffs/RequireNullSafeObjectOperatorTest.php

@@ -0,0 +1,29 @@
+<?php
+
+declare(strict_types=1);
+
+namespace PreviousNext\CodingStandard\Tests\Sniffs;
+
+use SlevomatCodingStandard\Sniffs\ControlStructures\RequireNullSafeObjectOperatorSniff;
+
+/**
+ * @covers \SlevomatCodingStandard\Sniffs\ControlStructures\RequireNullSafeObjectOperatorSniff
+ */
+final class RequireNullSafeObjectOperatorTest extends Base {
+
+  public function testNoError(): void {
+    $report = self::checkFile(__DIR__ . '/fixtures/RequireNullSafeObjectOperatorNoError.php');
+    self::assertNoSniffErrorInFile($report);
+  }
+
+  public function testMissing(): void {
+    $report = self::checkFile(__DIR__ . '/fixtures/RequireNullSafeObjectOperatorError.php');
+    self::assertSame(1, $report->getErrorCount());
+    self::assertSniffError($report, 6, RequireNullSafeObjectOperatorSniff::CODE_REQUIRED_NULL_SAFE_OBJECT_OPERATOR);
+  }
+
+  protected static function getSniffName(): string {
+    return 'SlevomatCodingStandard.ControlStructures.RequireNullSafeObjectOperator';
+  }
+
+}

tests/Sniffs/fixtures/RequireNullSafeObjectOperatorError.php

@@ -0,0 +1,8 @@
+<?php
+
+declare(strict_types=1);
+
+$a = new \stdClass();
+if ($a === NULL || $a->data === NULL) {
+  $c = 1;
+}

tests/Sniffs/fixtures/RequireNullSafeObjectOperatorNoError.php

@@ -0,0 +1,8 @@
+<?php
+
+declare(strict_types=1);
+
+$a = new \stdClass();
+if ($a?->data === NULL) {
+  $c = 1;
+}