Skip to content

Commit c034f85

Browse files
Bump the otel group across 1 directory with 4 updates (#134)
1 parent aaad044 commit c034f85

File tree

5 files changed

+27
-29
lines changed

5 files changed

+27
-29
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ and this project adheres to
88

99
### Updated
1010

11+
- Bumped opentelemetry version to 0.28
1112
- MSRV is now 1.81
1213

1314
---

Cargo.toml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,12 +37,12 @@ required-features = ["json-logger"]
3737

3838
# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
3939
[dependencies]
40-
opentelemetry = {version = "0.27", optional = true}
41-
opentelemetry-otlp = {version = "0.27", features = ["http-proto", "reqwest-client"], default-features = false, optional = true}
42-
opentelemetry_sdk = {version = "0.27", features = ["rt-tokio"], optional = true}
40+
opentelemetry = {version = "0.28", optional = true}
41+
opentelemetry-otlp = {version = "0.28", features = ["http-proto", "reqwest-blocking-client"], default-features = false, optional = true}
42+
opentelemetry_sdk = {version = "0.28", features = ["rt-tokio"], optional = true}
4343
tracing = {version = "0.1"}
4444
tracing-log = {version = "0.2"}
45-
tracing-opentelemetry = {version = "0.28", optional = true}
45+
tracing-opentelemetry = {version = "0.29", optional = true}
4646
tracing-subscriber = {version = "0.3", features = ["env-filter"]}
4747

4848
# serialization/deserialization

Dockerfile

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
11
FROM public.ecr.aws/prima/rust:1.81.0
22

3-
# Serve per avere l'owner dei file scritti dal container uguale all'utente Linux sull'host
3+
WORKDIR /code
4+
45
USER app
56

6-
WORKDIR /code
7+
COPY ["entrypoint", "/entrypoint"]
8+
9+
ENTRYPOINT ["/entrypoint"]
710

8-
ENTRYPOINT ["/bin/bash"]

entrypoint

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
#!/usr/bin/env bash
2+
3+
if [ "$1" == "mix" ]; then
4+
exec "$@"
5+
else [ -n "$1" ];
6+
sh -c "$@"
7+
fi

src/telemetry.rs

Lines changed: 10 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -32,17 +32,6 @@ pub fn configure<T>(config: &SubscriberConfig<T>) -> sdktrace::Tracer {
3232
.as_ref()
3333
.expect("Telemetry config must be provided when the `traces` feature is enabled.");
3434

35-
let runtime = {
36-
#[cfg(feature = "rt-tokio-current-thread")]
37-
{
38-
opentelemetry_sdk::runtime::TokioCurrentThread
39-
}
40-
#[cfg(not(feature = "rt-tokio-current-thread"))]
41-
{
42-
opentelemetry_sdk::runtime::Tokio
43-
}
44-
};
45-
4635
let collector_url = normalize_collector_url(&telemetry.collector_url);
4736

4837
let otlp_exporter = SpanExporter::builder()
@@ -51,14 +40,14 @@ pub fn configure<T>(config: &SubscriberConfig<T>) -> sdktrace::Tracer {
5140
.build()
5241
.expect("Failed to configure the OpenTelemetry OTLP span exporter");
5342

54-
let resource = Resource::new(vec![
55-
KeyValue::new("environment", config.env.to_string()),
56-
KeyValue::new("country", config.country.to_string()),
57-
KeyValue::new("service.name", telemetry.service_name.clone()),
58-
]);
43+
let resource = Resource::builder()
44+
.with_service_name(telemetry.service_name.clone())
45+
.with_attribute(KeyValue::new("environment", config.env.to_string()))
46+
.with_attribute(KeyValue::new("country", config.country.to_string()))
47+
.build();
5948

60-
let tracer_provider = sdktrace::TracerProvider::builder()
61-
.with_batch_exporter(otlp_exporter, runtime)
49+
let tracer_provider = sdktrace::SdkTracerProvider::builder()
50+
.with_batch_exporter(otlp_exporter)
6251
.with_resource(resource)
6352
.build();
6453

@@ -72,9 +61,10 @@ pub fn configure<T>(config: &SubscriberConfig<T>) -> sdktrace::Tracer {
7261
}
7362

7463
// Consider to remove this wrapper when https://github.com/open-telemetry/opentelemetry-rust/issues/1961 is resolved
75-
static TRACER_PROVIDER: Lazy<Mutex<Option<sdktrace::TracerProvider>>> = Lazy::new(Default::default);
64+
static TRACER_PROVIDER: Lazy<Mutex<Option<sdktrace::SdkTracerProvider>>> =
65+
Lazy::new(Default::default);
7666

77-
fn set_tracer_provider(new_provider: sdktrace::TracerProvider) {
67+
fn set_tracer_provider(new_provider: sdktrace::SdkTracerProvider) {
7868
global::set_tracer_provider(new_provider.clone());
7969

8070
let mut tracer_provider = TRACER_PROVIDER
@@ -84,8 +74,6 @@ fn set_tracer_provider(new_provider: sdktrace::TracerProvider) {
8474
}
8575

8676
pub(crate) fn shutdown_tracer_provider() {
87-
global::shutdown_tracer_provider();
88-
8977
let tracer_provider = TRACER_PROVIDER
9078
.lock()
9179
.expect("OpenTelemetry tracer provider mutex poisoned")

0 commit comments

Comments
 (0)