Skip to content

Commit 05c41f5

Browse files
committed
address filenode warnings
1 parent 194150d commit 05c41f5

File tree

2 files changed

+12
-8
lines changed

2 files changed

+12
-8
lines changed

client/modules/IDE/actions/files.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -11,15 +11,15 @@ import {
1111
import { setProjectSavedTime } from './project';
1212
import { createError } from './ide';
1313

14-
function appendToFilename(filename, string) {
14+
export function appendToFilename(filename, string) {
1515
const dotIndex = filename.lastIndexOf('.');
1616
if (dotIndex === -1) return filename + string;
1717
return (
1818
filename.substring(0, dotIndex) + string + filename.substring(dotIndex)
1919
);
2020
}
2121

22-
function createUniqueName(name, parentId, files) {
22+
export function createUniqueName(name, parentId, files) {
2323
const siblingFiles = files
2424
.find((file) => file.id === parentId)
2525
.children.map((childFileId) =>

client/modules/IDE/components/FileNode.jsx

+10-6
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@ import PropTypes from 'prop-types';
22
import classNames from 'classnames';
33
import React, { useState, useRef } from 'react';
44
import { connect } from 'react-redux';
5-
import { bindActionCreators } from 'redux';
65
import { useTranslation } from 'react-i18next';
6+
77
import * as IDEActions from '../actions/ide';
88
import * as FileActions from '../actions/files';
99
import DownArrowIcon from '../../../images/down-filled-triangle.svg';
@@ -353,7 +353,12 @@ const FileNode = ({
353353
<ul className="file-item__children">
354354
{children.map((childId) => (
355355
<li key={childId}>
356-
<ConnectedFileNode id={childId} parentId={id} />
356+
<ConnectedFileNode
357+
id={childId}
358+
parentId={id}
359+
canEdit={canEdit}
360+
onClickFile={onClickFile}
361+
/>
357362
</li>
358363
))}
359364
</ul>
@@ -402,13 +407,12 @@ function mapStateToProps(state, ownProps) {
402407
});
403408
}
404409

405-
function mapDispatchToProps(dispatch) {
406-
return bindActionCreators(Object.assign(FileActions, IDEActions), dispatch);
407-
}
410+
const mapDispatchToProps = { ...FileActions, ...IDEActions };
408411

409412
const ConnectedFileNode = connect(
410413
mapStateToProps,
411414
mapDispatchToProps
412415
)(FileNode);
413416

414-
export { FileNode, ConnectedFileNode as default };
417+
export { FileNode };
418+
export default ConnectedFileNode;

0 commit comments

Comments
 (0)