Skip to content

Commit 781ca82

Browse files
author
Mubashir Shariq
committed
removed redundant between client and server
1 parent 45c2ce1 commit 781ca82

File tree

4 files changed

+22
-94
lines changed

4 files changed

+22
-94
lines changed

client/components/createRedirectWithUsername.jsx

Lines changed: 0 additions & 29 deletions
This file was deleted.

client/routes.jsx

Lines changed: 8 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -17,13 +17,7 @@ import NewPasswordView from './modules/User/pages/NewPasswordView';
1717
import AccountView from './modules/User/pages/AccountView';
1818
import CollectionView from './modules/User/pages/CollectionView';
1919
import DashboardView from './modules/User/pages/DashboardView';
20-
import createRedirectWithUsername from './components/createRedirectWithUsername';
2120
import { getUser } from './modules/User/actions';
22-
import {
23-
userIsAuthenticated,
24-
userIsNotAuthenticated,
25-
userIsAuthorized
26-
} from './utils/auth';
2721

2822
/**
2923
* `params` is no longer a top-level route component prop in v4.
@@ -51,25 +45,19 @@ Route.propTypes = {
5145
const routes = (
5246
<Switch>
5347
<Route exact path="/" component={IDEView} />
54-
<Route path="/login" component={userIsNotAuthenticated(LoginView)} />
55-
<Route path="/signup" component={userIsNotAuthenticated(SignupView)} />
48+
<Route path="/login" component={LoginView} />
49+
<Route path="/signup" component={SignupView} />
5650
<Route
5751
path="/reset-password/:reset_password_token"
5852
component={NewPasswordView}
5953
/>
60-
<Route
61-
path="/reset-password"
62-
component={userIsNotAuthenticated(ResetPasswordView)}
63-
/>
54+
<Route path="/reset-password" component={ResetPasswordView} />
6455
<Route path="/verify" component={EmailVerificationView} />
6556
<Route path="/projects/:project_id" component={IDEView} />
6657
<Route path="/:username/full/:project_id" component={FullView} />
6758
<Route path="/full/:project_id" component={FullView} />
6859

69-
<Route
70-
path="/:username/assets"
71-
component={userIsAuthenticated(userIsAuthorized(DashboardView))}
72-
/>
60+
<Route path="/:username/assets" component={DashboardView} />
7361
<Route
7462
path="/:username/sketches/:project_id/add-to-collection"
7563
component={IDEView}
@@ -80,19 +68,12 @@ const routes = (
8068
path="/:username/collections/:collection_id"
8169
component={CollectionView}
8270
/>
83-
<Route path="/:username/collections" component={DashboardView} />
8471

85-
<Route
86-
path="/sketches"
87-
component={createRedirectWithUsername('/:username/sketches')}
88-
/>
89-
<Route
90-
path="/assets"
91-
component={createRedirectWithUsername('/:username/assets')}
92-
/>
93-
<Route path="/account" component={userIsAuthenticated(AccountView)} />
72+
<Route path="/:username/collections" component={DashboardView} />
73+
<Route path="/sketches" />
74+
<Route path="/assets" />
75+
<Route path="/account" component={AccountView} />
9476
<Route path="/about" component={IDEView} />
95-
9677
<Route path="/privacy-policy" component={PrivacyPolicy} />
9778
<Route path="/terms-of-use" component={TermsOfUse} />
9879
<Route path="/code-of-conduct" component={CodeOfConduct} />

client/utils/auth.js

Lines changed: 0 additions & 30 deletions
This file was deleted.

server/routes/server.routes.js

Lines changed: 14 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -71,11 +71,17 @@ router.get('/login', (req, res) => {
7171
});
7272

7373
router.get('/reset-password', (req, res) => {
74-
res.send(renderIndex());
74+
if (req.user) {
75+
return res.redirect('/account');
76+
}
77+
return res.send(renderIndex());
7578
});
7679

7780
router.get('/reset-password/:reset_password_token', (req, res) => {
78-
res.send(renderIndex());
81+
if (req.user) {
82+
return res.redirect('/account');
83+
}
84+
return res.send(renderIndex());
7985
});
8086

8187
router.get('/verify', (req, res) => {
@@ -84,18 +90,18 @@ router.get('/verify', (req, res) => {
8490

8591
router.get('/sketches', (req, res) => {
8692
if (req.user) {
87-
res.send(renderIndex());
88-
} else {
89-
res.redirect('/login');
93+
const { username } = req.user;
94+
return res.redirect(`/${username}/sketches`);
9095
}
96+
return res.redirect('/login');
9197
});
9298

9399
router.get('/assets', (req, res) => {
94100
if (req.user) {
95-
res.send(renderIndex());
96-
} else {
97-
res.redirect('/login');
101+
const { username } = req.user;
102+
return res.redirect(`/${username}/assets`);
98103
}
104+
return res.redirect('/login');
99105
});
100106

101107
router.get('/:username/assets', (req, res) => {

0 commit comments

Comments
 (0)