Skip to content

Commit cda292c

Browse files
authored
Summary translations for Tables in Collection, CollectionList, and SketchList (#1600)
* Summary translations for Collection, CollectionList, and SketchList * Fixes missing translation Toolbar by
1 parent 9ef9075 commit cda292c

File tree

6 files changed

+14
-6
lines changed

6 files changed

+14
-6
lines changed

client/modules/IDE/components/CollectionList/CollectionList.jsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ class CollectionList extends React.Component {
140140
{this._renderLoader()}
141141
{this._renderEmptyTable()}
142142
{this.hasCollections() &&
143-
<table className="sketches-table" summary="table containing all collections">
143+
<table className="sketches-table" summary={this.props.t('CollectionList.TableSummary')}>
144144
<thead>
145145
<tr>
146146
{this._renderFieldHeader('name', this.props.t('CollectionList.HeaderName'))}

client/modules/IDE/components/SketchList.jsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -433,7 +433,7 @@ class SketchList extends React.Component {
433433
{this._renderLoader()}
434434
{this._renderEmptyTable()}
435435
{this.hasSketches() &&
436-
<table className="sketches-table" summary="table containing all saved projects">
436+
<table className="sketches-table" summary={this.props.t('SketchList.TableSummary')}>
437437
<thead>
438438
<tr>
439439
{this._renderFieldHeader('name', this.props.t('SketchList.HeaderName'))}

client/modules/IDE/components/Toolbar.jsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ class Toolbar extends React.Component {
156156
if (this.props.owner) {
157157
return (
158158
<p className="toolbar__project-owner">
159-
by <Link to={`/${this.props.owner.username}/sketches`}>{this.props.owner.username}</Link>
159+
{this.props.t('Toolbar.By')} <Link to={`/${this.props.owner.username}/sketches`}>{this.props.owner.username}</Link>
160160
</p>
161161
);
162162
}

client/modules/User/components/Collection.jsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -371,7 +371,7 @@ class Collection extends React.Component {
371371
<div className="collection-table-wrapper">
372372
{this._renderEmptyTable()}
373373
{this.hasCollectionItems() &&
374-
<table className="sketches-table" summary="table containing all collections">
374+
<table className="sketches-table" summary={this.props.t('Collection.TableSummary')}>
375375
<thead>
376376
<tr>
377377
{this._renderFieldHeader('name', this.props.t('Collection.HeaderName'))}

translations/locales/en-US/translations.json

+5-1
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,8 @@
9999
"PlayOnlyVisualSketchARIA": "Play only visual sketch",
100100
"StopSketchARIA": "Stop sketch",
101101
"EditSketchARIA": "Edit sketch name",
102-
"NewSketchNameARIA": "New sketch name"
102+
"NewSketchNameARIA": "New sketch name",
103+
"By": " by "
103104
},
104105
"Console": {
105106
"Title": "Console",
@@ -407,6 +408,7 @@
407408
"NumSketches_plural": "{{count}} sketches",
408409
"By":"Collection by ",
409410
"NoSketches": "No sketches in collection",
411+
"TableSummary": "table containing all collections",
410412
"HeaderName": "Name",
411413
"HeaderCreatedAt": "Date Added",
412414
"HeaderUser": "Owner",
@@ -445,6 +447,7 @@
445447
"Title": "p5.js Web Editor | My collections",
446448
"AnothersTitle": "p5.js Web Editor | {{anotheruser}}'s collections",
447449
"NoCollections": "No collections.",
450+
"TableSummary": "table containing all collections",
448451
"HeaderName": "Name",
449452
"HeaderCreatedAt": "Date Created",
450453
"HeaderCreatedAt_mobile": "Created",
@@ -487,6 +490,7 @@
487490
"ButtonLabelAscendingARIA": "Sort by {{displayName}} ascending.",
488491
"ButtonLabelDescendingARIA": "Sort by {{displayName}} descending.",
489492
"AddToCollectionOverlayTitle": "Add to collection",
493+
"TableSummary": "table containing all saved projects",
490494
"HeaderName": "Sketch",
491495
"HeaderCreatedAt": "Date Created",
492496
"HeaderCreatedAt_mobile": "Created",

translations/locales/es-419/translations.json

+5-1
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,8 @@
9999
"PlayOnlyVisualSketchARIA": "Ejecutar bosquejo visual",
100100
"StopSketchARIA": "Detener bosquejo",
101101
"EditSketchARIA": "Editar nombre de bosquejo",
102-
"NewSketchNameARIA": "Nuevo nombre de bosquejo"
102+
"NewSketchNameARIA": "Nuevo nombre de bosquejo",
103+
"By": " de "
103104
},
104105
"Console": {
105106
"Title": "Consola",
@@ -407,6 +408,7 @@
407408
"NumSketches_plural": "{{count}} bosquejos",
408409
"By":"Colección por ",
409410
"NoSketches": "No hay bosquejos en la colección",
411+
"TableSummary": "tabla que contiene todas las colecciones",
410412
"HeaderName": "Nombre",
411413
"HeaderCreatedAt": "Fecha de agregación",
412414
"HeaderUser": "Propietario",
@@ -445,6 +447,7 @@
445447
"Title": "p5.js Web Editor | Mis colecciones",
446448
"AnothersTitle": "Editor Web p5.js | Colecciones de {{anotheruser}}",
447449
"NoCollections": "No hay colecciones.",
450+
"TableSummary": "la tabla contiene todas las colecciones",
448451
"HeaderName": "Nombre",
449452
"HeaderCreatedAt": "Fecha Creación",
450453
"HeaderCreatedAt_mobile": "Creación",
@@ -487,6 +490,7 @@
487490
"ButtonLabelAscendingARIA": "Ordenar por {{displayName}} ascendente.",
488491
"ButtonLabelDescendingARIA": "Ordenar por {{displayName}} descendente.",
489492
"AddToCollectionOverlayTitle": "Agregar a colección",
493+
"TableSummary": "la tabla contiene todos los proyectos guardados",
490494
"HeaderName": "Bosquejo",
491495
"HeaderCreatedAt": "Fecha Creación",
492496
"HeaderCreatedAt_mobile": "Creación",

0 commit comments

Comments
 (0)