added tests for isCode and small changes

Author: Vaivaswat2244

src/events/keyboard.js

@@ -4,7 +4,17 @@
  * @for p5
  * @requires core
  */
+export function isCode(input) {
+  if (typeof input !== 'string') {
+    return false;
+  }
 
+  if (input.length === 1 && /[0-9]/.test(input)) {
+    return true;
+  }
+  
+  return input.length > 1;
+}
 function keyboard(p5, fn){
   /**
    * A `Boolean` system variable that's `true` if any key is currently pressed
@@ -814,7 +824,7 @@ function keyboard(p5, fn){
    * <a href="https://keycode.info" target="_blank">keycode.info</a>.
    *
    * @method keyIsDown
-   * @param {Number || String}          code key to check.
+   * @param {Number|String}   code key to check.
    * @return {Boolean}        whether the key is down or not.
    *
    * @example
@@ -910,21 +920,17 @@ function keyboard(p5, fn){
     if (typeof input !== 'string') {
       return false;
     }
-    
-    // If it's a single digit, it should be treated as a code (with "Digit" prefix)
     if (input.length === 1 && /[0-9]/.test(input)) {
       return true;
     }
-    
-    // If it's longer than 1 character, it's a code
     return input.length > 1;
   }
+
   fn.keyIsDown = function(input) {
     if (isCode(input)) {
-      const key = input.length === 1 ? `Digit${input}` : input;
-      return this._downKeyCodes[key] || this._downKeys[key];
+      return this._downKeyCodes[input] || this._downKeys[input] || false;
     } else {
-      return this._downKeys[input] || this._downKeyCodes[input];
+      return this._downKeys[input] || this._downKeyCodes[input] || false;
     }
   }
   /**

test/unit/events/keyboard.js

@@ -1,4 +1,5 @@
 import p5 from '../../../src/app.js';
+import { isCode } from '../../../src/events/keyboard.js';
 import { parallelSketches } from '../../js/p5_helpers';
 
 suite('Keyboard Events', function() {
@@ -180,18 +181,62 @@ suite('Keyboard Events', function() {
     });
   });
 
+  suite('isCode', function() {
+    test('returns false for non-string inputs', function() {
+      assert.isFalse(isCode(null));
+      assert.isFalse(isCode(undefined));
+      assert.isFalse(isCode(123));
+      assert.isFalse(isCode({}));
+      assert.isFalse(isCode([]));
+    });
+  
+    test('returns false for single non-digit characters', function() {
+      assert.isFalse(isCode('a'));
+      assert.isFalse(isCode('Z'));
+      assert.isFalse(isCode('!'));
+      assert.isFalse(isCode(' '));
+    });
+  
+    test('returns true for multi-character strings', function() {
+      assert.isTrue(isCode('Enter'));
+      assert.isTrue(isCode('ArrowUp'));
+      assert.isTrue(isCode('Shift'));
+      assert.isTrue(isCode('Control'));
+      assert.isTrue(isCode('ab'));
+    });
+  
+    test('handles edge cases correctly', function() {
+      assert.isFalse(isCode(''));  // empty string
+      assert.isTrue(isCode('11')); // multi-digit number
+      assert.isTrue(isCode('1a')); // digit + letter
+    });
+  });
+
   suite('p5.prototype.keyIsDown', function() {
     test('keyIsDown should return a boolean', function() {
-      assert.isBoolean(myp5.keyIsDown(65));
+      assert.isBoolean(myp5.keyIsDown('a'));
+      assert.isBoolean(myp5.keyIsDown('Enter'));
     });
 
     test('keyIsDown should return true if key is down', function() {
-      window.dispatchEvent(new KeyboardEvent('keydown', { keyCode: 35 }));
-      assert.strictEqual(myp5.keyIsDown(35), true);
-    });
-
-    test.todo('keyIsDown should return false if key is not down', function() {
-      assert.strictEqual(myp5.keyIsDown(35), false);
+      // Test single character keys
+      window.dispatchEvent(new KeyboardEvent('keydown', { key: 'a' }));
+      assert.strictEqual(myp5.keyIsDown('a'), true);
+  
+      // Test digit keys
+      window.dispatchEvent(new KeyboardEvent('keydown', { key: '1', code: 'Digit1' }));
+      assert.strictEqual(myp5.keyIsDown('1'), true);
+  
+      // Test special keys
+      window.dispatchEvent(new KeyboardEvent('keydown', { key: 'Enter', code: 'Enter' }));
+      assert.strictEqual(myp5.keyIsDown('Enter'), true);
+    });
+  
+    test('keyIsDown should return false if key is not down', function() {
+      // Ensure key is not down
+      window.dispatchEvent(new KeyboardEvent('keyup'));
+      assert.strictEqual(myp5.keyIsDown('z'), false);
+      
     });
   });
 });