Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

define version in properties file #84

Merged
merged 3 commits into from
Apr 2, 2025
Merged

define version in properties file #84

merged 3 commits into from
Apr 2, 2025

Conversation

mingness
Copy link
Collaborator

  • move definition of prettyVersion to properties file.
  • move version definition in build file to outside of section designated for users to define
  • move reading in of properties file earlier, so its value of prettyVersion can be used to define version

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 29, 2025 •
edited
Loading

PR Preview Action v1.6.0
Preview removed because the pull request was closed.
2025-04-02 14:14 UTC

@mingness mingness linked an issue Mar 29, 2025 that may be closed by this pull request
version numbers in 1 file #77
Closed
@SableRaf SableRaf self-requested a review March 31, 2025 09:25
@SableRaf
Copy link
Collaborator

Hey @mingness thanks for these updates!

In release.properties, I'd suggest adding a comment to mention the fact that this property may be overwritten by a GitHub release tag.

Something like this:

// Note: The prettyVersion value defined here can be overwritten by a GitHub release tag. 
// If a release tag is present, the numeric part of the tag will be used as the version number.
// See docs/release.md for more details.

@mingness
Copy link
Collaborator Author

@SableRaf thanks, good suggestion - it is now there.

@mingness mingness merged commit 76400b4 into main Apr 2, 2025
1 check passed
@mingness mingness deleted the one-properties-file branch April 2, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SableRaf SableRaf Awaiting requested review from SableRaf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

version numbers in 1 file
2 participants
@mingness @SableRaf