-
-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Seg fault on connection attempt #1963
Comments
Which libstrophe version are you running. |
I have a core dump, and poking around it with GDB I see the following:
I am not sure how to find this info. |
Thanks for the additional info!
|
Could you please
Does the segfault happen with 0.12.2 as well? Which OpenSSL version do you have installed? If you don't want to upload the captures here, please send them in via Mail or get in contact to determine how we could get access. |
Done. Is there an email address I could send this to? I'd rather not have it public.
It no longer segfaults, but logging in does not work. I am sure I am entering the correct password, but I get "login failed".
3.2.1-1 |
Not sure how to do this if I cannot connect. Or am I misunderstanding something? |
Hehe :) That was pretty dumb of me :) You are right of course. You could also mention the domain to us when you send us the email, and we check ourselves. |
You can send it to the e-mail address mentioned on my GH profile. PGP key ID is 7B24BC73AFEEFA69A5BDE9C53FAA94B3BD9016D9
Thanks, so the segfault is caused by the changes of 0.13, I'll have a look at that. The problem seems to be TLS connection related, but I'm not exactly sure yet what happens. |
This was reported as creating a segfault in [0] [0] profanity-im/profanity#1963 Signed-off-by: Steffen Jaeckel <[email protected]>
Could you maybe try out libstrophe from this branch https://github.com/strophe/libstrophe/tree/some-fixes ? This should at least not segfault anymore. Also you should then be able to set the |
This was reported as creating a segfault in [0] [0] profanity-im/profanity#1963 Signed-off-by: Steffen Jaeckel <[email protected]>
This was reported as creating a segfault in [0] [0] profanity-im/profanity#1963 Signed-off-by: Steffen Jaeckel <[email protected]>
Looking at the capture you provided I'm not sure whether we can do anything here.
I'd say you have to get in contact with your server administrator to debug this further. Which software is running on that server? It seems to be only reachable in your private network. I'm curious on how this evolves :) |
Yes, I've been happily using profanity with that server for months (a year?) now.
Yes, I updated openssl about a week ago, but downgrading it doesn't seem to help (and broke a lot of other stuff in my system :D) I'll get in touch with the server admin. |
One wild guess: I've seen stuff failing because openssl became more strict some time ago, you could try to enable the legacy provider [0] and see if it works then.
I didn't ask you to downgrade for exactly that reason :D
👍 [0] https://bbs.archlinux.org/viewtopic.php?pid=2065783#p2065783 |
I made that change to openssl.cnf, and it no longer seg faults. This is back with the fully up to date libstrophe (from the pacman repos, not the proposed fix that was suggested by sjaeckel) and openssl. I still can't log in as I used to, but at least profanity no longer crashes.
Yeah, I acted before thinking. Dumb, but all fixed now :)
I sent a ticket to the IT team yesterday, and will keep you up to date with their replies. Thanks for being so energetic here. It's a dream to have software maintainers be so responsive 👍 |
Cool, so we know that it has to do with your XMPP server only allowing weak ciphers. Can you maybe create another wireshark capture? But this time with libstrophe from the some-fixes branch? The easiest way to do that IMO is building both libstrophe and profanity from source. # adapt this to where you want to have this built
export DEVDIR=/home/user/foo/profanity
export SSLKEYLOGFILE=$DEVDIR/sslkeylogfile
mkdir -p $DEVDIR/prefix
pushd $DEVDIR
git clone https://github.com/strophe/libstrophe.git -b some-fixes
git clone https://github.com/profanity-im/profanity.git
pushd libstrophe
./bootstrap.sh
PKG_CONFIG_PATH=$DEVDIR/prefix/lib/pkgconfig ./configure --prefix=$DEVDIR/prefix
make -j$(nproc)
make install
popd
pushd profanity
./bootstrap.sh
PKG_CONFIG_PATH=$DEVDIR/prefix/lib/pkgconfig ./configure --prefix=$DEVDIR/prefix
make -j$(nproc)
./profanity -l DEBUG Please make sure to either not enter your real password when trying to connect or set up a temporary password, as your server only supports PLAIN authentication and that really means that the password is sent in PLAIN text and will show up in the wireshark capture ;) Then please send over the wireshark capture and the
:) |
Trying this, but I get an error when running bootstrap.sh for profanity. $ ./bootstrap.sh
libtoolize: putting auxiliary files in AC_CONFIG_AUX_DIR, 'build-aux'.
libtoolize: copying file 'build-aux/ltmain.sh'
libtoolize: putting macros in AC_CONFIG_MACRO_DIRS, 'm4'.
libtoolize: copying file 'm4/libtool.m4'
libtoolize: copying file 'm4/ltoptions.m4'
libtoolize: copying file 'm4/ltsugar.m4'
libtoolize: copying file 'm4/ltversion.m4'
libtoolize: copying file 'm4/lt~obsolete.m4'
libtoolize: Consider adding '-I m4' to ACLOCAL_AMFLAGS in Makefile.am.
configure.ac:78: error: possibly undefined macro: AC_MSG_ERROR
If this token and others are legitimate, please use m4_pattern_allow.
See the Autoconf documentation.
autoreconf: error: /usr/bin/autoconf failed with exit status: 1 I'm not familiar with autoconf, and so am not sure how to proceed. Apologies. Can you advise? |
You are missing |
Thanks. I've now sent the requested wireshark capture to @sjaeckel |
Apologies for the silence, but I'm still waiting on our IT people to get back to me :( |
FTR: this conclusion was wrong. After iterating a bit more we realized that there was an error while enabling the legacy provider which made OpenSSL stop working and the connection attempt stopped already earlier because the TLS part couldn't be initialized. After fixing that configuration error the connection still stopped at the same point after the |
@stevemolloy any news? |
Sorry for my long silence. IT claims they have only refreshed the certificate, which isn't particularly helpful. Work has been busy recently, so I will try to get back to you with a wireshark capture of a pidgin connection. |
I have been a happy profanity user for some time now, but in the last week or so I am unable to use it due to a seg fault after providing the password.
Expected Behavior
Current Behavior
This happens no matter if the password is correct or not.
Log file
Some details removed for privacy reasons.
Environment
I'm using Arch linux, and Profanity was installed using pacman.
The text was updated successfully, but these errors were encountered: