Skip to content

Commit 437d9c3

Browse files
committed
serializers: Optimize query performance on SeriesMixin for 'related_series'
Ensure the retrival of series is keept at O(1) complexity. Closes getpatchwork#506 Signed-off-by: andrepapoti <[email protected]>
1 parent 4c0f818 commit 437d9c3

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

patchwork/api/series.py

+5-1
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,11 @@ class SeriesMixin(object):
9595
def get_queryset(self):
9696
return (
9797
Series.objects.all()
98-
.prefetch_related('patches__project', 'cover_letter__project')
98+
.prefetch_related(
99+
'patches__project',
100+
'cover_letter__project',
101+
'related_series__project',
102+
)
99103
.select_related('submitter', 'project')
100104
)
101105

patchwork/tests/api/test_series.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@ def test_list_bug_335(self):
152152
create_cover(series=series_obj)
153153
create_patch(series=series_obj)
154154

155-
with self.assertNumQueries(6):
155+
with self.assertNumQueries(7):
156156
self.client.get(self.api_url())
157157

158158
@utils.store_samples('series-detail')

0 commit comments

Comments
 (0)