Address review comments.

Author: aensidhe

docker-compose.tests.yml

@@ -7,7 +7,6 @@ services:
     command: /app/scripts/test-netcore.sh
     environment:
         TARANTOOL_REPLICATION_SOURCE: "tarantool:3301"
-        TEAMCITY_PROJECT_NAME: 123
     links:
         - tarantool
         - redis

src/progaudi.tarantool/LogicalConnection.cs

@@ -24,8 +24,6 @@ internal class LogicalConnection : ILogicalConnection
 
         private readonly IPhysicalConnection _physicalConnection;
 
-        private readonly ReaderWriterLockSlim _physicalConnectionLock = new ReaderWriterLockSlim();
-
         private readonly IResponseReader _responseReader;
 
         private readonly IResponseWriter _responseWriter;
@@ -147,27 +145,6 @@ await _responseWriter.Write(
                 new ArraySegment<byte>(headerBuffer, 0, Constants.PacketSizeBufferSize + (int) headerLength),
                 new ArraySegment<byte>(bodyBuffer, 0, bodyBuffer.Length));
 
-            //try
-            //{
-            //    _physicalConnectionLock.EnterWriteLock();
-
-            //    _logWriter?.WriteLine($"Begin sending request header buffer, requestId: {requestId}, code: {request.Code}, length: {headerBuffer.Length}");
-            //    _physicalConnection.Write(headerBuffer, 0, Constants.PacketSizeBufferSize + (int)headerLength);
-
-            //    _logWriter?.WriteLine($"Begin sending request body buffer, length: {bodyBuffer.Length}");
-            //    _physicalConnection.Write(bodyBuffer, 0, bodyBuffer.Length);
-            //}
-            //catch
-            //{
-            //    _logWriter?.WriteLine($"Request with requestId {requestId} failed, header:\n{ToReadableString(headerBuffer)} \n body: \n{ToReadableString(bodyBuffer)}");
-            //    Dispose();
-            //    throw;
-            //}
-            //finally
-            //{
-            //    _physicalConnectionLock.ExitWriteLock();
-            //}
-
             try
             {
                 if (timeout.HasValue)

src/progaudi.tarantool/ResponseReader.cs

@@ -61,7 +61,7 @@ public void Dispose()
 
                 foreach (var response in _pendingRequests.Values)
                 {
-                    response.SetException(new InvalidOperationException("Can't read from physical connection."));
+                    response.SetException(new ObjectDisposedException(nameof(ResponseReader)));
                 }
 
                 _pendingRequests.Clear();

src/progaudi.tarantool/ResponseWriter.cs

@@ -105,6 +105,17 @@ void WriteBuffer(ArraySegment<byte> buffer)
                 _physicalConnection.Write(buffer.Array, buffer.Offset, buffer.Count);
             }
 
+            Tuple<ArraySegment<byte>, ArraySegment<byte>> GetRequest()
+            {
+                lock (_lock)
+                {
+                    if (_buffer.Count > 0)
+                        return _buffer.Dequeue();
+                }
+
+                return null;
+            }
+
             Tuple<ArraySegment<byte>, ArraySegment<byte>> request;
             var count = 0;
             while ((request = GetRequest()) != null)
@@ -131,16 +142,5 @@ void WriteBuffer(ArraySegment<byte> buffer)
 
             _physicalConnection.Flush();
         }
-
-        private Tuple<ArraySegment<byte>, ArraySegment<byte>> GetRequest()
-        {
-            lock (_lock)
-            {
-                if (_buffer.Count > 0)
-                    return _buffer.Dequeue();
-            }
-
-            return null;
-        }
     }
 }