Merge pull request #115 from progaudi/fix/naming-and-code-style

Fix naming and code style.

Author: aensidhe

src/progaudi.tarantool/IResponseWriter.cs renamed to src/progaudi.tarantool/IRequestWriter.cs

@@ -3,7 +3,7 @@
 
 namespace ProGaudi.Tarantool.Client
 {
-    internal interface IResponseWriter : IDisposable
+    internal interface IRequestWriter : IDisposable
     {
         void BeginWriting();
 

src/progaudi.tarantool/LogicalConnection.cs

@@ -26,7 +26,7 @@ internal class LogicalConnection : ILogicalConnection
 
         private readonly IResponseReader _responseReader;
 
-        private readonly IResponseWriter _responseWriter;
+        private readonly IRequestWriter _requestWriter;
 
         private readonly ILog _logWriter;
 
@@ -41,7 +41,7 @@ public LogicalConnection(ClientOptions options, RequestIdCounter requestIdCounte
 
             _physicalConnection = new NetworkStreamPhysicalConnection();
             _responseReader = new ResponseReader(_clientOptions, _physicalConnection);
-            _responseWriter = new ResponseWriter(_clientOptions, _physicalConnection);
+            _requestWriter = new RequestWriter(_clientOptions, _physicalConnection);
         }
 
         public uint PingsFailedByTimeoutCount
@@ -60,7 +60,7 @@ public void Dispose()
             _disposed = true;
 
             _responseReader.Dispose();
-            _responseWriter.Dispose();
+            _requestWriter.Dispose();
             _physicalConnection.Dispose();
         }
 
@@ -82,7 +82,7 @@ public async Task Connect()
             PingsFailedByTimeoutCount = 0;
 
             _responseReader.BeginReading();
-            _responseWriter.BeginWriting();
+            _requestWriter.BeginWriting();
 
             _clientOptions.LogWriter?.WriteLine("Server responses reading started.");
 
@@ -96,7 +96,7 @@ public bool IsConnected()
                 return false;
             }
 
-            return _responseReader.IsConnected && _responseWriter.IsConnected && _physicalConnection.IsConnected;
+            return _responseReader.IsConnected && _requestWriter.IsConnected && _physicalConnection.IsConnected;
         }
 
         private async Task LoginIfNotGuest(GreetingsResponse greetings)
@@ -141,7 +141,7 @@ private async Task<TResponse> SendRequestImpl<TRequest, TResponse>(TRequest requ
             var responseTask = _responseReader.GetResponseTask(requestId);
 
             var headerBuffer = CreateAndSerializeBuffer(request, requestId, bodyBuffer, out var headerLength);
-            await _responseWriter.Write(
+            await _requestWriter.Write(
                 new ArraySegment<byte>(headerBuffer, 0, Constants.PacketSizeBufferSize + (int) headerLength),
                 new ArraySegment<byte>(bodyBuffer, 0, bodyBuffer.Length));
 

src/progaudi.tarantool/LogicalConnectionManager.cs

@@ -31,7 +31,7 @@ public class LogicalConnectionManager : ILogicalConnection
 
         private readonly int _pingCheckInterval = 1000;
 
-        private readonly TimeSpan? _pingTimeout = null;
+        private readonly TimeSpan? _pingTimeout;
 
         private DateTimeOffset _nextPingTime = DateTimeOffset.MinValue;
 
@@ -44,16 +44,10 @@ public LogicalConnectionManager(ClientOptions options)
                 _pingCheckInterval = _clientOptions.ConnectionOptions.PingCheckInterval;
             }
 
-            this._pingTimeout = this._clientOptions.ConnectionOptions.PingCheckTimeout;
+            _pingTimeout = _clientOptions.ConnectionOptions.PingCheckTimeout;
         }
 
-        public uint PingsFailedByTimeoutCount
-        {
-            get
-            {
-                return _droppableLogicalConnection?.PingsFailedByTimeoutCount ?? 0;
-            }
-        }
+        public uint PingsFailedByTimeoutCount => _droppableLogicalConnection?.PingsFailedByTimeoutCount ?? 0;
 
         public void Dispose()
         {
@@ -135,15 +129,7 @@ private void CheckPing()
             }
         }
 
-        public bool IsConnected()
-        {
-            if (!_connected.WaitOne(_connectionTimeout))
-            {
-                return false;
-            }
-
-            return IsConnectedInternal();
-        }
+        public bool IsConnected() => _connected.WaitOne(_connectionTimeout) && IsConnectedInternal();
 
         private bool IsConnectedInternal()
         {

src/progaudi.tarantool/ResponseWriter.cs renamed to src/progaudi.tarantool/RequestWriter.cs

@@ -6,7 +6,7 @@
 
 namespace ProGaudi.Tarantool.Client
 {
-    internal class ResponseWriter : IResponseWriter
+    internal class RequestWriter : IRequestWriter
     {
         private readonly ClientOptions _clientOptions;
         private readonly IPhysicalConnection _physicalConnection;
@@ -17,7 +17,7 @@ internal class ResponseWriter : IResponseWriter
         private readonly ManualResetEventSlim _newRequestsAvailable;
         private bool _disposed;
 
-        public ResponseWriter(ClientOptions clientOptions, IPhysicalConnection physicalConnection)
+        public RequestWriter(ClientOptions clientOptions, IPhysicalConnection physicalConnection)
         {
             _clientOptions = clientOptions;
             _physicalConnection = physicalConnection;