Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send server name as PONG parameter #33

Open
progval opened this issue Oct 1, 2022 · 1 comment · Fixed by #34
Open

Send server name as PONG parameter #33

progval opened this issue Oct 1, 2022 · 1 comment · Fixed by #34
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@progval
Copy link
Owner

progval commented Oct 1, 2022

The spec says:

Servers MUST send a parameter, and clients SHOULD ignore it. It exists for historical reasons, and indicates the name of the server sending the PONG. Clients MUST NOT send a parameter.

But Matrix2051 does not actually do it, and only sends the cookie/token.
@progval progval added bug Something isn't working good first issue Good for newcomers labels Oct 1, 2022
jlu5 added a commit to jlu5/matrix2051 that referenced this issue Oct 1, 2022
@jlu5 @progval
Send PONG with prefixes
b5a61c6 
Closes progvalGH-33.

Co-authored-by: Val Lorentz <[email protected]>
@jlu5 jlu5 mentioned this issue Oct 1, 2022
Merged
progval added a commit that referenced this issue Oct 1, 2022
@jlu5 @progval
Send PONG with prefixes
008e18f 
Closes GH-33.

Co-authored-by: Val Lorentz <[email protected]>
@progval progval reopened this Oct 1, 2022
@progval
Copy link
Owner Author

progval commented Oct 1, 2022 •
edited
Loading

@jlu5 this issue is about the parameter, not the source

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Send PONG with prefixes jlu5/matrix2051
1 participant
@progval