From 743fdc6156268290d4360323441e64d8373074e0 Mon Sep 17 00:00:00 2001 From: Shreyas Bhandare Date: Wed, 19 Feb 2025 04:58:55 +0000 Subject: [PATCH] Fix conformace for waterfreezedetector device --- ...node_waterfreezedetector_dd94a13a16.matter | 17 ++-- ...ootnode_waterfreezedetector_dd94a13a16.zap | 90 ++++++------------- 2 files changed, 32 insertions(+), 75 deletions(-) diff --git a/examples/chef/devices/rootnode_waterfreezedetector_dd94a13a16.matter b/examples/chef/devices/rootnode_waterfreezedetector_dd94a13a16.matter index e5f06a8db23e92..843e1e1a0a20f5 100644 --- a/examples/chef/devices/rootnode_waterfreezedetector_dd94a13a16.matter +++ b/examples/chef/devices/rootnode_waterfreezedetector_dd94a13a16.matter @@ -1662,7 +1662,7 @@ cluster BooleanStateConfiguration = 128 { } endpoint 0 { - device type ma_rootdevice = 22, version 1; + device type ma_rootdevice = 22, version 3; server cluster Descriptor { @@ -1678,7 +1678,6 @@ endpoint 0 { emits event AccessControlEntryChanged; emits event AccessControlExtensionChanged; callback attribute acl; - callback attribute extension; callback attribute subjectsPerAccessControlEntry; callback attribute targetsPerAccessControlEntry; callback attribute accessControlEntriesPerFabric; @@ -1713,7 +1712,7 @@ endpoint 0 { callback attribute specificationVersion; callback attribute maxPathsPerInvoke; ram attribute featureMap default = 0; - ram attribute clusterRevision default = 2; + ram attribute clusterRevision default = 4; } server cluster GeneralCommissioning { @@ -1723,7 +1722,7 @@ endpoint 0 { callback attribute locationCapability; callback attribute supportsConcurrentConnection; ram attribute featureMap default = 0; - ram attribute clusterRevision default = 0x0001; + ram attribute clusterRevision default = 0x0002; handle command ArmFailSafe; handle command ArmFailSafeResponse; @@ -1736,8 +1735,6 @@ endpoint 0 { server cluster NetworkCommissioning { ram attribute maxNetworks; callback attribute networks; - ram attribute scanMaxTimeSeconds; - ram attribute connectMaxTimeSeconds; ram attribute interfaceEnabled; ram attribute lastNetworkingStatus; ram attribute lastNetworkID; @@ -1791,7 +1788,6 @@ endpoint 0 { ram attribute clusterRevision default = 0x0001; handle command OpenCommissioningWindow; - handle command OpenBasicCommissioningWindow; handle command RevokeCommissioning; } @@ -1847,7 +1843,7 @@ endpoint 1 { callback attribute acceptedCommandList; callback attribute attributeList; ram attribute featureMap default = 0; - ram attribute clusterRevision default = 2; + ram attribute clusterRevision default = 5; handle command Identify; handle command TriggerEffect; @@ -1859,7 +1855,7 @@ endpoint 1 { callback attribute acceptedCommandList; callback attribute attributeList; ram attribute featureMap default = 0; - ram attribute clusterRevision default = 3; + ram attribute clusterRevision default = 4; handle command AddGroup; handle command AddGroupResponse; @@ -1893,6 +1889,7 @@ endpoint 1 { ram attribute batPercentRemaining default = 95; ram attribute batTimeRemaining default = 518400; ram attribute batChargeLevel default = 0; + ram attribute batReplacementNeeded; ram attribute batReplaceability default = 1; ram attribute batPresent default = 1; ram attribute batCapacity default = 350; @@ -1903,7 +1900,7 @@ endpoint 1 { callback attribute acceptedCommandList; callback attribute attributeList; ram attribute featureMap default = 0x06; - ram attribute clusterRevision default = 1; + ram attribute clusterRevision default = 3; } server cluster BooleanState { diff --git a/examples/chef/devices/rootnode_waterfreezedetector_dd94a13a16.zap b/examples/chef/devices/rootnode_waterfreezedetector_dd94a13a16.zap index d475169d543231..ee9ddcaed4d69b 100644 --- a/examples/chef/devices/rootnode_waterfreezedetector_dd94a13a16.zap +++ b/examples/chef/devices/rootnode_waterfreezedetector_dd94a13a16.zap @@ -54,7 +54,7 @@ } ], "deviceVersions": [ - 1 + 3 ], "deviceIdentifiers": [ 22 @@ -193,22 +193,6 @@ "maxInterval": 65534, "reportableChange": 0 }, - { - "name": "Extension", - "code": 1, - "mfgCode": null, - "side": "server", - "type": "array", - "included": 1, - "storageOption": "External", - "singleton": 0, - "bounded": 0, - "defaultValue": null, - "reportable": 1, - "minInterval": 1, - "maxInterval": 65534, - "reportableChange": 0 - }, { "name": "SubjectsPerAccessControlEntry", "code": 2, @@ -693,7 +677,7 @@ "storageOption": "RAM", "singleton": 1, "bounded": 0, - "defaultValue": "2", + "defaultValue": "4", "reportable": 1, "minInterval": 0, "maxInterval": 65344, @@ -888,7 +872,7 @@ "storageOption": "RAM", "singleton": 0, "bounded": 0, - "defaultValue": "0x0001", + "defaultValue": "0x0002", "reportable": 1, "minInterval": 0, "maxInterval": 65344, @@ -1010,38 +994,6 @@ "maxInterval": 65534, "reportableChange": 0 }, - { - "name": "ScanMaxTimeSeconds", - "code": 2, - "mfgCode": null, - "side": "server", - "type": "int8u", - "included": 1, - "storageOption": "RAM", - "singleton": 0, - "bounded": 0, - "defaultValue": "", - "reportable": 1, - "minInterval": 1, - "maxInterval": 65534, - "reportableChange": 0 - }, - { - "name": "ConnectMaxTimeSeconds", - "code": 3, - "mfgCode": null, - "side": "server", - "type": "int8u", - "included": 1, - "storageOption": "RAM", - "singleton": 0, - "bounded": 0, - "defaultValue": "", - "reportable": 1, - "minInterval": 1, - "maxInterval": 65534, - "reportableChange": 0 - }, { "name": "InterfaceEnabled", "code": 4, @@ -1437,14 +1389,6 @@ "isIncoming": 1, "isEnabled": 1 }, - { - "name": "OpenBasicCommissioningWindow", - "code": 1, - "mfgCode": null, - "source": "client", - "isIncoming": 1, - "isEnabled": 1 - }, { "name": "RevokeCommissioning", "code": 2, @@ -2101,7 +2045,7 @@ "storageOption": "RAM", "singleton": 0, "bounded": 0, - "defaultValue": "2", + "defaultValue": "5", "reportable": 1, "minInterval": 1, "maxInterval": 65534, @@ -2289,7 +2233,7 @@ "storageOption": "RAM", "singleton": 0, "bounded": 0, - "defaultValue": "3", + "defaultValue": "4", "reportable": 1, "minInterval": 1, "maxInterval": 65534, @@ -2332,7 +2276,7 @@ "singleton": 0, "bounded": 0, "defaultValue": null, - "reportable": 0, + "reportable": 1, "minInterval": 1, "maxInterval": 65534, "reportableChange": 0 @@ -2348,7 +2292,7 @@ "singleton": 0, "bounded": 0, "defaultValue": null, - "reportable": 0, + "reportable": 1, "minInterval": 1, "maxInterval": 65534, "reportableChange": 0 @@ -2364,7 +2308,7 @@ "singleton": 0, "bounded": 0, "defaultValue": null, - "reportable": 0, + "reportable": 1, "minInterval": 1, "maxInterval": 65534, "reportableChange": 0 @@ -2571,6 +2515,22 @@ "maxInterval": 65534, "reportableChange": 0 }, + { + "name": "BatReplacementNeeded", + "code": 15, + "mfgCode": null, + "side": "server", + "type": "boolean", + "included": 1, + "storageOption": "RAM", + "singleton": 0, + "bounded": 0, + "defaultValue": "", + "reportable": 1, + "minInterval": 1, + "maxInterval": 65534, + "reportableChange": 0 + }, { "name": "BatReplaceability", "code": 16, @@ -2741,7 +2701,7 @@ "storageOption": "RAM", "singleton": 0, "bounded": 0, - "defaultValue": "1", + "defaultValue": "3", "reportable": 1, "minInterval": 1, "maxInterval": 65534,