Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the write_to_app_pipe that exists in python_tests in a common location #32139

Open
hicklin opened this issue Feb 15, 2024 · 1 comment · May be fixed by #37637
Open

Move the write_to_app_pipe that exists in python_tests in a common location #32139

hicklin opened this issue Feb 15, 2024 · 1 comment · May be fixed by #37637
Assignees
@jtrejoespinoza-grid
Labels
good first issue Good for newcomers

Comments

@hicklin
Copy link
Contributor

hicklin commented Feb 15, 2024

The write_to_app_pipe function is replicated in a number of python tests. This should be moved into a common location, possibly made part of the MatterBaseTest class.

Consider requiring apps to provide an acknowledgement back when the command has been processes. This will allow for the removal of the current sleep(0.001) call that resolves the test flakiness.
@hicklin hicklin mentioned this issue Feb 15, 2024
Merged
@hicklin hicklin added the CI/CD improvements Improvements to our CI/CD pipelines label Feb 15, 2024
@cecille cecille added the good first issue Good for newcomers label Apr 15, 2024
@cecille cecille removed the CI/CD improvements Improvements to our CI/CD pipelines label Feb 11, 2025
@cecille cecille removed this from Test and Infra Feb 11, 2025
@jtrejoespinoza-grid jtrejoespinoza-grid self-assigned this Feb 14, 2025
@jtrejoespinoza-grid
Copy link

PR #37637

@andy31415 andy31415 linked a pull request Feb 18, 2025 that will close this issue
Open
@jtrejoespinoza-grid jtrejoespinoza-grid moved this from In progress to In review in Google certification and testing project Feb 20, 2025
@jtrejoespinoza-grid jtrejoespinoza-grid moved this from In review to Needs Google review in Google certification and testing project Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jtrejoespinoza-grid jtrejoespinoza-grid

Labels
good first issue Good for newcomers
Projects
Good First Issues
Status: No status
Google certification and testing project
Status: Needs Google review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Python framework - write_to_app_pipe updates. jtrejoespinoza-grid/connectedhomeip
3 participants
@hicklin @cecille @jtrejoespinoza-grid