From 9d8b6a485d3fb683c60f3afc09bbf7e9fe718e85 Mon Sep 17 00:00:00 2001 From: Ramiro Recchia Date: Wed, 29 Jan 2025 14:06:24 +0000 Subject: [PATCH 1/5] CC.S.F00 updated to 1 to not skip test steps in TC-CC-3.3.yaml --- src/app/tests/suites/certification/ci-pics-values | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/app/tests/suites/certification/ci-pics-values b/src/app/tests/suites/certification/ci-pics-values index 1f4f1f66e906c3..481da7d2307875 100644 --- a/src/app/tests/suites/certification/ci-pics-values +++ b/src/app/tests/suites/certification/ci-pics-values @@ -204,7 +204,7 @@ CC.S.C41.Rsp=1 CC.S.C42.Rsp=1 CC.S.C43.Rsp=1 CC.S.C44.Rsp=1 -CC.S.F00=0 +CC.S.F00=1 CC.S.F01=1 CC.S.F02=1 CC.S.F03=1 From 28b06af55603d2a97598423430f7b336e0c26021 Mon Sep 17 00:00:00 2001 From: Ramiro Recchia Date: Wed, 29 Jan 2025 14:57:35 +0000 Subject: [PATCH 2/5] Remove manual steps, change delays and step size so tolerance does not span wrap --- .../suites/certification/Test_TC_CC_3_3.yaml | 99 +++++++------------ 1 file changed, 38 insertions(+), 61 deletions(-) diff --git a/src/app/tests/suites/certification/Test_TC_CC_3_3.yaml b/src/app/tests/suites/certification/Test_TC_CC_3_3.yaml index 91cdcbffe7d255..819db33ccc9d72 100644 --- a/src/app/tests/suites/certification/Test_TC_CC_3_3.yaml +++ b/src/app/tests/suites/certification/Test_TC_CC_3_3.yaml @@ -80,7 +80,7 @@ tests: - name: "StepMode" value: 1 - name: "StepSize" - value: 60 + value: 80 - name: "TransitionTime" value: 200 - name: "OptionsMask" @@ -88,56 +88,43 @@ tests: - name: "OptionsOverride" value: 0 - - label: "Wait 10s" + - label: "Wait 5s" PICS: CC.S.F00 cluster: "DelayCommands" command: "WaitForMs" arguments: values: - name: "ms" - value: 10000 + value: 5000 - - label: "Step 2c: TH reads CurrentHue attribute from DUT" + - label: "Step 2c: TH reads CurrentHue attribute from DUT" # Expects 220+/-15% PICS: CC.S.F00 && CC.S.A0000 command: "readAttribute" attribute: "CurrentHue" response: constraints: - minValue: 195 - maxValue: 254 + minValue: 187 + maxValue: 253 - - label: "Wait 10s" + - label: "Wait 15s" PICS: CC.S.F00 cluster: "DelayCommands" command: "WaitForMs" arguments: values: - name: "ms" - value: 10000 + value: 15000 - #Tolerance to be computed from the range - #Start value 230, expected value 5, 230 - 5 = 225, 225 % 15 = 34 , So 5+/-34 We need two range here as 254 is the max value - #Range will be: 230...254...0...39 - #Multiple range not supported in YAML: https://github.com/project-chip/connectedhomeip/issues/23197 + # Start value 220, expected value 24+/-15% (280 mod 256) + # Multiple range not supported in YAML: https://github.com/project-chip/connectedhomeip/issues/23197 - label: "Step 2d: TH reads CurrentHue attribute from DUT" - PICS: CC.S.F00 && CC.S.A0000 && PICS_SKIP_SAMPLE_APP - verification: | - ./chip-tool colorcontrol read current-hue 1 1 - - After another 10 seconds , Verify that CurrentHue value is 5 On TH(chip-tool) Logs and below is the sample log provided for the raspi platform - - [1649662328.012887][8447:8452] CHIP:TOO: Endpoint: 1 Cluster: 0x0000_0300 Attribute 0x0000_0000 DataVersion: 4087279986 - [1649662328.012957][8447:8452] CHIP:TOO: Current hue: 5 - [1649662328.013055][8447:8452] CHIP:EM: Sending Standalone Ack for MessageCounter:8634142 on exchange 13871i - (Value can vary) - cluster: "LogCommands" - command: "UserPrompt" - arguments: - values: - - name: "message" - value: "Enter 'y' after success" - - name: "expectedValue" - value: "y" + PICS: CC.S.F00 && CC.S.A0000 + command: "readAttribute" + attribute: "CurrentHue" + response: + constraints: + minValue: 20 + maxValue: 28 - label: "Wait 5s" PICS: CC.S.F00 @@ -148,25 +135,15 @@ tests: - name: "ms" value: 5000 - #Multiple range not supported in YAML: https://github.com/project-chip/connectedhomeip/issues/23197 + # Multiple range not supported in YAML: https://github.com/project-chip/connectedhomeip/issues/23197 - label: "Step 2e: TH reads CurrentHue attribute from DUT" - PICS: CC.S.F00 && CC.S.A0000 && PICS_SKIP_SAMPLE_APP - verification: | - ./chip-tool colorcontrol read current-hue 1 1 - - After another 5 seconds , Verify that CurrentHue value is 5 On TH(chip-tool) Logs and below is the sample log provided for the raspi platform - - [1649662328.012887][8447:8452] CHIP:TOO: Endpoint: 1 Cluster: 0x0000_0300 Attribute 0x0000_0000 DataVersion: 4087279986 - [1649662328.012957][8447:8452] CHIP:TOO: Current hue: 5 - [1649662328.013055][8447:8452] CHIP:EM: Sending Standalone Ack for MessageCounter:8634142 on exchange 13871i - cluster: "LogCommands" - command: "UserPrompt" - arguments: - values: - - name: "message" - value: "Enter 'y' after success" - - name: "expectedValue" - value: "y" + PICS: CC.S.F00 && CC.S.A0000 + command: "readAttribute" + attribute: "CurrentHue" + response: + constraints: + minValue: 20 + maxValue: 28 - label: "Step 3a: TH sends MoveToHue command to DUT with Hue=50, @@ -205,7 +182,7 @@ tests: - name: "StepMode" value: 3 - name: "StepSize" - value: 60 + value: 100 - name: "TransitionTime" value: 200 - name: "OptionsMask" @@ -213,41 +190,41 @@ tests: - name: "OptionsOverride" value: 0 - - label: "Wait 10s" + - label: "Wait 5s" PICS: CC.S.F00 cluster: "DelayCommands" command: "WaitForMs" arguments: values: - name: "ms" - value: 10000 + value: 5000 - - label: "Step 3c: TH reads CurrentHue attribute from DUT" + - label: "Step 3c: TH reads CurrentHue attribute from DUT" # Expects 25+/-15% PICS: CC.S.F00 && CC.S.A0000 command: "readAttribute" attribute: "CurrentHue" response: constraints: - minValue: 17 - maxValue: 23 + minValue: 21 + maxValue: 29 - - label: "Wait 10s" + - label: "Wait 15s" PICS: CC.S.F00 cluster: "DelayCommands" command: "WaitForMs" arguments: values: - name: "ms" - value: 10000 + value: 15000 - - label: "Step 3d: TH reads CurrentHue attribute from DUT" + - label: "Step 3d: TH reads CurrentHue attribute from DUT" # Expects 206+/-15% PICS: CC.S.F00 && CC.S.A0000 command: "readAttribute" attribute: "CurrentHue" response: constraints: - minValue: 208 - maxValue: 255 + minValue: 175 + maxValue: 237 - label: "Wait 5s" PICS: CC.S.F00 @@ -264,8 +241,8 @@ tests: attribute: "CurrentHue" response: constraints: - minValue: 208 - maxValue: 255 + minValue: 175 + maxValue: 237 - label: "Step 4a: TH reads ColorMode attribute from DUT" PICS: CC.S.F00 && CC.S.A0008 From 962fd936264d4f33207bf1770c1384481fec2854 Mon Sep 17 00:00:00 2001 From: Ramiro Recchia Date: Wed, 29 Jan 2025 18:46:02 +0000 Subject: [PATCH 3/5] Fixing identation issues --- .../tests/suites/certification/Test_TC_CC_3_3.yaml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/app/tests/suites/certification/Test_TC_CC_3_3.yaml b/src/app/tests/suites/certification/Test_TC_CC_3_3.yaml index 819db33ccc9d72..18c321b70942e5 100644 --- a/src/app/tests/suites/certification/Test_TC_CC_3_3.yaml +++ b/src/app/tests/suites/certification/Test_TC_CC_3_3.yaml @@ -122,9 +122,9 @@ tests: command: "readAttribute" attribute: "CurrentHue" response: - constraints: - minValue: 20 - maxValue: 28 + constraints: + minValue: 20 + maxValue: 28 - label: "Wait 5s" PICS: CC.S.F00 @@ -141,9 +141,9 @@ tests: command: "readAttribute" attribute: "CurrentHue" response: - constraints: - minValue: 20 - maxValue: 28 + constraints: + minValue: 20 + maxValue: 28 - label: "Step 3a: TH sends MoveToHue command to DUT with Hue=50, From 6e2b61e60e76985cbc8e8de3bce97e14d78ea790 Mon Sep 17 00:00:00 2001 From: Ramiro Recchia Date: Tue, 11 Feb 2025 20:09:32 +0000 Subject: [PATCH 4/5] Fix toleFix tolerance calculation} --- .../suites/certification/Test_TC_CC_3_3.yaml | 28 +++++++++---------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/src/app/tests/suites/certification/Test_TC_CC_3_3.yaml b/src/app/tests/suites/certification/Test_TC_CC_3_3.yaml index 18c321b70942e5..7f75b3a5ae2f24 100644 --- a/src/app/tests/suites/certification/Test_TC_CC_3_3.yaml +++ b/src/app/tests/suites/certification/Test_TC_CC_3_3.yaml @@ -97,14 +97,14 @@ tests: - name: "ms" value: 5000 - - label: "Step 2c: TH reads CurrentHue attribute from DUT" # Expects 220+/-15% + - label: "Step 2c: TH reads CurrentHue attribute from DUT" # Expects 220 +/- 3 (15% of (220 - 200)) PICS: CC.S.F00 && CC.S.A0000 command: "readAttribute" attribute: "CurrentHue" response: constraints: - minValue: 187 - maxValue: 253 + minValue: 217 + maxValue: 223 - label: "Wait 15s" PICS: CC.S.F00 @@ -115,7 +115,7 @@ tests: - name: "ms" value: 15000 - # Start value 220, expected value 24+/-15% (280 mod 256) + # Start value 220, expected value 25 +/- 12 (280 mod 255 +/- 15% of 80) # Multiple range not supported in YAML: https://github.com/project-chip/connectedhomeip/issues/23197 - label: "Step 2d: TH reads CurrentHue attribute from DUT" PICS: CC.S.F00 && CC.S.A0000 @@ -123,8 +123,8 @@ tests: attribute: "CurrentHue" response: constraints: - minValue: 20 - maxValue: 28 + minValue: 13 + maxValue: 37 - label: "Wait 5s" PICS: CC.S.F00 @@ -142,8 +142,8 @@ tests: attribute: "CurrentHue" response: constraints: - minValue: 20 - maxValue: 28 + minValue: 13 + maxValue: 37 - label: "Step 3a: TH sends MoveToHue command to DUT with Hue=50, @@ -199,7 +199,7 @@ tests: - name: "ms" value: 5000 - - label: "Step 3c: TH reads CurrentHue attribute from DUT" # Expects 25+/-15% + - label: "Step 3c: TH reads CurrentHue attribute from DUT" # Expects 25 +/- 4 (15% of (50 - 25)) PICS: CC.S.F00 && CC.S.A0000 command: "readAttribute" attribute: "CurrentHue" @@ -217,14 +217,14 @@ tests: - name: "ms" value: 15000 - - label: "Step 3d: TH reads CurrentHue attribute from DUT" # Expects 206+/-15% + - label: "Step 3d: TH reads CurrentHue attribute from DUT" # Expects 205 +/- 15 (-50 mod 255 +/- 15% of 100) PICS: CC.S.F00 && CC.S.A0000 command: "readAttribute" attribute: "CurrentHue" response: constraints: - minValue: 175 - maxValue: 237 + minValue: 190 + maxValue: 220 - label: "Wait 5s" PICS: CC.S.F00 @@ -241,8 +241,8 @@ tests: attribute: "CurrentHue" response: constraints: - minValue: 175 - maxValue: 237 + minValue: 190 + maxValue: 220 - label: "Step 4a: TH reads ColorMode attribute from DUT" PICS: CC.S.F00 && CC.S.A0008 From c682cff2cf696e09a75c7dfb0063fbcd0af947a2 Mon Sep 17 00:00:00 2001 From: Ramiro Recchia Date: Thu, 13 Feb 2025 11:21:58 -0300 Subject: [PATCH 5/5] Updated comments --- src/app/tests/suites/certification/Test_TC_CC_3_3.yaml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/app/tests/suites/certification/Test_TC_CC_3_3.yaml b/src/app/tests/suites/certification/Test_TC_CC_3_3.yaml index 7f75b3a5ae2f24..7a2d4bd7939851 100644 --- a/src/app/tests/suites/certification/Test_TC_CC_3_3.yaml +++ b/src/app/tests/suites/certification/Test_TC_CC_3_3.yaml @@ -97,7 +97,7 @@ tests: - name: "ms" value: 5000 - - label: "Step 2c: TH reads CurrentHue attribute from DUT" # Expects 220 +/- 3 (15% of (220 - 200)) + - label: "Step 2c: TH reads CurrentHue attribute from DUT" # Expects 220 (200 + 80*(5/20)) with a tolerance of +/- 3 (15% of 20), so the expected value is in the range (217, 221) PICS: CC.S.F00 && CC.S.A0000 command: "readAttribute" attribute: "CurrentHue" @@ -115,7 +115,7 @@ tests: - name: "ms" value: 15000 - # Start value 220, expected value 25 +/- 12 (280 mod 255 +/- 15% of 80) + # Start value 220, expected value 25 (200 + 80*(20/20) = 280 mod 255) with a tolerance of +/- 12 (15% of 80), so the expected value is in the range (13, 37) # Multiple range not supported in YAML: https://github.com/project-chip/connectedhomeip/issues/23197 - label: "Step 2d: TH reads CurrentHue attribute from DUT" PICS: CC.S.F00 && CC.S.A0000 @@ -199,7 +199,7 @@ tests: - name: "ms" value: 5000 - - label: "Step 3c: TH reads CurrentHue attribute from DUT" # Expects 25 +/- 4 (15% of (50 - 25)) + - label: "Step 3c: TH reads CurrentHue attribute from DUT" # Expects 25 (50 - 100*(5/20)) with a tolerance of +/- 4 (15% of 25), so the expected value is in the range (21, 29) PICS: CC.S.F00 && CC.S.A0000 command: "readAttribute" attribute: "CurrentHue" @@ -217,7 +217,7 @@ tests: - name: "ms" value: 15000 - - label: "Step 3d: TH reads CurrentHue attribute from DUT" # Expects 205 +/- 15 (-50 mod 255 +/- 15% of 100) + - label: "Step 3d: TH reads CurrentHue attribute from DUT" # Expects 205 (50 - 100*(20/20) = -50 mod 255) with a tolerance of +/- 15 (15% of 100), so the expected value is in the range (190, 220) PICS: CC.S.F00 && CC.S.A0000 command: "readAttribute" attribute: "CurrentHue"