Skip to content

Commit d2e06b2

Browse files
authored
Upgrade Noble (#1242)
* Comment out "reset" for now because crashing * fix ble "supports" usage We can connect to any address so do not check that * upgrade noble * package lock * try adding npm i after ci * Revert "try adding npm i after ci" This reverts commit 167d279. * fix noble and use 1.15.0
1 parent 0f23660 commit d2e06b2

File tree

2 files changed

+4
-13
lines changed

2 files changed

+4
-13
lines changed

packages/nodejs-ble/src/NobleBleChannel.ts

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ import {
1111
Logger,
1212
NetInterface,
1313
ServerAddress,
14-
ServerAddressBle,
1514
Time,
1615
TransportInterface,
1716
createPromise,
@@ -214,19 +213,11 @@ export class NobleBleCentralInterface implements NetInterface {
214213
}
215214
}
216215

217-
supports(type: ChannelType, address?: string) {
216+
supports(type: ChannelType, _address?: string) {
218217
if (type !== ChannelType.BLE) {
219218
return false;
220219
}
221-
if (address === undefined) {
222-
return false;
223-
}
224-
for (const key of this.openChannels.keys()) {
225-
if ((key as ServerAddressBle).peripheralAddress === address) {
226-
return true;
227-
}
228-
}
229-
return false;
220+
return true;
230221
}
231222
}
232223

packages/nodejs-ble/src/NobleBleClient.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,15 +38,15 @@ export class NobleBleClient {
3838

3939
constructor(options?: BleOptions) {
4040
loadNoble(options?.hciId);
41-
try {
41+
/*try {
4242
noble.reset();
4343
} catch (error: any) {
4444
logger.debug(
4545
`Error resetting BLE device via noble (can be ignored, we just tried): ${
4646
(error as unknown as Error).message
4747
}`,
4848
);
49-
}
49+
}*/
5050
noble.on("stateChange", state => {
5151
this.nobleState = state;
5252
logger.debug(`Noble state changed to ${state}`);

0 commit comments

Comments
 (0)