Skip to content

Commit 3e139fd

Browse files
authored
unique names for each controller (#72)
1 parent 981eafc commit 3e139fd

File tree

3 files changed

+9
-1
lines changed

3 files changed

+9
-1
lines changed

internal/controller/appwrapper/appwrapper_controller.go

+1
Original file line numberDiff line numberDiff line change
@@ -522,5 +522,6 @@ func (r *AppWrapperReconciler) SetupWithManager(mgr ctrl.Manager) error {
522522
return ctrl.NewControllerManagedBy(mgr).
523523
For(&workloadv1beta2.AppWrapper{}).
524524
Watches(&v1.Pod{}, handler.EnqueueRequestsFromMapFunc(r.podMapFunc)).
525+
Named("AppWrapper").
525526
Complete(r)
526527
}

internal/controller/workload/child_admission_controller.go

+1
Original file line numberDiff line numberDiff line change
@@ -113,5 +113,6 @@ func (r *ChildWorkloadReconciler) Reconcile(ctx context.Context, req ctrl.Reques
113113
func (r *ChildWorkloadReconciler) SetupWithManager(mgr ctrl.Manager) error {
114114
return ctrl.NewControllerManagedBy(mgr).
115115
For(&workloadv1beta2.AppWrapper{}).
116+
Named("AppWrapperChildWorkload").
116117
Complete(r)
117118
}

internal/controller/workload/workload_controller.go

+7-1
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ import (
2424
"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
2525
"k8s.io/apimachinery/pkg/runtime/schema"
2626

27+
"sigs.k8s.io/controller-runtime/pkg/builder"
2728
"sigs.k8s.io/controller-runtime/pkg/client"
2829

2930
kueue "sigs.k8s.io/kueue/apis/kueue/v1beta1"
@@ -46,7 +47,12 @@ type AppWrapper workloadv1beta2.AppWrapper
4647

4748
var (
4849
GVK = workloadv1beta2.GroupVersion.WithKind("AppWrapper")
49-
WorkloadReconciler = jobframework.NewGenericReconcilerFactory(func() jobframework.GenericJob { return &AppWrapper{} })
50+
WorkloadReconciler = jobframework.NewGenericReconcilerFactory(
51+
func() jobframework.GenericJob { return &AppWrapper{} },
52+
func(b *builder.Builder, c client.Client) *builder.Builder {
53+
return b.Named("AppWrapperWorkload")
54+
},
55+
)
5056
)
5157

5258
func (aw *AppWrapper) Object() client.Object {

0 commit comments

Comments
 (0)