Skip to content

Commit 44a4696

Browse files
committed
restore config directory after building bundle
Signed-off-by: Kevin <[email protected]>
1 parent 4e908e3 commit 44a4696

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

Diff for: CONTRIBUTING.md

+5-5
Original file line numberDiff line numberDiff line change
@@ -31,20 +31,20 @@ If changes are made to any Go code (like in the `controllers` dir for example),
3131
- This will check and build/compile the modified code
3232

3333
For building and pushing a new version of the operator image:
34-
- `make image-build -e IMG_TAG_BASE=<image-repo/image-name> VERSION=<semver>`
35-
- `make image-push -e IMG_TAG_BASE=<image-repo/image-name> VERSION=<semver>`
34+
- `make image-build -e IMAGE_TAG_BASE=<image-repo/image-name> VERSION=<semver>`
35+
- `make image-push -e IMAGE_TAG_BASE=<image-repo/image-name> VERSION=<semver>`
3636

3737
For deploying onto a cluster:
3838
- First, either set `KUBECONFIG` or ensure you are logged into a cluster in your environment
3939
- `make install`
4040
- `make deploy -e IMG=<image-repo/image-name>`
4141

4242
For building and pushing a new version of the bundled operator image:
43-
- `make bundle-build -e IMG_TAG_BASE=<image-repo/image-name> VERSION=<new semver> PREVIOUS_VERSION=<semver to replace>`
44-
- `make bundle-push -e IMG_TAG_BASE=<image-repo/image-name> VERSION=<new semver> PREVIOUS_VERSION=<semver to replace>`
43+
- `make bundle-build -e IMAGE_TAG_BASE=<image-repo/image-name> VERSION=<new semver> PREVIOUS_VERSION=<semver to replace>`
44+
- `make bundle-push -e IMAGE_TAG_BASE=<image-repo/image-name> VERSION=<new semver> PREVIOUS_VERSION=<semver to replace>`
4545

4646
To create a new openshift-community-operator-release:
47-
- `make openshift-community-operator-release -e IMG_TAG_BASE=<image-repo/image-name> VERSION=<new semver> PREVIOUS_VERSION=<semver to replace>`
47+
- `make openshift-community-operator-release -e IMAGE_TAG_BASE=<image-repo/image-name> VERSION=<new semver> PREVIOUS_VERSION=<semver to replace>`
4848

4949
## Testing
5050
The CodeFlare Operator currently has unit tests and pre-commit checks

Diff for: Makefile

+2
Original file line numberDiff line numberDiff line change
@@ -170,6 +170,7 @@ uninstall: manifests kustomize ## Uninstall CRDs from the K8s cluster specified
170170
deploy: manifests kustomize ## Deploy controller to the K8s cluster specified in ~/.kube/config.
171171
cd config/manager && $(KUSTOMIZE) edit set image controller=${IMG}
172172
$(KUSTOMIZE) build config/default | kubectl apply -f -
173+
git restore config/*
173174

174175
.PHONY: undeploy
175176
undeploy: ## Undeploy controller from the K8s cluster specified in ~/.kube/config. Call with ignore-not-found=true to ignore resource not found errors during deletion.
@@ -241,6 +242,7 @@ bundle: defaults manifests kustomize install-operator-sdk ## Generate bundle man
241242
cd config/manifests && $(KUSTOMIZE) edit add patch --patch '[{"op":"add", "path":"/spec/replaces", "value": "codeflare-operator.v$(PREVIOUS_VERSION)" }]' --kind ClusterServiceVersion
242243
$(KUSTOMIZE) build config/manifests | $(OPERATOR_SDK) generate bundle $(BUNDLE_GEN_FLAGS)
243244
$(MAKE) validate-bundle
245+
git restore config/*
244246

245247
.PHONY: bundle-build
246248
bundle-build: bundle ## Build the bundle image.

0 commit comments

Comments
 (0)