Skip to content

Commit 7ee094b

Browse files
committed
Revert "Add Ingress domain for sdk e2e test"
This reverts commit ffc2004.
1 parent 771b34a commit 7ee094b

File tree

2 files changed

+1
-40
lines changed

2 files changed

+1
-40
lines changed

Diff for: test/e2e/mnist_raycluster_sdk.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -83,4 +83,4 @@
8383
if not status.state == AppState.SUCCEEDED:
8484
exit(1)
8585
else:
86-
exit(0)
86+
exit(0)

Diff for: test/e2e/mnist_raycluster_sdk_test.go

-39
Original file line numberDiff line numberDiff line change
@@ -19,15 +19,13 @@ package e2e
1919
import (
2020
"testing"
2121

22-
"github.com/onsi/gomega"
2322
. "github.com/onsi/gomega"
2423
. "github.com/project-codeflare/codeflare-common/support"
2524
mcadv1beta1 "github.com/project-codeflare/multi-cluster-app-dispatcher/pkg/apis/controller/v1beta1"
2625
rayv1 "github.com/ray-project/kuberay/ray-operator/apis/ray/v1"
2726

2827
batchv1 "k8s.io/api/batch/v1"
2928
corev1 "k8s.io/api/core/v1"
30-
networkingv1 "k8s.io/api/networking/v1"
3129
rbacv1 "k8s.io/api/rbac/v1"
3230
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
3331
)
@@ -98,43 +96,6 @@ func TestMNISTRayClusterSDK(t *testing.T) {
9896
clusterRole := CreateClusterRole(test, clusterPolicyRules)
9997
CreateClusterRoleBinding(test, sa, clusterRole)
10098

101-
ingress := &networkingv1.Ingress{
102-
ObjectMeta: metav1.ObjectMeta{
103-
Name: "ray-ingress",
104-
Namespace: namespace.Name,
105-
},
106-
Spec: networkingv1.IngressSpec{
107-
Rules: []networkingv1.IngressRule{
108-
{
109-
Host: "ray-dashboard-mnist-test.com",
110-
IngressRuleValue: networkingv1.IngressRuleValue{
111-
HTTP: &networkingv1.HTTPIngressRuleValue{
112-
Paths: []networkingv1.HTTPIngressPath{
113-
{
114-
PathType: func(s networkingv1.PathType) *networkingv1.PathType { return &s }(networkingv1.PathTypePrefix),
115-
Path: "/",
116-
Backend: networkingv1.IngressBackend{
117-
Service: &networkingv1.IngressServiceBackend{
118-
Name: "raycluster-head-svc",
119-
Port: networkingv1.ServiceBackendPort{
120-
Number: 80,
121-
},
122-
},
123-
},
124-
},
125-
},
126-
},
127-
},
128-
},
129-
},
130-
},
131-
}
132-
133-
// Create the Ingress
134-
createdIngress, err := test.Client().Core().NetworkingV1().Ingresses(namespace.Name).Create(test.Ctx(), ingress, metav1.CreateOptions{})
135-
test.Expect(err).NotTo(gomega.HaveOccurred())
136-
test.T().Logf("Created Ingress %s/%s successfully", createdIngress.Namespace, createdIngress.Name)
137-
13899
job := &batchv1.Job{
139100
TypeMeta: metav1.TypeMeta{
140101
APIVersion: batchv1.SchemeGroupVersion.String(),

0 commit comments

Comments
 (0)