Skip to content

Commit a3db2b2

Browse files
sutaakaropenshift-merge-robot
authored andcommitted
Test support: return error if Ray API response code doesn't match
1 parent be0dd48 commit a3db2b2

File tree

1 file changed

+17
-4
lines changed

1 file changed

+17
-4
lines changed

test/support/ray_cluster_client.go

+17-4
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ package support
1919
import (
2020
"bytes"
2121
"encoding/json"
22+
"fmt"
2223
"io"
2324
"net/http"
2425
"net/url"
@@ -77,13 +78,17 @@ func (client *rayClusterClient) CreateJob(job *RayJobSetup) (response *RayJobRes
7778
return
7879
}
7980

81+
if resp.StatusCode != 200 {
82+
return nil, fmt.Errorf("incorrect response code: %d for creating Ray Job, response body: %s", resp.StatusCode, respData)
83+
}
84+
8085
err = json.Unmarshal(respData, &response)
8186
return
8287
}
8388

8489
func (client *rayClusterClient) GetJobDetails(jobID string) (response *RayJobDetailsResponse, err error) {
85-
createJobURL := client.endpoint.String() + "/api/jobs/" + jobID
86-
resp, err := http.Get(createJobURL)
90+
getJobDetailsURL := client.endpoint.String() + "/api/jobs/" + jobID
91+
resp, err := http.Get(getJobDetailsURL)
8792
if err != nil {
8893
return
8994
}
@@ -93,13 +98,17 @@ func (client *rayClusterClient) GetJobDetails(jobID string) (response *RayJobDet
9398
return
9499
}
95100

101+
if resp.StatusCode != 200 {
102+
return nil, fmt.Errorf("incorrect response code: %d for retrieving Ray Job details, response body: %s", resp.StatusCode, respData)
103+
}
104+
96105
err = json.Unmarshal(respData, &response)
97106
return
98107
}
99108

100109
func (client *rayClusterClient) GetJobLogs(jobID string) (logs string, err error) {
101-
createJobURL := client.endpoint.String() + "/api/jobs/" + jobID + "/logs"
102-
resp, err := http.Get(createJobURL)
110+
getJobLogsURL := client.endpoint.String() + "/api/jobs/" + jobID + "/logs"
111+
resp, err := http.Get(getJobLogsURL)
103112
if err != nil {
104113
return
105114
}
@@ -109,6 +118,10 @@ func (client *rayClusterClient) GetJobLogs(jobID string) (logs string, err error
109118
return
110119
}
111120

121+
if resp.StatusCode != 200 {
122+
return "", fmt.Errorf("incorrect response code: %d for retrieving Ray Job logs, response body: %s", resp.StatusCode, respData)
123+
}
124+
112125
jobLogs := RayJobLogsResponse{}
113126
err = json.Unmarshal(respData, &jobLogs)
114127
return jobLogs.Logs, err

0 commit comments

Comments
 (0)