change: make namespace required for functions

Author: carsonmh

src/codeflare_sdk/cli/commands/define.py

@@ -13,7 +13,7 @@ def cli():
 
 @cli.command()
 @click.option("--name", type=str, required=True)
-@click.option("--namespace", "-n", type=str)
+@click.option("--namespace", "-n", type=str, required=True)
 @click.option("--head_info", cls=PythonLiteralOption, type=list)
 @click.option("--machine_types", cls=PythonLiteralOption, type=list)
 @click.option("--min_cpus", type=int)

src/codeflare_sdk/cli/commands/delete.py

@@ -13,7 +13,7 @@ def cli():
 
 @cli.command()
 @click.argument("name", type=str)
-@click.option("--namespace", type=str, default="default")
+@click.option("--namespace", type=str, required=True)
 def raycluster(name, namespace):
     """
     Delete a specified RayCluster from the Kubernetes cluster

src/codeflare_sdk/cli/commands/details.py

@@ -11,7 +11,7 @@ def cli():
 
 @cli.command()
 @click.argument("name", type=str)
-@click.option("--namespace", type=str)
+@click.option("--namespace", type=str, required=True)
 @click.pass_context
 def raycluster(ctx, name, namespace):
     """Get the details of a specified RayCluster"""

src/codeflare_sdk/cli/commands/list.py

@@ -16,15 +16,17 @@ def cli():
 
 
 @cli.command()
-@click.option("--namespace")
+@click.option("--namespace", type=str)
 @click.option("--all", is_flag=True)
 @click.pass_context
 def rayclusters(ctx, namespace, all):
     """List all rayclusters in a specified namespace"""
     if all and namespace:
         click.echo("--all and --namespace are mutually exclusive")
         return
-    namespace = namespace or "default"
+    if not all and not namespace:
+        click.echo("You must specify either --namespace or --all")
+        return
     if not all:
         list_all_clusters(namespace)
         return

src/codeflare_sdk/cli/commands/status.py

@@ -11,7 +11,7 @@ def cli():
 
 @cli.command()
 @click.argument("name", type=str)
-@click.option("--namespace", type=str)
+@click.option("--namespace", type=str, required=True)
 @click.pass_context
 def raycluster(ctx, name, namespace):
     """Get the status of a specified RayCluster"""

tests/unit_test.py

@@ -201,12 +201,14 @@ def test_cluster_deletion_cli(mocker):
     runner = CliRunner()
     delete_cluster_command = """
                             delete raycluster
-                            quicktest
+                            quicktest --namespace=default
                             """
     result = runner.invoke(cli, delete_cluster_command)
 
     assert result.exit_code == 0
     assert "Cluster deleted successfully" in result.output
+
+
 def test_list_clusters_all_namespaces(mocker, capsys):
     mocker.patch(
         "kubernetes.client.CustomObjectsApi.list_cluster_custom_object",
@@ -252,7 +254,7 @@ def test_raycluster_details_cli(mocker):
     )
     mocker.patch.object(client, "ApiClient")
     raycluster_details_command = """
-                                details raycluster quicktest
+                                details raycluster quicktest --namespace=default
                                 """
     result = runner.invoke(cli, raycluster_details_command)
     quicktest_details = (
@@ -312,7 +314,7 @@ def test_raycluster_status_cli(mocker):
         return_value=test_raycluster,
     )
     raycluster_status_command = """
-                                status raycluster quicktest
+                                status raycluster quicktest --namespace=default
                                 """
     result = runner.invoke(cli, raycluster_status_command)
     assert "Active" in result.output