Skip to content

Commit bca0c05

Browse files
committed
fix: removes label selector from old e2e tests
1 parent b349460 commit bca0c05

File tree

3 files changed

+12
-10
lines changed

3 files changed

+12
-10
lines changed

tests/e2e/heterogeneous_clusters_kind_test.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ def teardown_method(self):
2525
@pytest.mark.nvidia_gpu
2626
def test_heterogeneous_clusters(self):
2727
create_namespace(self)
28-
create_kueue_resources(self, 2)
28+
create_kueue_resources(self, 2, with_labels=True)
2929
self.run_heterogeneous_clusters()
3030

3131
def run_heterogeneous_clusters(

tests/e2e/heterogeneous_clusters_oauth_test.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ def teardown_method(self):
2424

2525
def test_heterogeneous_clusters(self):
2626
create_namespace(self)
27-
create_kueue_resources(self, 2)
27+
create_kueue_resources(self, 2, with_labels=True)
2828
self.run_heterogeneous_clusters()
2929

3030
def run_heterogeneous_clusters(

tests/e2e/support.py

+10-8
Original file line numberDiff line numberDiff line change
@@ -66,12 +66,12 @@ def create_namespace(self):
6666
return RuntimeError(e)
6767

6868

69-
def create_new_resource_flavor(self, num_flavors):
69+
def create_new_resource_flavor(self, num_flavors, with_labels):
7070
self.resource_flavors = []
7171
for i in range(num_flavors):
7272
default = i < 1
7373
resource_flavor = f"test-resource-flavor-{random_choice()}"
74-
create_resource_flavor(self, resource_flavor, default)
74+
create_resource_flavor(self, resource_flavor, default, with_labels)
7575
self.resource_flavors.append(resource_flavor)
7676

7777

@@ -173,7 +173,7 @@ def create_cluster_queue(self, cluster_queue, flavor):
173173
self.cluster_queue = cluster_queue
174174

175175

176-
def create_resource_flavor(self, flavor, default=True):
176+
def create_resource_flavor(self, flavor, default=True, with_labels=False):
177177
worker_label, worker_value = os.getenv("WORKER_LABEL", "worker-1=true").split("=")
178178
control_label, control_value = os.getenv(
179179
"CONTROL_LABEL", "ingress-ready=true"
@@ -182,9 +182,11 @@ def create_resource_flavor(self, flavor, default=True):
182182
"TOLERATION_KEY", "node-role.kubernetes.io/control-plane"
183183
)
184184

185-
node_labels = (
186-
{worker_label: worker_value} if default else {control_label: control_value}
187-
)
185+
node_labels = {}
186+
if with_labels:
187+
node_labels = (
188+
{worker_label: worker_value} if default else {control_label: control_value}
189+
)
188190

189191
resource_flavor_json = {
190192
"apiVersion": "kueue.x-k8s.io/v1beta1",
@@ -260,9 +262,9 @@ def create_local_queue(self, cluster_queue, local_queue, is_default=True):
260262
self.local_queue = local_queue
261263

262264

263-
def create_kueue_resources(self, resource_ammount=1):
265+
def create_kueue_resources(self, resource_ammount=1, with_labels=False):
264266
print("creating Kueue resources ...")
265-
create_new_resource_flavor(self, resource_ammount)
267+
create_new_resource_flavor(self, resource_ammount, with_labels)
266268
create_new_cluster_queue(self, resource_ammount)
267269
create_new_local_queue(self, resource_ammount)
268270

0 commit comments

Comments
 (0)