Skip to content

Commit bd2b2eb

Browse files
committed
Updated Ray version to 2.20.0
Removed rayVersion from base template
1 parent 2a43d9e commit bd2b2eb

File tree

13 files changed

+108
-196
lines changed

13 files changed

+108
-196
lines changed

Diff for: .github/workflows/e2e_tests.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ jobs:
4343
sudo rm -rf /opt/ghc
4444
sudo rm -rf "/usr/local/share/boost"
4545
sudo rm -rf "$AGENT_TOOLSDIRECTORY"
46+
sudo apt install python3.9
4647
docker rmi $(docker image ls -aq)
4748
echo "Final status:"
4849
df -h

Diff for: demo-notebooks/guided-demos/notebook-ex-outputs/interactivetest.yaml

-1
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,6 @@ spec:
108108
memory: 8G
109109
nvidia.com/gpu: 0
110110
imagePullSecrets: []
111-
rayVersion: 2.1.0
112111
workerGroupSpecs:
113112
- groupName: small-group-interactivetest
114113
maxReplicas: 2

Diff for: demo-notebooks/guided-demos/notebook-ex-outputs/jobtest.yaml

-1
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,6 @@ spec:
9797
memory: 8G
9898
nvidia.com/gpu: 0
9999
imagePullSecrets: []
100-
rayVersion: 2.1.0
101100
workerGroupSpecs:
102101
- groupName: small-group-jobtest
103102
maxReplicas: 2

Diff for: demo-notebooks/guided-demos/notebook-ex-outputs/raytest.yaml

-1
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,6 @@ spec:
9797
memory: 8G
9898
nvidia.com/gpu: 0
9999
imagePullSecrets: []
100-
rayVersion: 2.1.0
101100
workerGroupSpecs:
102101
- groupName: small-group-raytest
103102
maxReplicas: 2

Diff for: poetry.lock

+103-176
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: pyproject.toml

+2-2
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,10 @@ homepage = "https://github.com/project-codeflare/codeflare-sdk"
2020
keywords = ['codeflare', 'python', 'sdk', 'client', 'batch', 'scale']
2121

2222
[tool.poetry.dependencies]
23-
python = "^3.8"
23+
python = "^3.9"
2424
openshift-client = "1.0.18"
2525
rich = "^12.5"
26-
ray = {version = "2.7.0", extras = ["data", "default"]}
26+
ray = {version = "2.20.0", extras = ["data", "default"]}
2727
kubernetes = ">= 25.3.0, < 27"
2828
codeflare-torchx = "0.6.0.dev2"
2929
cryptography = "40.0.2"

Diff for: src/codeflare_sdk/templates/base-template.yaml

-2
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,6 @@ spec:
4848
# finalizers:
4949
# - kubernetes
5050
spec:
51-
# The version of Ray you are using. Make sure all Ray containers are running this version of Ray.
52-
rayVersion: '2.7.0'
5351
# If enableInTreeAutoscaling is true, the autoscaler sidecar will be added to the Ray head pod.
5452
# Ray autoscaler integration is supported only for Ray versions >= 1.11.0
5553
# Ray autoscaler integration is Beta with KubeRay >= 0.3.0 and Ray >= 2.0.0.

Diff for: tests/test-case-bad.yaml

-1
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,6 @@ spec:
9999
cpu: 2
100100
memory: 8G
101101
nvidia.com/gpu: 0
102-
rayVersion: 1.12.0
103102
workerGroupSpecs:
104103
- groupName: small-group-unit-test-cluster
105104
maxReplicas: 2

Diff for: tests/test-case-no-mcad.yamls

-1
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,6 @@ spec:
9797
name: odh-trusted-ca-bundle
9898
optional: true
9999
name: odh-ca-cert
100-
rayVersion: 2.7.0
101100
workerGroupSpecs:
102101
- groupName: small-group-unit-test-cluster-ray
103102
maxReplicas: 2

Diff for: tests/test-case-prio.yaml

-1
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,6 @@ spec:
126126
name: odh-trusted-ca-bundle
127127
optional: true
128128
name: odh-ca-cert
129-
rayVersion: 2.7.0
130129
workerGroupSpecs:
131130
- groupName: small-group-prio-test-cluster
132131
maxReplicas: 2

Diff for: tests/test-case.yaml

-1
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,6 @@ spec:
124124
name: odh-trusted-ca-bundle
125125
optional: true
126126
name: odh-ca-cert
127-
rayVersion: 2.7.0
128127
workerGroupSpecs:
129128
- groupName: small-group-unit-test-cluster
130129
maxReplicas: 2

Diff for: tests/test-default-appwrapper.yaml

-1
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,6 @@ spec:
112112
name: odh-trusted-ca-bundle
113113
optional: true
114114
name: odh-ca-cert
115-
rayVersion: 2.7.0
116115
workerGroupSpecs:
117116
- groupName: small-group-unit-test-default-cluster
118117
maxReplicas: 1

Diff for: tests/unit_test.py

+2-8
Original file line numberDiff line numberDiff line change
@@ -1095,7 +1095,6 @@ def get_ray_obj(group, version, namespace, plural, cls=None):
10951095
},
10961096
},
10971097
},
1098-
"f:rayVersion": {},
10991098
"f:workerGroupSpecs": {},
11001099
},
11011100
},
@@ -1306,7 +1305,6 @@ def get_ray_obj(group, version, namespace, plural, cls=None):
13061305
},
13071306
},
13081307
},
1309-
"rayVersion": "2.7.0",
13101308
"workerGroupSpecs": [
13111309
{
13121310
"groupName": "small-group-quicktest",
@@ -1526,7 +1524,6 @@ def get_ray_obj(group, version, namespace, plural, cls=None):
15261524
"f:spec": {".": {}, "f:containers": {}},
15271525
},
15281526
},
1529-
"f:rayVersion": {},
15301527
"f:workerGroupSpecs": {},
15311528
},
15321529
},
@@ -1645,7 +1642,6 @@ def get_ray_obj(group, version, namespace, plural, cls=None):
16451642
}
16461643
},
16471644
},
1648-
"rayVersion": "1.12.0",
16491645
"workerGroupSpecs": [
16501646
{
16511647
"groupName": "small-group-quicktest2",
@@ -1735,7 +1731,7 @@ def get_aw_obj(group, version, namespace, plural):
17351731
"kind": "AppWrapper",
17361732
"metadata": {
17371733
"annotations": {
1738-
"kubectl.kubernetes.io/last-applied-configuration": '{"apiVersion":"codeflare.dev/v1beta1","kind":"AppWrapper","metadata":{"annotations":{},"name":"quicktest1","namespace":"ns"},"spec":{"priority":9,"resources":{"GenericItems":[{"custompodresources":[{"limits":{"cpu":2,"memory":"8G","nvidia.com/gpu":0},"replicas":1,"requests":{"cpu":2,"memory":"8G","nvidia.com/gpu":0}},{"limits":{"cpu":1,"memory":"2G","nvidia.com/gpu":0},"replicas":1,"requests":{"cpu":1,"memory":"2G","nvidia.com/gpu":0}}],"generictemplate":{"apiVersion":"ray.io/v1","kind":"RayCluster","metadata":{"labels":{"appwrapper.codeflare.dev":"quicktest1","controller-tools.k8s.io":"1.0"},"name":"quicktest1","namespace":"ns"},"spec":{"autoscalerOptions":{"idleTimeoutSeconds":60,"imagePullPolicy":"Always","resources":{"limits":{"cpu":"500m","memory":"512Mi"},"requests":{"cpu":"500m","memory":"512Mi"}},"upscalingMode":"Default"},"enableInTreeAutoscaling":false,"headGroupSpec":{"rayStartParams":{"block":"true","dashboard-host":"0.0.0.0","num-gpus":"0"},"serviceType":"ClusterIP","template":{"spec":{"containers":[{"image":"ghcr.io/foundation-model-stack/base:ray2.1.0-py38-gpu-pytorch1.12.0cu116-20221213-193103","imagePullPolicy":"Always","lifecycle":{"preStop":{"exec":{"command":["/bin/sh","-c","ray stop"]}}},"name":"ray-head","ports":[{"containerPort":6379,"name":"gcs"},{"containerPort":8265,"name":"dashboard"},{"containerPort":10001,"name":"client"}],"resources":{"limits":{"cpu":2,"memory":"8G","nvidia.com/gpu":0},"requests":{"cpu":2,"memory":"8G","nvidia.com/gpu":0}}}]}}},"rayVersion":"1.12.0","workerGroupSpecs":[{"groupName":"small-group-quicktest","maxReplicas":1,"minReplicas":1,"rayStartParams":{"block":"true","num-gpus":"0"},"replicas":1,"template":{"metadata":{"annotations":{"key":"value"},"labels":{"key":"value"}},"spec":{"containers":[{"env":[{"name":"MY_POD_IP","valueFrom":{"fieldRef":{"fieldPath":"status.podIP"}}}],"image":"ghcr.io/foundation-model-stack/base:ray2.1.0-py38-gpu-pytorch1.12.0cu116-20221213-193103","lifecycle":{"preStop":{"exec":{"command":["/bin/sh","-c","ray stop"]}}},"name":"machine-learning","resources":{"limits":{"cpu":1,"memory":"2G","nvidia.com/gpu":0},"requests":{"cpu":1,"memory":"2G","nvidia.com/gpu":0}}}],}}}]}},"replicas":1},{"generictemplate":{"apiVersion":"route.openshift.io/v1","kind":"Route","metadata":{"labels":{"odh-ray-cluster-service":"quicktest-head-svc"},"name":"ray-dashboard-quicktest","namespace":"default"},"spec":{"port":{"targetPort":"dashboard"},"to":{"kind":"Service","name":"quicktest-head-svc"}}},"replica":1}],"Items":[]}}}\n'
1734+
"kubectl.kubernetes.io/last-applied-configuration": '{"apiVersion":"codeflare.dev/v1beta1","kind":"AppWrapper","metadata":{"annotations":{},"name":"quicktest1","namespace":"ns"},"spec":{"priority":9,"resources":{"GenericItems":[{"custompodresources":[{"limits":{"cpu":2,"memory":"8G","nvidia.com/gpu":0},"replicas":1,"requests":{"cpu":2,"memory":"8G","nvidia.com/gpu":0}},{"limits":{"cpu":1,"memory":"2G","nvidia.com/gpu":0},"replicas":1,"requests":{"cpu":1,"memory":"2G","nvidia.com/gpu":0}}],"generictemplate":{"apiVersion":"ray.io/v1","kind":"RayCluster","metadata":{"labels":{"appwrapper.codeflare.dev":"quicktest1","controller-tools.k8s.io":"1.0"},"name":"quicktest1","namespace":"ns"},"spec":{"autoscalerOptions":{"idleTimeoutSeconds":60,"imagePullPolicy":"Always","resources":{"limits":{"cpu":"500m","memory":"512Mi"},"requests":{"cpu":"500m","memory":"512Mi"}},"upscalingMode":"Default"},"enableInTreeAutoscaling":false,"headGroupSpec":{"rayStartParams":{"block":"true","dashboard-host":"0.0.0.0","num-gpus":"0"},"serviceType":"ClusterIP","template":{"spec":{"containers":[{"image":"ghcr.io/foundation-model-stack/base:ray2.1.0-py38-gpu-pytorch1.12.0cu116-20221213-193103","imagePullPolicy":"Always","lifecycle":{"preStop":{"exec":{"command":["/bin/sh","-c","ray stop"]}}},"name":"ray-head","ports":[{"containerPort":6379,"name":"gcs"},{"containerPort":8265,"name":"dashboard"},{"containerPort":10001,"name":"client"}],"resources":{"limits":{"cpu":2,"memory":"8G","nvidia.com/gpu":0},"requests":{"cpu":2,"memory":"8G","nvidia.com/gpu":0}}}]}}},"workerGroupSpecs":[{"groupName":"small-group-quicktest","maxReplicas":1,"minReplicas":1,"rayStartParams":{"block":"true","num-gpus":"0"},"replicas":1,"template":{"metadata":{"annotations":{"key":"value"},"labels":{"key":"value"}},"spec":{"containers":[{"env":[{"name":"MY_POD_IP","valueFrom":{"fieldRef":{"fieldPath":"status.podIP"}}}],"image":"ghcr.io/foundation-model-stack/base:ray2.1.0-py38-gpu-pytorch1.12.0cu116-20221213-193103","lifecycle":{"preStop":{"exec":{"command":["/bin/sh","-c","ray stop"]}}},"name":"machine-learning","resources":{"limits":{"cpu":1,"memory":"2G","nvidia.com/gpu":0},"requests":{"cpu":1,"memory":"2G","nvidia.com/gpu":0}}}],}}}]}},"replicas":1},{"generictemplate":{"apiVersion":"route.openshift.io/v1","kind":"Route","metadata":{"labels":{"odh-ray-cluster-service":"quicktest-head-svc"},"name":"ray-dashboard-quicktest","namespace":"default"},"spec":{"port":{"targetPort":"dashboard"},"to":{"kind":"Service","name":"quicktest-head-svc"}}},"replica":1}],"Items":[]}}}\n'
17391735
},
17401736
"creationTimestamp": "2023-02-22T16:26:07Z",
17411737
"generation": 4,
@@ -1912,7 +1908,6 @@ def get_aw_obj(group, version, namespace, plural):
19121908
}
19131909
},
19141910
},
1915-
"rayVersion": "1.12.0",
19161911
"workerGroupSpecs": [
19171912
{
19181913
"groupName": "small-group-quicktest",
@@ -2062,7 +2057,7 @@ def get_aw_obj(group, version, namespace, plural):
20622057
"kind": "AppWrapper",
20632058
"metadata": {
20642059
"annotations": {
2065-
"kubectl.kubernetes.io/last-applied-configuration": '{"apiVersion":"codeflare.dev/v1beta1","kind":"AppWrapper","metadata":{"annotations":{},"name":"quicktest2","namespace":"ns"},"spec":{"priority":9,"resources":{"GenericItems":[{"custompodresources":[{"limits":{"cpu":2,"memory":"8G","nvidia.com/gpu":0},"replicas":1,"requests":{"cpu":2,"memory":"8G","nvidia.com/gpu":0}},{"limits":{"cpu":1,"memory":"2G","nvidia.com/gpu":0},"replicas":1,"requests":{"cpu":1,"memory":"2G","nvidia.com/gpu":0}}],"generictemplate":{"apiVersion":"ray.io/v1","kind":"RayCluster","metadata":{"labels":{"appwrapper.codeflare.dev":"quicktest2","controller-tools.k8s.io":"1.0"},"name":"quicktest2","namespace":"ns"},"spec":{"autoscalerOptions":{"idleTimeoutSeconds":60,"imagePullPolicy":"Always","resources":{"limits":{"cpu":"500m","memory":"512Mi"},"requests":{"cpu":"500m","memory":"512Mi"}},"upscalingMode":"Default"},"enableInTreeAutoscaling":false,"headGroupSpec":{"rayStartParams":{"block":"true","dashboard-host":"0.0.0.0","num-gpus":"0"},"serviceType":"ClusterIP","template":{"spec":{"containers":[{"image":"ghcr.io/foundation-model-stack/base:ray2.1.0-py38-gpu-pytorch1.12.0cu116-20221213-193103","imagePullPolicy":"Always","lifecycle":{"preStop":{"exec":{"command":["/bin/sh","-c","ray stop"]}}},"name":"ray-head","ports":[{"containerPort":6379,"name":"gcs"},{"containerPort":8265,"name":"dashboard"},{"containerPort":10001,"name":"client"}],"resources":{"limits":{"cpu":2,"memory":"8G","nvidia.com/gpu":0},"requests":{"cpu":2,"memory":"8G","nvidia.com/gpu":0}}}]}}},"rayVersion":"1.12.0","workerGroupSpecs":[{"groupName":"small-group-quicktest","maxReplicas":1,"minReplicas":1,"rayStartParams":{"block":"true","num-gpus":"0"},"replicas":1,"template":{"metadata":{"annotations":{"key":"value"},"labels":{"key":"value"}},"spec":{"containers":[{"env":[{"name":"MY_POD_IP","valueFrom":{"fieldRef":{"fieldPath":"status.podIP"}}}],"image":"ghcr.io/foundation-model-stack/base:ray2.1.0-py38-gpu-pytorch1.12.0cu116-20221213-193103","lifecycle":{"preStop":{"exec":{"command":["/bin/sh","-c","ray stop"]}}},"name":"machine-learning","resources":{"limits":{"cpu":1,"memory":"2G","nvidia.com/gpu":0},"requests":{"cpu":1,"memory":"2G","nvidia.com/gpu":0}}}],}}}]}},"replicas":1},{"generictemplate":{"apiVersion":"route.openshift.io/v1","kind":"Route","metadata":{"labels":{"odh-ray-cluster-service":"quicktest-head-svc"},"name":"ray-dashboard-quicktest","namespace":"default"},"spec":{"port":{"targetPort":"dashboard"},"to":{"kind":"Service","name":"quicktest-head-svc"}}},"replica":1}],"Items":[]}}}\n'
2060+
"kubectl.kubernetes.io/last-applied-configuration": '{"apiVersion":"codeflare.dev/v1beta1","kind":"AppWrapper","metadata":{"annotations":{},"name":"quicktest2","namespace":"ns"},"spec":{"priority":9,"resources":{"GenericItems":[{"custompodresources":[{"limits":{"cpu":2,"memory":"8G","nvidia.com/gpu":0},"replicas":1,"requests":{"cpu":2,"memory":"8G","nvidia.com/gpu":0}},{"limits":{"cpu":1,"memory":"2G","nvidia.com/gpu":0},"replicas":1,"requests":{"cpu":1,"memory":"2G","nvidia.com/gpu":0}}],"generictemplate":{"apiVersion":"ray.io/v1","kind":"RayCluster","metadata":{"labels":{"appwrapper.codeflare.dev":"quicktest2","controller-tools.k8s.io":"1.0"},"name":"quicktest2","namespace":"ns"},"spec":{"autoscalerOptions":{"idleTimeoutSeconds":60,"imagePullPolicy":"Always","resources":{"limits":{"cpu":"500m","memory":"512Mi"},"requests":{"cpu":"500m","memory":"512Mi"}},"upscalingMode":"Default"},"enableInTreeAutoscaling":false,"headGroupSpec":{"rayStartParams":{"block":"true","dashboard-host":"0.0.0.0","num-gpus":"0"},"serviceType":"ClusterIP","template":{"spec":{"containers":[{"image":"ghcr.io/foundation-model-stack/base:ray2.1.0-py38-gpu-pytorch1.12.0cu116-20221213-193103","imagePullPolicy":"Always","lifecycle":{"preStop":{"exec":{"command":["/bin/sh","-c","ray stop"]}}},"name":"ray-head","ports":[{"containerPort":6379,"name":"gcs"},{"containerPort":8265,"name":"dashboard"},{"containerPort":10001,"name":"client"}],"resources":{"limits":{"cpu":2,"memory":"8G","nvidia.com/gpu":0},"requests":{"cpu":2,"memory":"8G","nvidia.com/gpu":0}}}]}}},"workerGroupSpecs":[{"groupName":"small-group-quicktest","maxReplicas":1,"minReplicas":1,"rayStartParams":{"block":"true","num-gpus":"0"},"replicas":1,"template":{"metadata":{"annotations":{"key":"value"},"labels":{"key":"value"}},"spec":{"containers":[{"env":[{"name":"MY_POD_IP","valueFrom":{"fieldRef":{"fieldPath":"status.podIP"}}}],"image":"ghcr.io/foundation-model-stack/base:ray2.1.0-py38-gpu-pytorch1.12.0cu116-20221213-193103","lifecycle":{"preStop":{"exec":{"command":["/bin/sh","-c","ray stop"]}}},"name":"machine-learning","resources":{"limits":{"cpu":1,"memory":"2G","nvidia.com/gpu":0},"requests":{"cpu":1,"memory":"2G","nvidia.com/gpu":0}}}],}}}]}},"replicas":1},{"generictemplate":{"apiVersion":"route.openshift.io/v1","kind":"Route","metadata":{"labels":{"odh-ray-cluster-service":"quicktest-head-svc"},"name":"ray-dashboard-quicktest","namespace":"default"},"spec":{"port":{"targetPort":"dashboard"},"to":{"kind":"Service","name":"quicktest-head-svc"}}},"replica":1}],"Items":[]}}}\n'
20662061
},
20672062
"creationTimestamp": "2023-02-22T16:26:07Z",
20682063
"generation": 4,
@@ -2239,7 +2234,6 @@ def get_aw_obj(group, version, namespace, plural):
22392234
}
22402235
},
22412236
},
2242-
"rayVersion": "1.12.0",
22432237
"workerGroupSpecs": [
22442238
{
22452239
"groupName": "small-group-quicktest",

0 commit comments

Comments
 (0)