Skip to content

Commit bdedaff

Browse files
jstouracopenshift-merge-bot[bot]
authored andcommitted
Fix for the odh-notebook-sync workflow.
This is a followup of #655 where the Pipfile.cpu and Pipfile.gpu support was broken. Apart from that - the array initialization was fixed and the link to this workflow is added to the raised PR description.
1 parent 52f20a4 commit bdedaff

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

.github/workflows/odh-notebooks-sync.yml

+8-8
Original file line numberDiff line numberDiff line change
@@ -55,12 +55,12 @@ jobs:
5555
- name: Update Pipfiles in accordance with Codeflare-SDK latest release
5656
run: |
5757
package_name=codeflare-sdk
58-
available_python_versions=("3.9", "3.11") # add space separated python versions according to 'python-versions' specified in 'Setup Python Environment' step
58+
available_python_versions=("3.9" "3.11") # add space separated python versions according to 'python-versions' specified in 'Setup Python Environment' step
5959
install_package_using_pipenv(){
6060
# args allow custom names for Pipfile and Pipfile.lock
61-
if $# -eq 2; then
62-
mv $1 Pipfile
63-
mv $2 Pipfile.lock
61+
if [ $# -eq 2 ]; then
62+
mv "${1}" Pipfile
63+
mv "${2}" Pipfile.lock
6464
fi
6565
if ! pipenv install ${package_name}~="${CODEFLARE_RELEASE_VERSION}"; then
6666
echo "Failed to install ${package_name} with version ${CODEFLARE_RELEASE_VERSION} in $dir"
@@ -76,9 +76,9 @@ jobs:
7676
echo "Failed to remove virtual environment"
7777
exit 1
7878
fi
79-
if $# -eq 2; then
80-
mv Pipfile $1
81-
mv Pipfile.lock $2
79+
if [ $# -eq 2 ]; then
80+
mv Pipfile "${1}"
81+
mv Pipfile.lock "${2}"
8282
fi
8383
}
8484
# Get the list of available versions for the package
@@ -153,6 +153,6 @@ jobs:
153153
env:
154154
pr_title: "[Codeflare Action] Update notebook's pipfile to sync with Codeflare-SDK release ${{ env.CODEFLARE_RELEASE_VERSION }}"
155155
pr_body: |
156-
:rocket: This is an automated Pull Request.
156+
:rocket: This is an automated Pull Request generated by [odh-notebooks-sync.yml](https://github.com/project-codeflare/codeflare-sdk/blob/main/.github/workflows/odh-notebooks-sync.yml) workflow.
157157
158158
This PR updates the `Pipfile` to sync with latest Codeflare-SDK release.

0 commit comments

Comments
 (0)