You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a followup of #655 where the Pipfile.cpu and Pipfile.gpu support
was broken. Apart from that - the array initialization was fixed and the
link to this workflow is added to the raised PR description.
Copy file name to clipboardExpand all lines: .github/workflows/odh-notebooks-sync.yml
+8-8
Original file line number
Diff line number
Diff line change
@@ -55,12 +55,12 @@ jobs:
55
55
- name: Update Pipfiles in accordance with Codeflare-SDK latest release
56
56
run: |
57
57
package_name=codeflare-sdk
58
-
available_python_versions=("3.9", "3.11") # add space separated python versions according to 'python-versions' specified in 'Setup Python Environment' step
58
+
available_python_versions=("3.9" "3.11") # add space separated python versions according to 'python-versions' specified in 'Setup Python Environment' step
59
59
install_package_using_pipenv(){
60
60
# args allow custom names for Pipfile and Pipfile.lock
61
-
if $# -eq 2; then
62
-
mv $1 Pipfile
63
-
mv $2 Pipfile.lock
61
+
if [ $# -eq 2 ]; then
62
+
mv "${1}" Pipfile
63
+
mv "${2}" Pipfile.lock
64
64
fi
65
65
if ! pipenv install ${package_name}~="${CODEFLARE_RELEASE_VERSION}"; then
66
66
echo "Failed to install ${package_name} with version ${CODEFLARE_RELEASE_VERSION} in $dir"
@@ -76,9 +76,9 @@ jobs:
76
76
echo "Failed to remove virtual environment"
77
77
exit 1
78
78
fi
79
-
if $# -eq 2; then
80
-
mv Pipfile $1
81
-
mv Pipfile.lock $2
79
+
if [ $# -eq 2 ]; then
80
+
mv Pipfile "${1}"
81
+
mv Pipfile.lock "${2}"
82
82
fi
83
83
}
84
84
# Get the list of available versions for the package
@@ -153,6 +153,6 @@ jobs:
153
153
env:
154
154
pr_title: "[Codeflare Action] Update notebook's pipfile to sync with Codeflare-SDK release ${{ env.CODEFLARE_RELEASE_VERSION }}"
155
155
pr_body: |
156
-
:rocket: This is an automated Pull Request.
156
+
:rocket: This is an automated Pull Request generated by [odh-notebooks-sync.yml](https://github.com/project-codeflare/codeflare-sdk/blob/main/.github/workflows/odh-notebooks-sync.yml) workflow.
157
157
158
158
This PR updates the `Pipfile` to sync with latest Codeflare-SDK release.
0 commit comments