Skip to content

Ray Cluster Retrieval Function #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Maxusmusti opened this issue Jun 27, 2023 · 4 comments
Closed

Ray Cluster Retrieval Function #183

Maxusmusti opened this issue Jun 27, 2023 · 4 comments
Assignees

Comments

@Maxusmusti
Copy link
Collaborator

Add a function to retrieve ray cluster objects from K8s/OCP, so that people can pick up and resume managing the cluster in fire-and-forget or pipeline scenarios.

@Maxusmusti
Copy link
Collaborator Author

Some implementation details:

In the cluster/cluster.py file, we need a new function:

cluster_retrieval(cluster_name: str, namespace: str = "default") -> Cluster:
    This function should search the k8s/OCP cluster using the specified namespace for a RayCluster with the passed-in 
    name. If found, populate and return a Cluster object with all expected fields (via a ClusterConfig). If not, either return
    None or raise some form of "not found" error or exception.

Note that cluster_retrieval is a place holder name, and if anything better is come up with, it can be used instead.

@MichaelClifford
Copy link
Collaborator

@Maxusmusti is there any issue with using the name get_cluster(cluster_name) instead?

@Maxusmusti
Copy link
Collaborator Author

@MichaelClifford Nope, already a better suggestion 😅

This was referenced Jun 30, 2023
@carsonmh carsonmh moved this from Todo to In Review in Project CodeFlare Sprint Board Jul 6, 2023
@carsonmh carsonmh moved this from In Review to Ready For Review in Project CodeFlare Sprint Board Jul 6, 2023
@carsonmh
Copy link
Contributor

carsonmh commented Jul 6, 2023

#189

@carsonmh carsonmh moved this from Ready For Review to Done in Project CodeFlare Sprint Board Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

3 participants