perf: add liveness and readiness probes to deployments (#85)

* perf: add liveness and readiness probes to deployments

* refactor: removal of deployment dir, and updating the readme to use make deploy cmd

Author: dimakis

README.md

@@ -32,28 +32,11 @@ Key features:
 - To build and release a docker image for controller : `make IMG=quay.io/project-codeflare/instascale:<TAG> docker-build docker-push`
 - Note that the other contents of the Makefile (as well as the `config` and `bin` dirs) exist for future operator development, and are not currently utilized
 ## Deployment
-- Deploy MCAD using steps [here](https://github.com/project-codeflare/multi-cluster-app-dispatcher/blob/main/doc/deploy/deployment.md).
-- Deploy InstaScale using commands below:
-```
-git clone https://github.com/project-codeflare/instascale.git
-cd deployment/
-oc apply -f instascale-configmap.yaml
-oc apply -f instascale-sa.yaml
-oc apply -f instascale-clusterrole.yaml
-oc apply -f instascale-clusterrolebinding.yaml
-oc apply -f deployment.yaml
-```
+- Deploy InstaScale using: `make deploy`
+
 ## Running an InstaScale deployment locally with Visual Studio Code
 - Deploy MCAD using steps [here](https://github.com/project-codeflare/multi-cluster-app-dispatcher/blob/main/doc/deploy/deployment.md).
-- Deploy InstaScale by following the steps below:
-```
-git clone https://github.com/project-codeflare/instascale.git
-cd deployment/
-oc apply -f instascale-configmap.yaml
-oc apply -f instascale-sa.yaml
-oc apply -f instascale-clusterrole.yaml
-oc apply -f instascale-clusterrolebinding.yaml
-```
+
 - In Visual Studio Code update `.vscode/launch.json` so that `"KUBECONFIG"` points to your Kubernetes config file.<br>
 - If you changed the namespace in `instascale-configmap.yaml` update the `args[]` in `launch.json` to include `--configs-namespace="<YOUR_NAMESPACE>"`.<br>
 - You can now run the local deployment with the debugger.

config/manager/manager.yaml

@@ -39,13 +39,12 @@ spec:
           httpGet:
             path: /healthz
             port: 8081
-          initialDelaySeconds: 15
-          periodSeconds: 20
+          periodSeconds: 5
+          timeoutSeconds: 5
         readinessProbe:
           httpGet:
             path: /readyz
             port: 8081
-          initialDelaySeconds: 5
           periodSeconds: 10
         # TODO(user): Configure the resources accordingly based on the project requirements.
         # More info: https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/

config/rbac/role.yaml

@@ -49,3 +49,18 @@ rules:
   - get
   - patch
   - update
+- apiGroups:
+    - ""
+  resourceNames:
+    - instascale-ocm-secret
+  resources:
+    - secrets
+  verbs:
+    - get
+- apiGroups:
+  - config.openshift.io 
+  resources:
+  - clusterversions
+  verbs:
+  - get
+  - update