Skip to content

Commit db3b69e

Browse files
committed
refactor: removal of deployment dir, and updating the readme to use make deploy cmd
1 parent 06bc587 commit db3b69e

7 files changed

+18
-155
lines changed

README.md

+3-20
Original file line numberDiff line numberDiff line change
@@ -32,28 +32,11 @@ Key features:
3232
- To build and release a docker image for controller : `make IMG=quay.io/project-codeflare/instascale:<TAG> docker-build docker-push`
3333
- Note that the other contents of the Makefile (as well as the `config` and `bin` dirs) exist for future operator development, and are not currently utilized
3434
## Deployment
35-
- Deploy MCAD using steps [here](https://github.com/project-codeflare/multi-cluster-app-dispatcher/blob/main/doc/deploy/deployment.md).
36-
- Deploy InstaScale using commands below:
37-
```
38-
git clone https://github.com/project-codeflare/instascale.git
39-
cd deployment/
40-
oc apply -f instascale-configmap.yaml
41-
oc apply -f instascale-sa.yaml
42-
oc apply -f instascale-clusterrole.yaml
43-
oc apply -f instascale-clusterrolebinding.yaml
44-
oc apply -f deployment.yaml
45-
```
35+
- Deploy InstaScale using: `make deploy`
36+
4637
## Running an InstaScale deployment locally with Visual Studio Code
4738
- Deploy MCAD using steps [here](https://github.com/project-codeflare/multi-cluster-app-dispatcher/blob/main/doc/deploy/deployment.md).
48-
- Deploy InstaScale by following the steps below:
49-
```
50-
git clone https://github.com/project-codeflare/instascale.git
51-
cd deployment/
52-
oc apply -f instascale-configmap.yaml
53-
oc apply -f instascale-sa.yaml
54-
oc apply -f instascale-clusterrole.yaml
55-
oc apply -f instascale-clusterrolebinding.yaml
56-
```
39+
5740
- In Visual Studio Code update `.vscode/launch.json` so that `"KUBECONFIG"` points to your Kubernetes config file.<br>
5841
- If you changed the namespace in `instascale-configmap.yaml` update the `args[]` in `launch.json` to include `--configs-namespace="<YOUR_NAMESPACE>"`.<br>
5942
- You can now run the local deployment with the debugger.

config/rbac/role.yaml

+15
Original file line numberDiff line numberDiff line change
@@ -49,3 +49,18 @@ rules:
4949
- get
5050
- patch
5151
- update
52+
- apiGroups:
53+
- ""
54+
resourceNames:
55+
- instascale-ocm-secret
56+
resources:
57+
- secrets
58+
verbs:
59+
- get
60+
- apiGroups:
61+
- config.openshift.io
62+
resources:
63+
- clusterversions
64+
verbs:
65+
- get
66+
- update

deployment/deployment.yaml

-39
This file was deleted.

deployment/instascale-clusterrole.yaml

-70
This file was deleted.

deployment/instascale-clusterrolebinding.yaml

-13
This file was deleted.

deployment/instascale-configmap.yaml

-7
This file was deleted.

deployment/instascale-sa.yaml

-6
This file was deleted.

0 commit comments

Comments
 (0)