Skip to content

Commit 7419685

Browse files
authored
RHOAIENG-16518: ref(jupyter): deduplicate the Jupyterlab loading spinner code using the improvements put into place just before (opendatahub-io#801)
1 parent 227bfb7 commit 7419685

File tree

37 files changed

+21
-584
lines changed

37 files changed

+21
-584
lines changed

jupyter/intel/ml/ubi9-python-3.11/Dockerfile

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
ARG BASE_IMAGE
22
FROM ${BASE_IMAGE}
33

4+
ARG REUSABLE_UTILS=jupyter/utils
45
ARG SOURCE_CODE=jupyter/intel/ml/ubi9-python-3.11
56

67
LABEL name="odh-notebook-jupyter-intel-ml-ubi9-python-3.11" \
@@ -32,7 +33,7 @@ RUN echo "Installing softwares and packages" && \
3233
#Replacing kernel manually with oneapi variable setting script
3334
COPY --chown=1001:0 ${SOURCE_CODE}/start-notebook.sh /opt/app-root/bin
3435
COPY --chown=1001:0 ${SOURCE_CODE}/builder /opt/app-root/builder
35-
COPY --chown=1001:0 ${SOURCE_CODE}/utils /opt/app-root/bin/utils
36+
COPY --chown=1001:0 ${REUSABLE_UTILS} /opt/app-root/bin/utils
3637

3738
# Apply JupyterLab addons
3839
RUN /opt/app-root/bin/utils/addons/apply.sh

jupyter/intel/ml/ubi9-python-3.9/Dockerfile

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
ARG BASE_IMAGE
22
FROM ${BASE_IMAGE}
33

4+
ARG REUSABLE_UTILS=jupyter/utils
45
ARG SOURCE_CODE=jupyter/intel/ml/ubi9-python-3.9
56

67
LABEL name="odh-notebook-jupyter-intel-ml-ubi9-python-3.9" \
@@ -32,7 +33,7 @@ RUN echo "Installing softwares and packages" && \
3233
#Replacing kernel manually with oneapi variable setting script
3334
COPY --chown=1001:0 ${SOURCE_CODE}/start-notebook.sh /opt/app-root/bin
3435
COPY --chown=1001:0 ${SOURCE_CODE}/builder /opt/app-root/builder
35-
COPY --chown=1001:0 ${SOURCE_CODE}/utils /opt/app-root/bin/utils
36+
COPY --chown=1001:0 ${REUSABLE_UTILS} /opt/app-root/bin/utils
3637

3738
# Apply JupyterLab addons
3839
RUN /opt/app-root/bin/utils/addons/apply.sh

jupyter/intel/pytorch/ubi9-python-3.11/Dockerfile

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
ARG BASE_IMAGE
22
FROM ${BASE_IMAGE}
33

4+
ARG REUSABLE_UTILS=jupyter/utils
45
ARG SOURCE_CODE=jupyter/intel/pytorch/ubi9-python-3.11
56

67
LABEL name="odh-notebook-jupyter-intel-pytorch-ubi9-python-3.11" \
@@ -47,7 +48,7 @@ COPY --chown=1001:0 ${SOURCE_CODE}/start-kernel /opt/app-root/bin/start-kernel
4748
COPY --chown=1001:0 ${SOURCE_CODE}/kernel-gpu.json /opt/app-root/share/jupyter/kernels/python3/kernel.json
4849
COPY --chown=1001:0 ${SOURCE_CODE}/start-notebook.sh /opt/app-root/bin
4950
COPY --chown=1001:0 ${SOURCE_CODE}/builder /opt/app-root/builder
50-
COPY --chown=1001:0 ${SOURCE_CODE}/utils /opt/app-root/bin/utils
51+
COPY --chown=1001:0 ${REUSABLE_UTILS} /opt/app-root/bin/utils
5152

5253
#CPU env
5354
ENV CPU_ENV=/opt/app-root-cpu

jupyter/intel/pytorch/ubi9-python-3.11/utils/addons/apply.sh

Lines changed: 0 additions & 40 deletions
This file was deleted.

jupyter/intel/pytorch/ubi9-python-3.11/utils/addons/partial-body.html

Lines changed: 0 additions & 23 deletions
This file was deleted.

jupyter/intel/pytorch/ubi9-python-3.11/utils/addons/partial-head.html

Lines changed: 0 additions & 14 deletions
This file was deleted.

jupyter/intel/pytorch/ubi9-python-3.11/utils/process.sh

Lines changed: 0 additions & 19 deletions
This file was deleted.

jupyter/intel/pytorch/ubi9-python-3.9/Dockerfile

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
ARG BASE_IMAGE
22
FROM ${BASE_IMAGE}
33

4+
ARG REUSABLE_UTILS=jupyter/utils
45
ARG SOURCE_CODE=jupyter/intel/pytorch/ubi9-python-3.9
56

67
LABEL name="odh-notebook-jupyter-intel-pytorch-ubi9-python-3.9" \
@@ -46,7 +47,7 @@ COPY --chown=1001:0 ${SOURCE_CODE}/start-kernel /opt/app-root/bin/start-kernel
4647
COPY --chown=1001:0 ${SOURCE_CODE}/kernel-gpu.json /opt/app-root/share/jupyter/kernels/python3/kernel.json
4748
COPY --chown=1001:0 ${SOURCE_CODE}/start-notebook.sh /opt/app-root/bin
4849
COPY --chown=1001:0 ${SOURCE_CODE}/builder /opt/app-root/builder
49-
COPY --chown=1001:0 ${SOURCE_CODE}/utils /opt/app-root/bin/utils
50+
COPY --chown=1001:0 ${REUSABLE_UTILS} /opt/app-root/bin/utils
5051

5152
#CPU env
5253
ENV CPU_ENV=/opt/app-root-cpu

jupyter/intel/pytorch/ubi9-python-3.9/utils/addons/apply.sh

Lines changed: 0 additions & 40 deletions
This file was deleted.

jupyter/intel/pytorch/ubi9-python-3.9/utils/addons/partial-body.html

Lines changed: 0 additions & 23 deletions
This file was deleted.

jupyter/intel/pytorch/ubi9-python-3.9/utils/addons/partial-head.html

Lines changed: 0 additions & 14 deletions
This file was deleted.

jupyter/intel/pytorch/ubi9-python-3.9/utils/process.sh

Lines changed: 0 additions & 19 deletions
This file was deleted.

jupyter/intel/tensorflow/ubi9-python-3.11/Dockerfile

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
ARG BASE_IMAGE
22
FROM ${BASE_IMAGE}
33

4+
ARG REUSABLE_UTILS=jupyter/utils
45
ARG SOURCE_CODE=jupyter/intel/tensorflow/ubi9-python-3.11
56

67
LABEL name="odh-notebook-jupyter-intel-tensorflow-ubi9-python-3.11" \
@@ -48,7 +49,7 @@ COPY --chown=1001:0 ${SOURCE_CODE}/start-kernel /opt/app-root/bin/start-kernel
4849
COPY --chown=1001:0 ${SOURCE_CODE}/kernel-gpu.json /opt/app-root/share/jupyter/kernels/python3/kernel.json
4950
COPY --chown=1001:0 ${SOURCE_CODE}/start-notebook.sh /opt/app-root/bin
5051
COPY --chown=1001:0 ${SOURCE_CODE}/builder /opt/app-root/builder
51-
COPY --chown=1001:0 ${SOURCE_CODE}/utils /opt/app-root/bin/utils
52+
COPY --chown=1001:0 ${REUSABLE_UTILS} /opt/app-root/bin/utils
5253

5354
#CPU env
5455
ENV CPU_ENV=/opt/app-root-cpu

jupyter/intel/tensorflow/ubi9-python-3.11/utils/addons/apply.sh

Lines changed: 0 additions & 40 deletions
This file was deleted.

jupyter/intel/tensorflow/ubi9-python-3.11/utils/addons/partial-body.html

Lines changed: 0 additions & 23 deletions
This file was deleted.

jupyter/intel/tensorflow/ubi9-python-3.11/utils/addons/partial-head.html

Lines changed: 0 additions & 14 deletions
This file was deleted.

jupyter/intel/tensorflow/ubi9-python-3.11/utils/process.sh

Lines changed: 0 additions & 19 deletions
This file was deleted.

0 commit comments

Comments
 (0)