Skip to content

Commit c90f9a4

Browse files
d4l3kfacebook-github-bot
authored andcommitted
torchx: clean up Local scheduler + documentation (pytorch#555)
Summary: Pull Request resolved: pytorch#555 This contains some documentation updates/cleanups. For `runopts` it switches all of the schedulers to use the create_scheduler methods for doc generation instead of bypassing the initialization which can cause issues with inheritance. Reviewed By: priyaramani Differential Revision: D37834482 fbshipit-source-id: 5ead1e4dbb87f69b1b3ea7f649e8299bcda0dbfb
1 parent 2aefdee commit c90f9a4

8 files changed

+9
-7
lines changed

docs/source/ext/runopts.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,9 @@ def run(self):
2121
raw_content = "\n".join(self.content)
2222
args = yaml.safe_load(raw_content)
2323
cls = locate(args["class"])
24+
scheduler = cls("docs")
2425

25-
body = nodes.literal_block(text=str(cls.run_opts(None)))
26+
body = nodes.literal_block(text=str(scheduler.run_opts()))
2627
return [
2728
body,
2829
]

docs/source/workspace.rst

+1
Original file line numberDiff line numberDiff line change
@@ -42,3 +42,4 @@ torchx.workspace.dir_workspace
4242

4343
.. autoclass:: JetterWorkspace
4444
:members:
45+
:show-inheritance:

torchx/schedulers/aws_batch_scheduler.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -263,7 +263,7 @@ class AWSBatchScheduler(Scheduler[AWSBatchOpts], DockerWorkspace):
263263
**Config Options**
264264
265265
.. runopts::
266-
class: torchx.schedulers.aws_batch_scheduler.AWSBatchScheduler
266+
class: torchx.schedulers.aws_batch_scheduler.create_scheduler
267267
268268
**Mounts**
269269

torchx/schedulers/docker_scheduler.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ class DockerScheduler(Scheduler[DockerOpts], DockerWorkspace):
115115
**Config Options**
116116
117117
.. runopts::
118-
class: torchx.schedulers.docker_scheduler.DockerScheduler
118+
class: torchx.schedulers.docker_scheduler.create_scheduler
119119
120120
**Mounts**
121121

torchx/schedulers/kubernetes_scheduler.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -473,7 +473,7 @@ class KubernetesScheduler(Scheduler[KubernetesOpts], DockerWorkspace):
473473
**Config Options**
474474
475475
.. runopts::
476-
class: torchx.schedulers.kubernetes_scheduler.KubernetesScheduler
476+
class: torchx.schedulers.kubernetes_scheduler.create_scheduler
477477
478478
**Mounts**
479479

torchx/schedulers/local_scheduler.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -527,7 +527,7 @@ class LocalScheduler(Scheduler[LocalOpts]):
527527
**Config Options**
528528
529529
.. runopts::
530-
class: torchx.schedulers.local_scheduler.LocalScheduler
530+
class: torchx.schedulers.local_scheduler.create_scheduler
531531
532532
**Compatibility**
533533

torchx/schedulers/ray_scheduler.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ class RayScheduler(Scheduler[RayOpts], TmpDirWorkspace):
126126
**Config Options**
127127
128128
.. runopts::
129-
class: torchx.schedulers.ray_scheduler.RayScheduler
129+
class: torchx.schedulers.ray_scheduler.create_scheduler
130130
131131
**Compatibility**
132132

torchx/schedulers/slurm_scheduler.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -289,7 +289,7 @@ class SlurmScheduler(Scheduler[SlurmOpts], DirWorkspace):
289289
**Config Options**
290290
291291
.. runopts::
292-
class: torchx.schedulers.slurm_scheduler.SlurmScheduler
292+
class: torchx.schedulers.slurm_scheduler.create_scheduler
293293
294294
**Compatibility**
295295

0 commit comments

Comments
 (0)