Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We should move the stopwords and dictionary files #322

Closed
martindholmes opened this issue Oct 18, 2024 · 4 comments
Closed

We should move the stopwords and dictionary files #322

martindholmes opened this issue Oct 18, 2024 · 4 comments
Assignees
@martindholmes
Labels
enhancement New feature or request fix committed A fix has been made, so if no problems emerge the issue can be closed.
Milestone
Release 2.0

Comments

@martindholmes
Copy link
Collaborator

...into their own folder, maybe called "dict".
@martindholmes martindholmes added the enhancement New feature or request label Oct 18, 2024
@martindholmes martindholmes added this to the Release 2.0 milestone Oct 18, 2024
@martindholmes martindholmes self-assigned this Dec 31, 2024
@martindholmes
Copy link
Collaborator Author

Should they be in subfolders by language?

@martindholmes
Copy link
Collaborator Author

martindholmes commented Feb 20, 2025 •
edited
Loading

Today we decided on a folder called stopwords and one called dicts, with the files inside just differentiated by name. Then change the default values in the ODD file.

@martindholmes
Copy link
Collaborator Author

Working on this in branch issue-322-move-files.

martindholmes added a commit that referenced this issue Feb 23, 2025
@martindholmes
Initial work on issue #322 (moving stopwords and dictionary files). T…
e9bbb94 
…his will require a further update to the conversion script once merged into dev.
martindholmes added a commit that referenced this issue Feb 23, 2025
@martindholmes
Further updates to existing config files for issue #322.
1ce388a
@martindholmes
Copy link
Collaborator Author

Initial work and updates to config files completed in commit 1ce388a. I'll raise a PR, and then we should come back to this ticket to ensure that the config v1-v2 conversion is appropriately updated.

@martindholmes martindholmes added the fix committed A fix has been made, so if no problems emerge the issue can be closed. label Feb 24, 2025
joeytakeda added a commit that referenced this issue Mar 6, 2025
@joeytakeda
For #322, add warning for default stopwords and dictionaries
8639437
joeytakeda added a commit that referenced this issue Mar 6, 2025
@joeytakeda
For #322, better warnings and add comments to converted file
aa82ef1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martindholmes martindholmes

Labels
enhancement New feature or request fix committed A fix has been made, so if no problems emerge the issue can be closed.
Projects
None yet
Milestone
Release 2.0
Development

No branches or pull requests
1 participant
@martindholmes