Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provider Notion #470

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from
Open

Conversation

persona-twotwo
Copy link

@persona-twotwo persona-twotwo commented Feb 6, 2025

Hello ProjectDiscovery,

I’d like to submit this Pull Request to add a Notion Provider to the notify project. Notion is an all-in-one workspace that allows teams to write, plan, collaborate, and organize tasks efficiently. This integration will enable users to receive notifications directly within their Notion workspace, thereby enhancing team collaboration and project management.

Key changes:

  • Added support for sending notifications via Notion using its API.
  • Implemented necessary configurations and error handling to ensure smooth operation.
  • Updated documentation to reflect the new provider.

Configuration Notes:

  • The configuration includes an optional parameter:

    notion_in_page_title: "${notion_in_page_title}" # optional

    Note: If a value is provided for notion_in_page_title, the created page will have that value as its title. If no value is provided, the page title will default to the content of the message.

Please let me know if there’s anything I can improve or if you have any feedback. I’m happy to make any necessary adjustments.

Thank you for your time and consideration!

Screenshot 2025-02-06 at 6 28 14 PM Screenshot 2025-02-06 at 6 28 30 PM Screenshot 2025-02-06 at 6 12 12 PM

Closes #474

@GeorginaReeder
Copy link

Thanks for your contribution @persona-twotwo ! :)

@persona-twotwo
Copy link
Author

I think the Build Test issue is occurring because the Notion API and Notion Database ID are missing. Could you add the Notion API and Database ID and run the test again?

Also, I noticed that tests unrelated to Notion are running as well. Should I have disabled them in advance?

@ehsandeep
Copy link
Member

@persona-twotwo this looks great, thanks for the PR, let us take a review at PR and update you back.

@ehsandeep ehsandeep changed the base branch from main to dev February 9, 2025 10:31
Copy link
Member

@dogancanbakir dogancanbakir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

pkg/providers/notion/notion_api.go Outdated Show resolved Hide resolved
pkg/providers/notion/notion_api.go Outdated Show resolved Hide resolved
@dogancanbakir dogancanbakir linked an issue Feb 11, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add notion
5 participants