probe: clean-up database connection after probe to prevent connection leak

Signed-off-by: Kurtis Bass <[email protected]>

Author: kjbass

cmd/postgres_exporter/probe.go

@@ -104,6 +104,9 @@ func handleProbe(logger log.Logger) http.HandlerFunc {
 			return
 		}
 
+		// Cleanup underlying connections to prevent connection leaks
+		defer pc.Close()
+
 		// TODO(@sysadmind): Remove the registry.MustRegister() call below and instead handle the collection here. That will allow
 		// for the passing of context, handling of timeouts, and more control over the collection.
 		// The current NewProbeCollector() implementation relies on the MustNewConstMetric() call to create the metrics which is not

collector/probe.go

@@ -83,3 +83,7 @@ func (pc *ProbeCollector) Collect(ch chan<- prometheus.Metric) {
 	}
 	wg.Wait()
 }
+
+func (pc *ProbeCollector) Close() error {
+	return pc.db.Close()
+}