This repository was archived by the owner on May 16, 2025. It is now read-only.
Fix JS API client #96
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 23, 2024
ristomcgehee
force-pushed
the
fix-js-api-client
branch
from
e90e642 to
d674b44
Compare
Contributor
Author
|
@seanpmorgan friendly bump |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized that in #90, I left the
javascript-sdkin a state where it doesn't compile. My reasoning for not includingjavascript-sdk/src/api.tsin that PR was because the server API had not been updated yet, so the interface would be wrong if I included these changes inapi.ts. I forgot to take into account that the types wouldn't match and would cause a compile error. I'm including those changes now because I think it's better to have the API client not match than to have the whole project not compile. Really I just need to stop submitting breaking changes 😬I also added
npm run buildto the CI checks to prevent this sort of thing in the future.