Skip to content

Commit d505642

Browse files
committed
Fix dupe linker opt, add TODO for Docker builds
Signed-off-by: Martijn Stevenson <[email protected]>
1 parent 668c5f3 commit d505642

File tree

2 files changed

+1
-1
lines changed

2 files changed

+1
-1
lines changed

Diff for: bazel/defs.bzl

-1
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,6 @@ def proxy_wasm_cc_binary(
9595
linkopts = linkopts + [
9696
"--no-entry",
9797
"--js-library=$(location @proxy_wasm_cpp_sdk//:proxy_wasm_intrinsics_js)",
98-
"-sSTANDALONE_WASM",
9998
"-sEXPORTED_FUNCTIONS=_malloc",
10099
],
101100
tags = tags + [

Diff for: sdk_container.sh

+1
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,7 @@ rm -rf protobuf-wasm
8181
git clone https://github.com/abseil/abseil-cpp
8282
cd abseil-cpp
8383
git checkout 4447c7562e3bc702ade25105912dce503f0c4010 -b lts20240722 # Abseil LTS release 20240722.0
84+
# TODO -DSTANDALONE_WASM -sSTANDALONE_WASM ?
8485
emcmake cmake -DCMAKE_CXX_STANDARD=17 "."
8586
emmake make -j $JOBS
8687
cd

0 commit comments

Comments
 (0)