Compilation Error After Updating Library

[BnWong]

After updating the "arduino-audio-tools" library, a number of arduino programs that would normally compile don't anymore. One common use case that I like to implement is to organize the byte arrays data structures into MemoryStream array for easy lookup and playback of audio tracks. As an example of my problem, here is the example code provided for reading a byte stream on the flash memory:

/**
 * @file streams-memory_raw-i2s.ino
 * @author Phil Schatzmann
 * @brief Compile with Partition Scheme Hughe APP!
 * @version 0.1
 * @date 2021-01-24
 * 
 * @copyright Copyright (c) 2021
 * 
 */
#include "AudioTools.h"
#include "StarWars30.h"

AudioInfo info(22050, 1, 16);
I2SStream i2s;  // Output to I2S

//MemoryStream music(StarWars30_raw, StarWars30_raw_len);

MemoryStream musicArray[] = {(StarWars30_raw, StarWars30_raw_len),(StarWars30_raw, StarWars30_raw_len)};
StreamCopy copier(i2s, music); // copies sound into i2s

void setup(){
    Serial.begin(115200);
    AudioLogger::instance().begin(Serial, AudioLogger::Info);

    auto config = i2s.defaultConfig(TX_MODE);
    config.copyFrom(info);
    i2s.begin(config);
}

void loop(){
    if (!copier.copy()){
      i2s.end();
      stop();
    }
}

When I attempt to compile this code with the musicArray data structure instead of the original music MemoryStream object, here is the error output:

streams-memory_raw-i2s:18:103: error: use of deleted function 'audio_tools::MemoryStream::MemoryStream(const audio_tools::MemoryStream&)'

 MemoryStream musicArray[] = {(StarWars30_raw, StarWars30_raw_len),(StarWars30_raw, StarWars30_raw_len)};

                                                                                                       ^

In file included from C:\Arduino\libraries\arduino-audio-tools-main\src/AudioFilter/Equilizer.h:4:0,

                 from C:\Arduino\libraries\arduino-audio-tools-main\src/AudioTools.h:70,

                 from C:\Users\ESCAPE~1\AppData\Local\Temp\arduino_modified_sketch_951230\streams-memory_raw-i2s.ino:11:

Arduino\libraries\arduino-audio-tools-main\src/AudioTools/AudioStreams.h:200:7: note: 'audio_tools::MemoryStream::MemoryStream(const audio_tools::MemoryStream&)' is implicitly deleted because the default definition would be ill-formed:

 class MemoryStream : public AudioStream {

       ^

Arduino\libraries\arduino-audio-tools-main\src/AudioTools/AudioStreams.h:200:7: error: use of deleted function 'audio_tools::AudioStream::AudioStream(const audio_tools::AudioStream&)'

Arduino\libraries\arduino-audio-tools-main\src/AudioTools/AudioStreams.h:44:3: note: declared here

   AudioStream(AudioStream const&) = delete;

   ^

\arduino-audio-tools-main\src/AudioTools/AudioStreams.h:203:3: note:   after user-defined conversion: audio_tools::MemoryStream::MemoryStream(int, audio_tools::MemoryType)

   MemoryStream(int buffer_size = 512, MemoryType memoryType = RAM) {

   ^

streams-memory_raw-i2s:18:103: error: use of deleted function 'audio_tools::MemoryStream::MemoryStream(const audio_tools::MemoryStream&)'

 MemoryStream musicArray[] = {(StarWars30_raw, StarWars30_raw_len),(StarWars30_raw, StarWars30_raw_len)};

                                                                                                       ^

In file included from C:\Arduino\libraries\arduino-audio-tools-main\src/AudioFilter/Equilizer.h:4:0,

                 from C:\Arduino\libraries\arduino-audio-tools-main\src/AudioTools.h:70,

                 from C:\Users\ESCAPE~1\AppData\Local\Temp\arduino_modified_sketch_951230\streams-memory_raw-i2s.ino:11:

C:\Arduino\libraries\arduino-audio-tools-main\src/AudioTools/AudioStreams.h:203:3: note:   after user-defined conversion: audio_tools::MemoryStream::MemoryStream(int, audio_tools::MemoryType)

   MemoryStream(int buffer_size = 512, MemoryType memoryType = RAM) {

   ^

exit status 1
use of deleted function 'audio_tools::MemoryStream::MemoryStream(const audio_tools::MemoryStream&)'

Is there something that would need to be changed to adapt my code around the library updates? If that isn't the case would there be another way to organize MemoryStream data structures into a sort-of "lookup table"? Thank you in advance, this library has been super helpful in easily adding audio to ESP32 projects.

[pschatzmann]

I committed a correction. I removed the copy and move constructors because there was a risk of some inconsistent memory and I thought it would not be needed. I have added the proper implementations now that should cover the different cases..

[BnWong]

Thank you for code addendums to cover this particular use case!

[BnWong]

Sorry to revive the thread, but after updating the library the code does compile, but now it seems to throw an error if I wrap a memorystream in an array. This fragment will not throw a runtime error :

MemoryStream mp3(englishBriefingAudio, englishBriefingAudioLength);
I2SStream i2s;  
MP3DecoderHelix helix;
EncodedAudioStream out(&i2s, &helix); // output to decoder
StreamCopy copier(out, mp3);    // copy in to i2s

vs. this toy example for wrapping a MemoryStream in an array:

MemoryStream musicArray[] = {(englishBriefingAudio, englishBriefingAudioLength)};
I2SStream i2s;  
MP3DecoderHelix helix;
EncodedAudioStream out(&i2s, &helix); // output to decoder
StreamCopy copier(out, musicArray[0]);    // copy in to i2s

When I upload the code to an actual esp32, it seems to throw a particular error:

Rebooting...
ets Jul 29 2019 12:21:46

rst:0xc (SW_CPU_RESET),boot:0x13 (SPI_FAST_FLASH_BOOT)
configsip: 0, SPIWP:0xee
clk_drv:0x00,q_drv:0x00,d_drv:0x00,cs0_drv:0x00,hd_drv:0x00,wp_drv:0x00
mode:DIO, clock div:1
load:0x3fff0018,len:4
load:0x3fff001c,len:1216
ho 0 tail 12 room 4
load:0x40078000,len:10944
load:0x40080400,len:6388
entry 0x400806b4
assertion "buffer!=nullptr" failed: file "C:\Arduino\libraries\arduino-audio-tools-main\src/AudioTools/AudioStreams.h", line 381, function: virtual void audio_tools::MemoryStream::resize(size_t)
abort() was called at PC 0x400dc5f3 on core 0

ELF file SHA256: 0000000000000000

Backtrace: 0x400851d0:0x3ffe3b00 0x4008544d:0x3ffe3b20 0x400dc5f3:0x3ffe3b40 0x400d1d72:0x3ffe3b70 0x400d54cd:0x3ffe3b90 0x400ef74f:0x3ffe3bb0 0x400820d1:0x3ffe3bd0 0x40082300:0x3ffe3c20 0x4007925f:0x3ffe3c40 0x400792c5:0x3ffe3c70 0x400792d0:0x3ffe3ca0 0x4007947d:0x3ffe3cc0 0x400806e6:0x3ffe3df0 0x40007c15:0x3ffe3eb0 0x4000073d:0x3ffe3f20

Would this have something to do with the copying of the bytearray?

[pschatzmann]

I think it needs to be MemoryStream musicArray[] = {MemoryStream(englishBriefingAudio, englishBriefingAudioLength)};
Otherwise a wrong constructor is used. I removed the default settings, so that you get an compile error for this case