Skip to content

Commit eac7d86

Browse files
committed
Merge branch 'cuongtranba-ReviewStringBuilder'
2 parents 05de12c + a74069c commit eac7d86

File tree

1 file changed

+13
-15
lines changed

1 file changed

+13
-15
lines changed

VerbalExpressions/VerbalExpressions.cs

+13-15
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,9 @@ public static VerbalExpressions DefaultExpression
3636

3737
#region Private Members
3838

39-
private string _prefixes = "";
40-
private string _source = "";
41-
private string _suffixes = "";
39+
private StringBuilder _prefixes = new StringBuilder();
40+
private StringBuilder _source = new StringBuilder();
41+
private StringBuilder _suffixes = new StringBuilder();
4242
private RegexOptions _modifiers = RegexOptions.Multiline;
4343

4444
#endregion Private Members
@@ -47,7 +47,7 @@ public static VerbalExpressions DefaultExpression
4747

4848
private string RegexString
4949
{
50-
get { return _prefixes + _source + _suffixes; }
50+
get { return new StringBuilder().Append(_prefixes).Append(_source).Append(_suffixes).ToString();}
5151
}
5252

5353
private Regex PatternRegex
@@ -108,7 +108,7 @@ public string Capture(string toTest, string groupName)
108108
if (!Test(toTest))
109109
return null;
110110

111-
var match=PatternRegex.Match(toTest);
111+
var match = PatternRegex.Match(toTest);
112112
return match.Groups[groupName].Value;
113113
}
114114

@@ -137,19 +137,19 @@ public VerbalExpressions Add(string value, bool sanitize = true)
137137
throw new ArgumentNullException("value must be provided");
138138

139139
value = sanitize ? Sanitize(value) : value;
140-
_source += value;
140+
_source.Append(value);
141141
return this;
142142
}
143143

144144
public VerbalExpressions StartOfLine(bool enable = true)
145145
{
146-
_prefixes = enable ? "^" : string.Empty;
146+
_prefixes.Append(enable ? "^" : String.Empty);
147147
return this;
148148
}
149149

150150
public VerbalExpressions EndOfLine(bool enable = true)
151151
{
152-
_suffixes = enable ? "$" : string.Empty;
152+
_suffixes.Append(enable ? "$" : String.Empty);
153153
return this;
154154
}
155155

@@ -341,11 +341,9 @@ public VerbalExpressions Or(CommonRegex commonRegex)
341341

342342
public VerbalExpressions Or(string value, bool sanitize = true)
343343
{
344-
_prefixes += "(";
345-
_suffixes = ")" + _suffixes;
346-
347-
_source += ")|(";
348-
344+
_prefixes.Append("(");
345+
_suffixes.Insert(0, ")");
346+
_source.Append(")|(");
349347
return Add(value, sanitize);
350348
}
351349

@@ -356,7 +354,7 @@ public VerbalExpressions BeginCapture()
356354

357355
public VerbalExpressions BeginCapture(string groupName)
358356
{
359-
return Add("(?<", false).Add(groupName,true).Add(">",false);
357+
return Add("(?<", false).Add(groupName, true).Add(">", false);
360358
}
361359

362360
public VerbalExpressions EndCapture()
@@ -457,6 +455,6 @@ public VerbalExpressions WithOptions(RegexOptions options)
457455

458456
#endregion Public Methods
459457

460-
458+
461459
}
462460
}

0 commit comments

Comments
 (0)