Confusing message in interactive roll tool when no state change required #1521
Description
There is a bug in interactive_update_roll_status(). Sometimes you get a confusing message that you have changed status, when you have not:
2025-04-25 09:45:39 DEBUG Interactive_Update-Roll-Status Running report Roll report sysproduction.reporting.roll_report.roll_report console {'instrument_code': 'SUGAR11', 'reporting_api': <sysproduction.reporting.api.reportingApi object at 0x7f2ca1051ea0>}
********************************************************************************
Roll report produced on 25/04/2025 09:45
********************************************************************************
===============================================================================================================================================
Status and time to roll in days
===============================================================================================================================================
status roll_expiry price_expiry carry_expiry contract_priced contract_fwd position_priced relative_volume_fwd contract_volume_fwd
SUGAR11 Force 5 65 4 20250700 20251000 -2.0 0.207 6118
Roll_exp is days until preferred roll set by roll parameters. Prc_exp is days until price contract expires, Crry_exp is days until carry contract expires
Contract suffix: p=price, f=forward, c=carry
Contract volumes over recent days, normalised so largest volume is 1.0
********************************************************************************
END OF REPORT
********************************************************************************
Have to input roll state (recommend Force, Force_Outright or Close)
0: Force
1: Force_Outright
2: Passive
3: No_Roll
4: Close
5: No_Open
Your choice? <RETURN for No_Roll> 0
No change
*********************************************************************************
Automatically changing state from RollState.Force to No roll required for SUGAR11
*********************************************************************************
That last line should instead say:
*********************************************************************************
Roll status already set to RollState.Force for SUGAR11: not changing
*********************************************************************************