From 0e4562a8cf1d9b6f45a2c926bb7f7a4d6c9725e7 Mon Sep 17 00:00:00 2001 From: Severin Buhler Date: Thu, 16 Jan 2025 16:31:59 +0100 Subject: [PATCH] ignore ipv6 tests --- .../external_ip/providers/external_ip_resolver.rs | 6 +----- cli/src/external_ip/providers/icanhazip.rs | 10 +++------- cli/src/external_ip/providers/identme.rs | 10 +++------- cli/src/external_ip/providers/ipifyorg.rs | 10 +++------- cli/src/external_ip/providers/ipinfoio.rs | 12 ++++-------- cli/src/external_ip/providers/myip.rs | 12 ++++-------- cli/src/external_ip/resolver.rs | 1 + 7 files changed, 19 insertions(+), 42 deletions(-) diff --git a/cli/src/external_ip/providers/external_ip_resolver.rs b/cli/src/external_ip/providers/external_ip_resolver.rs index ba4c3de..67b5112 100644 --- a/cli/src/external_ip/providers/external_ip_resolver.rs +++ b/cli/src/external_ip/providers/external_ip_resolver.rs @@ -1,6 +1,6 @@ use std::{ future::Future, - net::{AddrParseError, Ipv4Addr, Ipv6Addr, TcpListener}, + net::{AddrParseError, Ipv4Addr, Ipv6Addr}, pin::Pin, }; @@ -60,7 +60,3 @@ pub async fn resolve_ipv6_with_url(url: T) -> Result bool { - TcpListener::bind("[::1]:0").is_ok() -} diff --git a/cli/src/external_ip/providers/icanhazip.rs b/cli/src/external_ip/providers/icanhazip.rs index 9ac6a7a..28111d7 100644 --- a/cli/src/external_ip/providers/icanhazip.rs +++ b/cli/src/external_ip/providers/icanhazip.rs @@ -22,8 +22,6 @@ pub fn get_resolver() -> ProviderResolver { #[cfg(test)] mod tests { - use crate::external_ip::providers::external_ip_resolver::is_ipv6_available; - use super::*; #[tokio::test] @@ -32,12 +30,10 @@ mod tests { assert!(ip.is_ok()); } + #[ignore = "Github runners don't support ipv6 request."] #[tokio::test] async fn test_ipv6() { - if is_ipv6_available() { - // Only run test if ipv6 is available on this system. - let ip = resolve_ipv6().await; - assert!(ip.is_ok()); - } + let ip = resolve_ipv6().await; + assert!(ip.is_ok()); } } diff --git a/cli/src/external_ip/providers/identme.rs b/cli/src/external_ip/providers/identme.rs index dd361c7..ec5946a 100644 --- a/cli/src/external_ip/providers/identme.rs +++ b/cli/src/external_ip/providers/identme.rs @@ -22,8 +22,6 @@ pub fn get_resolver() -> ProviderResolver { #[cfg(test)] mod tests { - use crate::external_ip::providers::external_ip_resolver::is_ipv6_available; - use super::*; #[tokio::test] @@ -32,12 +30,10 @@ mod tests { assert!(ip.is_ok()); } + #[ignore = "Github runners don't support ipv6 request."] #[tokio::test] async fn test_ipv6() { - if is_ipv6_available() { - // Only run test if ipv6 is available on this system. - let ip = resolve_ipv6().await; - assert!(ip.is_ok()); - } + let ip = resolve_ipv6().await; + assert!(ip.is_ok()); } } diff --git a/cli/src/external_ip/providers/ipifyorg.rs b/cli/src/external_ip/providers/ipifyorg.rs index 2124544..b219681 100644 --- a/cli/src/external_ip/providers/ipifyorg.rs +++ b/cli/src/external_ip/providers/ipifyorg.rs @@ -22,8 +22,6 @@ pub fn get_resolver() -> ProviderResolver { #[cfg(test)] mod tests { - use crate::external_ip::providers::external_ip_resolver::is_ipv6_available; - use super::*; #[tokio::test] @@ -32,12 +30,10 @@ mod tests { assert!(ip.is_ok()); } + #[ignore = "Github runners don't support ipv6 request."] #[tokio::test] async fn test_ipv6() { - if is_ipv6_available() { - // Only run test if ipv6 is available on this system. - let ip = resolve_ipv6().await; - assert!(ip.is_ok()); - } + let ip = resolve_ipv6().await; + assert!(ip.is_ok()); } } diff --git a/cli/src/external_ip/providers/ipinfoio.rs b/cli/src/external_ip/providers/ipinfoio.rs index a7ad3e8..379a09d 100644 --- a/cli/src/external_ip/providers/ipinfoio.rs +++ b/cli/src/external_ip/providers/ipinfoio.rs @@ -33,22 +33,18 @@ pub fn get_resolver() -> ProviderResolver { #[cfg(test)] mod tests { - use crate::external_ip::providers::external_ip_resolver::is_ipv6_available; - use super::*; #[tokio::test] async fn test_ipv4() { let ip = resolve_ipv4().await; - ip.expect("Valid ipv4"); + assert!(ip.is_ok()); } + #[ignore = "Github runners don't support ipv6 request."] #[tokio::test] async fn test_ipv6() { - if is_ipv6_available() { - // Only run test if ipv6 is available on this system. - let ip = resolve_ipv6().await; - assert!(ip.is_ok()); - } + let ip = resolve_ipv6().await; + assert!(ip.is_ok()); } } diff --git a/cli/src/external_ip/providers/myip.rs b/cli/src/external_ip/providers/myip.rs index 0dbde09..638dabf 100644 --- a/cli/src/external_ip/providers/myip.rs +++ b/cli/src/external_ip/providers/myip.rs @@ -33,22 +33,18 @@ pub fn get_resolver() -> ProviderResolver { #[cfg(test)] mod tests { - use crate::external_ip::providers::external_ip_resolver::is_ipv6_available; - use super::*; #[tokio::test] async fn test_ipv4() { let ip = resolve_ipv4().await; - ip.expect("Valid ipv4"); + assert!(ip.is_ok()); } + #[ignore = "Github runners don't support ipv6 request."] #[tokio::test] async fn test_ipv6() { - if is_ipv6_available() { - // Only run test if ipv6 is available on this system. - let ip = resolve_ipv6().await; - assert!(ip.is_ok()); - } + let ip = resolve_ipv6().await; + assert!(ip.is_ok()); } } diff --git a/cli/src/external_ip/resolver.rs b/cli/src/external_ip/resolver.rs index 5837633..5c41544 100644 --- a/cli/src/external_ip/resolver.rs +++ b/cli/src/external_ip/resolver.rs @@ -65,6 +65,7 @@ mod tests { println!("{:?}", ip.expect("Valid ipv4")); } + #[ignore = "Github runners don't support ipv6 request."] #[tokio::test] async fn test_ipv6() { let ip = resolve_ipv6().await;