Skip to content

Commit e06d75a

Browse files
committed
Update CI files
1 parent f016fb4 commit e06d75a

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

Diff for: .ci/scripts/validate_commit_message.py

+7-2
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,8 @@
2424
r"^DO\s*NOT\s*MERGE",
2525
r"^EXPERIMENT",
2626
r"^FIXUP",
27-
r"Apply suggestions from code review",
27+
r"^fixup!", # This is created by 'git commit --fixup'
28+
r"Apply suggestions from code review", # This usually comes from GitHub
2829
]
2930
try:
3031
CHANGELOG_EXTS = [
@@ -40,7 +41,11 @@
4041
if NOISSUE_MARKER in message:
4142
sys.exit(f"Do not add '{NOISSUE_MARKER}' in the commit message.")
4243

43-
if any((re.match(pattern, message, re.IGNORECASE) for pattern in BLOCKING_REGEX)):
44+
blocking_matches = [m for m in (re.match(pattern, message) for pattern in BLOCKING_REGEX) if m]
45+
if blocking_matches:
46+
print("Found these phrases in the commit message:")
47+
for m in blocking_matches:
48+
print(" - " + m.group(0))
4449
sys.exit("This PR is not ready for consumption.")
4550

4651
g = Github(os.environ.get("GITHUB_TOKEN"))

Diff for: .github/template_gitref

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
2021.08.26-420-gf332a34
1+
2021.08.26-421-g204a709

0 commit comments

Comments
 (0)