Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect mappings for Loadbalancing and BGP VPN resources #690

Open
ederst opened this issue Oct 2, 2024 · 3 comments · May be fixed by #692
Open

Incorrect mappings for Loadbalancing and BGP VPN resources #690

ederst opened this issue Oct 2, 2024 · 3 comments · May be fixed by #692
Assignees
@VenelinMartinov
Labels
kind/bug Some behavior is incorrect or out of spec

Comments

@ederst
Copy link
Contributor

ederst commented Oct 2, 2024 •
edited
Loading

Describe what happened

After upgrading to pulumi-openstack v5.0.0 loadbalancer.Loadbalancer is not available anymore. Instead the resource seems to have been replaced with LbLoadbalancerV2. The crux here is that this resource is mapped at index and not in the loadbalancer module/package - like for example loadbalancer.L7PolicyV2.

This seems to be true for multiple resources - see "Affected Resource(s)".

To fix this, the resources need a proper mapping in resources.go. For example like this, I guess:

"openstack_lb_loadbalancer_v2": {
	Tok: openstackResource(lbMod, "LoadbalancerV2"),
	Docs: &tfbridge.DocInfo{
		AllowMissing: true,
	},
},

Sample program

import pulumi_openstack as openstack

openstack.loadbalancer.Loadbalancer(...) # does not work anymore
openstack.LbLoadbalancerV2(...) # works

Log output

No response

Affected Resource(s)

openstack.LbLoadbalancerV2
openstack.LbFlavorprofileV2
openstack.BgpvpnV2
openstack.BgpvpnNetworkAssociateV2
openstack.BgpvpnPortAssociateV2
openstack.BgpvpnRouterAssociateV2

Output of pulumi about

Running /$HOME/.pulumi/3.135.0/pulumi/pulumi about
CLI
Version      3.135.0
Go Version   go1.23.1
Go Compiler  gc

Plugins
KIND      NAME        VERSION
resource  aws         6.54.1
resource  kubernetes  4.18.1
resource  openstack   5.0.0
language  python      unknown
resource  random      4.16.5
resource  tls         5.0.7

Host
OS       darwin
Version  15.0
Arch     arm64

This project is written in python: executable='$PROJECT_DIR/.venv/bin/python' version='3.12.6'

Current Stack: $ORGA/$PROJECT/test

TYPE                                       URN
$RESOURCES


Found no pending operations associated with test

Backend
Name           https://$PULUMI_BACKEND_URL
URL            https://$PULUMI_BACKEND_URL/Stefan-Prietl
User           Stefan-Prietl
Organizations  Stefan-Prietl, $ORGAS
Token type     personal

Dependencies:
NAME                 VERSION
annotated-types      0.7.0
ansible-core         2.17.4
pip                  24.0
pre-commit           3.8.0
pydantic_core        2.23.4
pyright              1.1.381
pytest-cov           5.0.0
rope                 1.13.0
ruff                 0.6.7
ruyaml               0.91.0
typer                0.12.5
yamllint             1.35.1

Pulumi locates its logs in /var/folders/5b/dd8bgp9178s13b8bm4g7vhs40000gn/T/ by default

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).
@ederst ederst added kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team labels Oct 2, 2024
@VenelinMartinov VenelinMartinov linked a pull request Oct 4, 2024 that will close this issue
Open
@VenelinMartinov VenelinMartinov removed the needs-triage Needs attention from the triage team label Oct 4, 2024
@VenelinMartinov
Copy link

Thanks for reporting @ederst and sorry for the inconvenience, I've raised a PR to fix this: Use automatic module mappings in Openstack provider #692

It also automates this for future resources, so we should not see this again.

@VenelinMartinov VenelinMartinov self-assigned this Oct 4, 2024
@VenelinMartinov
Copy link

Ran into some issues with the PR, will try to resolve them early next week, sorry for the delay.

@ederst
Copy link
Contributor Author

ederst commented Oct 24, 2024

Ran into some issues with the PR, will try to resolve them early next week, sorry for the delay.

Nothing to worry about, we currently use the Loadbalancer resource mapped at index and it works just fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VenelinMartinov VenelinMartinov

Labels
kind/bug Some behavior is incorrect or out of spec
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use automatic module mappings in Openstack provider pulumi/pulumi-openstack
2 participants
@ederst @VenelinMartinov