switch to ensure_packages()

The ruby module is used as a dependency in many other component modules.
Some of them also define the `ruby` package or any of the other packages
here. This leads to duplicate resources and a failing catalog. As a
workaround I migrated all package resources to `ensure_packages()` from
stdlib and increased the minimal stdlib version from 4.13.1 to 4.19.0.

Author: bastelfreak

manifests/dev.pp

@@ -114,36 +114,18 @@
   # specify a version and it will just silently continue installing the
   # default version.
   if $ruby_dev {
-    package { $ruby_dev:
-      ensure  => $ensure,
-      before  => Package['rake', 'bundler'],
-      require => Package['ruby'],
-    }
+    ensure_packages([$ruby_dev], {'ensure' => $ensure, 'before' => Package['rake', 'bundler'], 'require' => Package['ruby'] })
   }
 
   if $rake_package {
-    package { 'rake':
-      ensure   => $rake_ensure,
-      name     => $rake_package,
-      provider => $rake_provider,
-      require  => Package['ruby'],
-    }
+    ensure_packages(['rake'], {'ensure' => $rake_ensure, 'name' => $rake_package, 'provider' => $rake_provider, 'require' => Package['ruby'] })
   }
 
   if $bundler_package {
-    package { 'bundler':
-      ensure   => $bundler_ensure,
-      name     => $bundler_package,
-      provider => $bundler_provider,
-      require  => Package['ruby'],
-    }
+    ensure_packages(['bundler'], {'ensure' => $bundler_ensure, 'name' => $bundler_package, 'provider' => $bundler_provider, 'require' => Package['ruby'] })
   }
 
   if $ruby_dev_gems {
-    package { $ruby_dev_gems:
-      ensure   => $ensure,
-      provider => gem,
-    }
+    ensure_packages([$ruby_dev_gems], {'ensure' => $ensure, 'provider' => 'gem' })
   }
-
 }

manifests/init.pp

@@ -158,10 +158,7 @@
   # available. It's a bit misleading for the user, though, since they can
   # specify a version and it will just silently continue installing the
   # default version.
-  package { 'ruby':
-    ensure => $ruby_package_ensure,
-    name   => $real_ruby_package,
-  }
+  ensure_packages(['ruby'], {'ensure' => $ruby_package_ensure, 'name' => $real_ruby_package })
 
   # if rubygems_update is set to true then we only need to make the package
   # resource for rubygems ensure to installed, we'll let rubygems-update
@@ -174,21 +171,11 @@
   }
 
   if $rubygems_package {
-    package { 'rubygems':
-      ensure  => $rubygems_ensure,
-      name    => $rubygems_package,
-      require => Package['ruby'],
-    }
+    ensure_packages(['rubygems'], {'ensure' => $rubygems_ensure, 'name' => $rubygems_package, 'require' => Package['ruby'] })
   }
 
   if $rubygems_update {
-    package { 'rubygems-update':
-      ensure   => $gems_version,
-      provider => 'gem',
-      require  => Package['rubygems'],
-      notify   => Exec['ruby::update_rubygems'],
-    }
-
+    ensure_packages(['rubygems-update'], {'ensure' => $gems_version, 'provider' => 'gem', 'require' => Package['rubygems'], 'notify' => Exec['ruby::update_rubygems']})
     exec { 'ruby::update_rubygems':
       path        => '/usr/local/bin:/usr/bin:/bin',
       command     => 'update_rubygems',

metadata.json

@@ -74,7 +74,7 @@
   ],
   "dependencies": [
     {
-      "name":"puppetlabs/stdlib","version_requirement":">= 4.13.1 < 6.0.0"
+      "name":"puppetlabs/stdlib","version_requirement":">= 4.19.0 < 6.0.0"
     }
   ]
 }