From 51ef5eb281a022b96fd56ee228fb13ced86a8531 Mon Sep 17 00:00:00 2001 From: Tim Meusel Date: Wed, 9 Apr 2025 09:47:58 +0200 Subject: [PATCH 1/3] Add base64 dependency On modern ruby, base64 moved from MRI Ruby core to a standalone gem. Without this change, we get this error: ``` lib/puppet_forge/v3/release.rb:5: warning: base64 was loaded from the standard library, but is not part of the default gems starting from Ruby 3.4.0. You can add base64 to your Gemfile or gemspec to silence this warning. ``` --- puppet_forge.gemspec | 1 + 1 file changed, 1 insertion(+) diff --git a/puppet_forge.gemspec b/puppet_forge.gemspec index 6f33481..1103f3d 100644 --- a/puppet_forge.gemspec +++ b/puppet_forge.gemspec @@ -22,6 +22,7 @@ Gem::Specification.new do |spec| spec.add_runtime_dependency "faraday", "~> 2.0" spec.add_runtime_dependency "faraday-follow_redirects", "~> 0.3.0" + spec.add_runtime_dependency 'base64', '~> 0.2.0' spec.add_dependency "semantic_puppet", "~> 1.0" spec.add_dependency "minitar", '~> 1.0', '>= 1.0.2' From c4bc4cb717efc4bc3a324586acf9e1f2dc72cd47 Mon Sep 17 00:00:00 2001 From: Tim Meusel Date: Wed, 9 Apr 2025 09:50:38 +0200 Subject: [PATCH 2/3] Add Ruby 3.3 & 3.4 to CI --- .github/workflows/ruby-rspec.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/ruby-rspec.yml b/.github/workflows/ruby-rspec.yml index f133975..5cf9b6d 100644 --- a/.github/workflows/ruby-rspec.yml +++ b/.github/workflows/ruby-rspec.yml @@ -15,6 +15,8 @@ jobs: strategy: matrix: ruby: + - '3.4' + - '3.3' - '3.2' - '3.1' From db1efe7e6c114715f81458f2b83090411f903908 Mon Sep 17 00:00:00 2001 From: Tim Meusel Date: Wed, 9 Apr 2025 11:39:04 +0200 Subject: [PATCH 3/3] gemspec: sort gems alphabetically --- puppet_forge.gemspec | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/puppet_forge.gemspec b/puppet_forge.gemspec index 1103f3d..612b61e 100644 --- a/puppet_forge.gemspec +++ b/puppet_forge.gemspec @@ -20,17 +20,17 @@ Gem::Specification.new do |spec| spec.required_ruby_version = '>= 3.1.0' + spec.add_runtime_dependency "base64", '~> 0.2.0' spec.add_runtime_dependency "faraday", "~> 2.0" spec.add_runtime_dependency "faraday-follow_redirects", "~> 0.3.0" - spec.add_runtime_dependency 'base64', '~> 0.2.0' - spec.add_dependency "semantic_puppet", "~> 1.0" spec.add_dependency "minitar", '~> 1.0', '>= 1.0.2' + spec.add_dependency "semantic_puppet", "~> 1.0" + spec.add_development_dependency "cane" + spec.add_development_dependency "pry-byebug" spec.add_development_dependency "rake" + spec.add_development_dependency "redcarpet" spec.add_development_dependency "rspec", "~> 3.0" spec.add_development_dependency "simplecov" - spec.add_development_dependency "cane" spec.add_development_dependency "yard" - spec.add_development_dependency "redcarpet" - spec.add_development_dependency "pry-byebug" end