rubocop update

Author: LukasAud

.rubocop.yml

@@ -1,8 +1,11 @@
 ---
+inherit_from: .rubocop_todo.yml
+
 require:
 - rubocop-performance
 - rubocop-rspec
 AllCops:
+  NewCops: enable
   DisplayCopNames: true
   TargetRubyVersion: '3.1'
   SuggestExtensions: false

.rubocop_todo.yml

@@ -0,0 +1,33 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2025-04-09 15:15:52 UTC using RuboCop version 1.70.0.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 1
+# This cop supports unsafe autocorrection (--autocorrect-all).
+Lint/OrAssignmentToConstant:
+  Exclude:
+    - 'lib/puppet-lint/plugins/version.rb'
+
+# Offense count: 1
+# This cop supports unsafe autocorrection (--autocorrect-all).
+Style/ArrayIntersect:
+  Exclude:
+    - 'lib/puppet-lint/plugins/check_unsafe_interpolations.rb'
+
+# Offense count: 1
+# This cop supports unsafe autocorrection (--autocorrect-all).
+Style/ConcatArrayLiterals:
+  Exclude:
+    - 'lib/puppet-lint/plugins/check_unsafe_interpolations.rb'
+
+# Offense count: 3
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: literals, strict
+Style/MutableConstant:
+  Exclude:
+    - 'lib/puppet-lint/plugins/check_unsafe_interpolations.rb'

Gemfile

@@ -28,7 +28,7 @@ group :coverage, optional: ENV['COVERAGE']!='yes' do
 end
 
 group :rubocop do
-  gem 'rubocop', '~> 1.6.1', require: false
+  gem 'rubocop', '~> 1.70.0', require: false
   gem 'rubocop-performance', '~> 1.9.1', require: false
   gem 'rubocop-rspec', '~> 2.0.1', require: false
 end

lib/puppet-lint/plugins/check_unsafe_interpolations.rb

@@ -1,7 +1,7 @@
 PuppetLint.new_check(:check_unsafe_interpolations) do
-  COMMANDS = Array['command', 'onlyif', 'unless']
-  INTERPOLATED_STRINGS = Array[:DQPRE, :DQMID]
-  USELESS_CHARS = Array[:WHITESPACE, :COMMA]
+  COMMANDS = ['command', 'onlyif', 'unless']
+  INTERPOLATED_STRINGS = [:DQPRE, :DQMID]
+  USELESS_CHARS = [:WHITESPACE, :COMMA]
   def check
     # Gather any exec commands' resources into an array
     exec_resources = resource_indexes.map { |resource|
@@ -33,7 +33,7 @@ def check_unsafe_title(title)
   def check_unsafe_interpolations(command_resources)
     command_resources[:tokens].each do |token|
       # Skip iteration if token isn't a command of type :NAME
-      next unless COMMANDS.include?(token.value) && (token.type == :NAME || token.type == :UNLESS)
+      next unless COMMANDS.include?(token.value) && [:NAME, :UNLESS].include?(token.type)
       # Don't check the command if it is parameterised
       next if parameterised?(token)
 

puppet-lint-check_unsafe_interpolations.gemspec

@@ -5,7 +5,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'puppet-lint/plugins/version'
 
 Gem::Specification.new do |spec|
-  spec.name          = "puppet-lint-check_unsafe_interpolations"
+  spec.name          = 'puppet-lint-check_unsafe_interpolations'
   spec.version       = CheckUnsafeInterpolations::VERSION
   spec.authors       = ['Puppet, Inc.']
   spec.files         = Dir[
@@ -20,7 +20,8 @@ Gem::Specification.new do |spec|
   EOF
   spec.homepage      = 'https://github.com/puppetlabs/puppet-lint-check_unsafe_interpolations'
   spec.license       = 'Apache-2.0'
-  spec.required_ruby_version = Gem::Requirement.new(">= 3.1".freeze)
+  spec.required_ruby_version = Gem::Requirement.new('>= 3.1')
 
   spec.add_dependency 'puppet-lint', '~> 4.0'
+  spec.metadata['rubygems_mfa_required'] = 'true'
 end