Skip to content
This repository was archived by the owner on Jun 1, 2023. It is now read-only.

Commit 32e1986

Browse files
suckatrashsuckatrash
authored
Merge pull request #63 from Sharpie/fix-pdp-pool-wait-metrics
Improve PuppetDB metric dashboards
2 parents cf763f5 + e42b27f commit 32e1986

File tree

4 files changed

+46
-46
lines changed

4 files changed

+46
-46
lines changed

‎files/PuppetDB_Performance.json

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@
124124
},
125125
"yaxes": [
126126
{
127-
"format": "short",
127+
"format": "wps",
128128
"label": null,
129129
"logBase": 1,
130130
"max": null,
@@ -243,7 +243,7 @@
243243
"yaxes": [
244244
{
245245
"format": "ms",
246-
"label": null,
246+
"label": "95th Percentile",
247247
"logBase": 1,
248248
"max": null,
249249
"min": null,
@@ -503,7 +503,7 @@
503503
"yaxes": [
504504
{
505505
"format": "ms",
506-
"label": null,
506+
"label": "95th Percentile",
507507
"logBase": 1,
508508
"max": null,
509509
"min": null,
@@ -621,7 +621,7 @@
621621
"yaxes": [
622622
{
623623
"format": "ms",
624-
"label": null,
624+
"label": "95th Percentile",
625625
"logBase": 1,
626626
"max": null,
627627
"min": null,
@@ -739,7 +739,7 @@
739739
"yaxes": [
740740
{
741741
"format": "ms",
742-
"label": null,
742+
"label": "95th Percentile",
743743
"logBase": 1,
744744
"max": null,
745745
"min": null,

‎files/PuppetDB_Workload.json

Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@
7878
"type": "fill"
7979
}
8080
],
81-
"measurement": "global_message-persistence-time.FiveMinuteRate",
81+
"measurement": "global_message-persistence-time.Mean",
8282
"orderByTime": "ASC",
8383
"policy": "default",
8484
"refId": "A",
@@ -87,7 +87,7 @@
8787
[
8888
{
8989
"params": [
90-
"FiveMinuteRate"
90+
"Mean"
9191
],
9292
"type": "field"
9393
},
@@ -109,7 +109,7 @@
109109
"thresholds": [],
110110
"timeFrom": null,
111111
"timeShift": null,
112-
"title": "Command Persistance Time",
112+
"title": "Average Command Persistance Time",
113113
"tooltip": {
114114
"shared": true,
115115
"sort": 0,
@@ -125,7 +125,7 @@
125125
},
126126
"yaxes": [
127127
{
128-
"format": "short",
128+
"format": "ms",
129129
"label": null,
130130
"logBase": 1,
131131
"max": null,
@@ -208,7 +208,7 @@
208208
"type": "fill"
209209
}
210210
],
211-
"measurement": "PDBReadPool_pool_Usage.50thPercentile",
211+
"measurement": "PDBReadPool_pool_Usage.Mean",
212212
"orderByTime": "ASC",
213213
"policy": "default",
214214
"refId": "A",
@@ -217,7 +217,7 @@
217217
[
218218
{
219219
"params": [
220-
"50thPercentile"
220+
"Mean"
221221
],
222222
"type": "field"
223223
},
@@ -239,7 +239,7 @@
239239
"thresholds": [],
240240
"timeFrom": null,
241241
"timeShift": null,
242-
"title": "Read Pool Usage",
242+
"title": "Average Read Duration",
243243
"tooltip": {
244244
"shared": true,
245245
"sort": 0,
@@ -255,7 +255,7 @@
255255
},
256256
"yaxes": [
257257
{
258-
"format": "short",
258+
"format": "ms",
259259
"label": null,
260260
"logBase": 1,
261261
"max": null,
@@ -326,7 +326,7 @@
326326
"type": "fill"
327327
}
328328
],
329-
"measurement": "PDBReadPool_pool_Wait.FifteenMinuteRate",
329+
"measurement": "PDBReadPool_pool_Wait.999thPercentile",
330330
"orderByTime": "ASC",
331331
"policy": "default",
332332
"refId": "A",
@@ -335,7 +335,7 @@
335335
[
336336
{
337337
"params": [
338-
"FifteenMinuteRate"
338+
"999thPercentile"
339339
],
340340
"type": "field"
341341
},
@@ -357,7 +357,7 @@
357357
"thresholds": [],
358358
"timeFrom": null,
359359
"timeShift": null,
360-
"title": "Read Pool Wait",
360+
"title": "Peak Read Pool Wait",
361361
"tooltip": {
362362
"shared": true,
363363
"sort": 0,
@@ -373,7 +373,7 @@
373373
},
374374
"yaxes": [
375375
{
376-
"format": "short",
376+
"format": "ms",
377377
"label": null,
378378
"logBase": 1,
379379
"max": null,
@@ -574,7 +574,7 @@
574574
"type": "fill"
575575
}
576576
],
577-
"measurement": "PDBWritePool_pool_Usage.50thPercentile",
577+
"measurement": "PDBWritePool_pool_Usage.Mean",
578578
"orderByTime": "ASC",
579579
"policy": "default",
580580
"refId": "A",
@@ -583,7 +583,7 @@
583583
[
584584
{
585585
"params": [
586-
"50thPercentile"
586+
"Mean"
587587
],
588588
"type": "field"
589589
},
@@ -605,7 +605,7 @@
605605
"thresholds": [],
606606
"timeFrom": null,
607607
"timeShift": null,
608-
"title": "Write Pool Usage",
608+
"title": "Average Write Duration",
609609
"tooltip": {
610610
"shared": true,
611611
"sort": 0,
@@ -621,7 +621,7 @@
621621
},
622622
"yaxes": [
623623
{
624-
"format": "short",
624+
"format": "ms",
625625
"label": null,
626626
"logBase": 1,
627627
"max": null,
@@ -692,7 +692,7 @@
692692
"type": "fill"
693693
}
694694
],
695-
"measurement": "PDBWritePool_pool_Wait.FifteenMinuteRate",
695+
"measurement": "PDBWritePool_pool_Wait.999thPercentile",
696696
"orderByTime": "ASC",
697697
"policy": "default",
698698
"refId": "A",
@@ -701,7 +701,7 @@
701701
[
702702
{
703703
"params": [
704-
"FifteenMinuteRate"
704+
"999thPercentile"
705705
],
706706
"type": "field"
707707
},
@@ -723,7 +723,7 @@
723723
"thresholds": [],
724724
"timeFrom": null,
725725
"timeShift": null,
726-
"title": "Write Pool Wait",
726+
"title": "Peak Write Pool Wait",
727727
"tooltip": {
728728
"shared": true,
729729
"sort": 0,
@@ -739,7 +739,7 @@
739739
},
740740
"yaxes": [
741741
{
742-
"format": "short",
742+
"format": "ms",
743743
"label": null,
744744
"logBase": 1,
745745
"max": null,
@@ -988,7 +988,7 @@
988988
"yaxes": [
989989
{
990990
"format": "short",
991-
"label": null,
991+
"label": "Discards per Second",
992992
"logBase": 1,
993993
"max": null,
994994
"min": null,
@@ -1106,7 +1106,7 @@
11061106
"yaxes": [
11071107
{
11081108
"format": "short",
1109-
"label": null,
1109+
"label": "Fatalities per Second",
11101110
"logBase": 1,
11111111
"max": null,
11121112
"min": null,

‎files/Telegraf_PuppetDB_Performance.json

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@
135135
},
136136
"yaxes": [
137137
{
138-
"format": "short",
138+
"format": "wps",
139139
"label": null,
140140
"logBase": 1,
141141
"max": null,
@@ -223,7 +223,7 @@
223223
[
224224
{
225225
"params": [
226-
"FiveMinuteRate"
226+
"95thPercentile"
227227
],
228228
"type": "field"
229229
},
@@ -262,7 +262,7 @@
262262
"yaxes": [
263263
{
264264
"format": "ms",
265-
"label": null,
265+
"label": "95th Percentile",
266266
"logBase": 1,
267267
"max": null,
268268
"min": null,
@@ -725,7 +725,7 @@
725725
"yaxes": [
726726
{
727727
"format": "ms",
728-
"label": null,
728+
"label": "95th Percentile",
729729
"logBase": 1,
730730
"max": null,
731731
"min": null,
@@ -851,7 +851,7 @@
851851
"yaxes": [
852852
{
853853
"format": "ms",
854-
"label": null,
854+
"label": "95th Percentile",
855855
"logBase": 1,
856856
"max": null,
857857
"min": null,
@@ -977,7 +977,7 @@
977977
"yaxes": [
978978
{
979979
"format": "ms",
980-
"label": null,
980+
"label": "95th Percentile",
981981
"logBase": 1,
982982
"max": null,
983983
"min": null,

0 commit comments

Comments
 (0)