Use source instead of eval

Author: pillarsdotnet

templates/update_had_no_effect.sh.epp

@@ -3,10 +3,15 @@
   Integer $timeout = 30,
   Integer $tries = 1,
 | -%>
-eval "$(apt-config shell DIR Dir::Cache || echo "DIR='var/cache/apt'")"
+
+DIR='var/cache/apt'
+EVAL="$(mktemp)"
+apt-config shell DIR Dir::Cache > "$EVAL" && . "$EVAL"
 cd "/$DIR" || exit 0
 OLD="$(mktemp -p "/$DIR")"
-eval "$(apt-config shell CUR Dir::Cache::pkgcache || echo "CUR='pkgcache.bin'")"
+CUR=pkgcache.bin
+apt-config shell CUR DIR::Cache::pkgcache >"$EVAL" && . "$EVAL"
+rm -f "$EVAL"
 ln -f "$CUR" "$OLD"
 TRIES=<%= $tries %>
 while true; do