(MAINT) Apply lint autofixes

Prior to this commit lint would not work properly in Github Actions.

This commit aims to fix the problems that cause failure in CI.

Author: LukasAud

manifests/exec.pp

@@ -40,7 +40,7 @@
     $exec_provider    = undef
   }
 
-  $docker_exec_flags = docker_exec_flags( {
+  $docker_exec_flags = docker_exec_flags({
       detach      => $detach,
       interactive => $interactive,
       tty         => $tty,

manifests/plugin.pp

@@ -58,7 +58,7 @@
   }
 
   if $ensure == 'present' {
-    $docker_plugin_install_flags = docker_plugin_install_flags( {
+    $docker_plugin_install_flags = docker_plugin_install_flags({
         plugin_name           => $plugin_name,
         plugin_alias          => $plugin_alias,
         disable_on_install    => $disable_on_install,
@@ -79,7 +79,7 @@
       unless      => $unless_install,
     }
   } elsif $ensure == 'absent' {
-    $docker_plugin_remove_flags = docker_plugin_remove_flags( {
+    $docker_plugin_remove_flags = docker_plugin_remove_flags({
         plugin_name => $plugin_name,
         force_remove => $force_remove,
       }
@@ -98,7 +98,7 @@
   }
 
   if $enabled {
-    $docker_plugin_enable_flags = docker_plugin_enable_flags( {
+    $docker_plugin_enable_flags = docker_plugin_enable_flags({
         plugin_name  => $plugin_name,
         plugin_alias => $plugin_alias,
         timeout      => $timeout,

manifests/run.pp

@@ -309,7 +309,7 @@
   $depends_array          = any2array($depends)
   $depend_services_array  = any2array($depend_services)
 
-  $docker_run_flags = docker_run_flags( {
+  $docker_run_flags = docker_run_flags({
       cpuset                => any2array($cpuset),
       disable_network       => $disable_network,
       dns                   => any2array($dns),

manifests/secrets.pp

@@ -19,7 +19,7 @@
   $docker_command = "${docker::params::docker_command} secret"
 
   if $ensure == 'present' {
-    $docker_secrets_flags = docker_secrets_flags( {
+    $docker_secrets_flags = docker_secrets_flags({
         ensure      => $ensure,
         label       => $label,
         secret_name => $secret_name,

manifests/services.pp

@@ -112,7 +112,7 @@
   }
 
   if $create {
-    $docker_service_create_flags = docker_service_flags( {
+    $docker_service_create_flags = docker_service_flags({
         detach          => $detach,
         env             => any2array($env),
         service_name    => $service_name,
@@ -133,7 +133,7 @@
     )
 
     $exec_create   = [$docker_command, 'create', '--name', $docker_service_create_flags]
-    $unless_create = ['docker', 'service', 'ps', "${service_name}"]
+    $unless_create = ['docker', 'service', 'ps', $service_name]
 
     exec { "${title} docker service create":
       command     => $exec_create,
@@ -146,7 +146,7 @@
   }
 
   if $update {
-    $docker_service_flags = docker_service_flags( {
+    $docker_service_flags = docker_service_flags({
         detach          => $detach,
         env             => any2array($env),
         service_name    => $service_name,
@@ -175,7 +175,7 @@
   }
 
   if $scale {
-    $docker_service_flags = docker_service_flags( {
+    $docker_service_flags = docker_service_flags({
         service_name => $service_name,
         replicas     => $replicas,
         extra_params => any2array($extra_params),

manifests/stack.pp

@@ -49,7 +49,7 @@
   }
 
   if $ensure == 'present' {
-    $docker_stack_flags = docker_stack_flags ( {
+    $docker_stack_flags = docker_stack_flags ({
         stack_name         => $stack_name,
         bundle_file        => $bundle_file,
         compose_files      => $compose_files,

manifests/swarm.pp

@@ -101,7 +101,7 @@
   $docker_command = "${docker::params::docker_command} swarm"
 
   if $init {
-    $docker_swarm_init_flags = docker_swarm_init_flags( {
+    $docker_swarm_init_flags = docker_swarm_init_flags({
         init                          => $init,
         advertise_addr                => $advertise_addr,
         autolock                      => $autolock,
@@ -130,7 +130,7 @@
   }
 
   if $join {
-    $docker_swarm_join_flags = docker_swarm_join_flags( {
+    $docker_swarm_join_flags = docker_swarm_join_flags({
         join           => $join,
         advertise_addr => $advertise_addr,
         listen_addr    => $listen_addr,

spec/shared_examples/services.rb

@@ -57,7 +57,7 @@
     )
 
     exec_create   = [docker_command, 'create', '--name', docker_service_create_flags]
-    unless_create = ['docker', 'service', 'ps', "#{service_name == :undef ? '' : service_name}"]
+    unless_create = ['docker', 'service', 'ps', (service_name == :undef ? '' : service_name).to_s]
 
     it {
       is_expected.to contain_exec("#{title} docker service create").with(